* [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device
@ 2021-06-18 8:47 =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-18 21:42 ` Nguyen, Anthony L
0 siblings, 1 reply; 6+ messages in thread
From: =?unknown-8bit?q?J=C4=99drzej?= Jagielski @ 2021-06-18 8:47 UTC (permalink / raw)
To: intel-wired-lan
Add kernel trace that device was removed.
Currently there is no such information.
I.e. Host admin removes a PCI device from a VM,
than on VM shall be info about the event.
This patch adds info log to iavf_remove function.
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 4fead5903..b2a5fcb52 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -3973,6 +3973,7 @@ static void iavf_remove(struct pci_dev *pdev)
err);
}
+ dev_info(&adapter->pdev->dev, "Removing device\n");
/* Shut down all the garbage mashers on the detention level */
adapter->state = __IAVF_REMOVE;
adapter->aq_required = 0;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device
2021-06-18 8:47 [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device =?unknown-8bit?q?J=C4=99drzej?= Jagielski
@ 2021-06-18 21:42 ` Nguyen, Anthony L
0 siblings, 0 replies; 6+ messages in thread
From: Nguyen, Anthony L @ 2021-06-18 21:42 UTC (permalink / raw)
To: intel-wired-lan
On Fri, 2021-06-18 at 08:47 +0000, J?drzej Jagielski wrote:
> Add kernel trace that device was removed.
> Currently there is no such information.
> I.e. Host admin removes a PCI device from a VM,
> than on VM shall be info about the event.
>
> This patch adds info log to iavf_remove function.
>
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Are you using the correct tree? Rebasing before you send? This patch
doesn't apply.
Also, can you change either your From or Signed-off-by to match?
WARNING: From:/Signed-off-by: email name mismatch: 'From: "J?drzej
Jagielski" <jedrzej.jagielski@intel.com>' != 'Signed-off-by: Jedrzej
Jagielski <jedrzej.jagielski@intel.com>'
>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 4fead5903..b2a5fcb52 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -3973,6 +3973,7 @@ static void iavf_remove(struct pci_dev *pdev)
> err);
> }
>
> + dev_info(&adapter->pdev->dev, "Removing device\n");
> /* Shut down all the garbage mashers on the detention level */
> adapter->state = __IAVF_REMOVE;
> adapter->aq_required = 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device
2021-06-21 11:28 ` kernel test robot
(?)
@ 2021-06-21 15:25 ` Philip Li
-1 siblings, 0 replies; 6+ messages in thread
From: Philip Li @ 2021-06-21 15:25 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4650 bytes --]
On Mon, Jun 21, 2021 at 07:28:07PM +0800, kernel test robot wrote:
> Hi "Jędrzej,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/J-drzej-Jagielski/iavf-Add-trace-while-removing-device/20210621-161419
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git adc2e56ebe6377f5c032d96aee0feac30a640453
> config: x86_64-randconfig-a012-20210621 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e1adf90826a57b674eee79b071fb46c1f5683cd0)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/57afb781e6da71b3eb1c32b7485adf57de789a1b
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review J-drzej-Jagielski/iavf-Add-trace-while-removing-device/20210621-161419
> git checkout 57afb781e6da71b3eb1c32b7485adf57de789a1b
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
Sorry for the broken report, kindly ignore this, we will fix
this asap.
>
> arch/x86/Makefile:148: CONFIG_X86_X32 enabled but no binutils support
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/cmac.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/md5.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/sha512_generic.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/drivers/net/net_failover.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/drivers/net/virtio_net.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/fs/cifs/cifs.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/fs/nfs/nfsv4.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/lib/crypto/libarc4.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/core/failover.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/dns_resolver/dns_resolver.ko', needed by '__modinst'.
> >> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/sunrpc/auth_gss/auth_rpcgss.ko', needed by '__modinst'.
> make[2]: Target '__modinst' not remade because of errors.
> make[1]: *** [Makefile:1773: modules_install] Error 2
> make: *** [Makefile:215: __sub-make] Error 2
> make: Target 'modules_install' not remade because of errors.
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device
2021-06-21 8:10 =?unknown-8bit?q?J=C4=99drzej?= Jagielski
@ 2021-06-21 11:28 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-21 11:28 UTC (permalink / raw)
To: intel-wired-lan
Hi "J?drzej,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/J-drzej-Jagielski/iavf-Add-trace-while-removing-device/20210621-161419
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git adc2e56ebe6377f5c032d96aee0feac30a640453
config: x86_64-randconfig-a012-20210621 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e1adf90826a57b674eee79b071fb46c1f5683cd0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/57afb781e6da71b3eb1c32b7485adf57de789a1b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review J-drzej-Jagielski/iavf-Add-trace-while-removing-device/20210621-161419
git checkout 57afb781e6da71b3eb1c32b7485adf57de789a1b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/x86/Makefile:148: CONFIG_X86_X32 enabled but no binutils support
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/cmac.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/md5.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/sha512_generic.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/drivers/net/net_failover.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/drivers/net/virtio_net.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/fs/cifs/cifs.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/fs/nfs/nfsv4.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/lib/crypto/libarc4.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/core/failover.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/dns_resolver/dns_resolver.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/sunrpc/auth_gss/auth_rpcgss.ko', needed by '__modinst'.
make[2]: Target '__modinst' not remade because of errors.
make[1]: *** [Makefile:1773: modules_install] Error 2
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'modules_install' not remade because of errors.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all at lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 48805 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210621/1a0e4829/attachment-0001.bin>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device
@ 2021-06-21 11:28 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-06-21 11:28 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4234 bytes --]
Hi "Jędrzej,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/J-drzej-Jagielski/iavf-Add-trace-while-removing-device/20210621-161419
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git adc2e56ebe6377f5c032d96aee0feac30a640453
config: x86_64-randconfig-a012-20210621 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e1adf90826a57b674eee79b071fb46c1f5683cd0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/57afb781e6da71b3eb1c32b7485adf57de789a1b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review J-drzej-Jagielski/iavf-Add-trace-while-removing-device/20210621-161419
git checkout 57afb781e6da71b3eb1c32b7485adf57de789a1b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/x86/Makefile:148: CONFIG_X86_X32 enabled but no binutils support
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/cmac.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/md5.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/crypto/sha512_generic.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/drivers/net/net_failover.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/drivers/net/virtio_net.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/fs/cifs/cifs.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/fs/nfs/nfsv4.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/lib/crypto/libarc4.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/core/failover.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/dns_resolver/dns_resolver.ko', needed by '__modinst'.
>> make[2]: *** No rule to make target '/tmp/kernel/x86_64-randconfig-a012-20210621/clang-13/57afb781e6da71b3eb1c32b7485adf57de789a1b/lib/modules/5.13.0-rc6+/kernel/net/sunrpc/auth_gss/auth_rpcgss.ko', needed by '__modinst'.
make[2]: Target '__modinst' not remade because of errors.
make[1]: *** [Makefile:1773: modules_install] Error 2
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'modules_install' not remade because of errors.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 48805 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device
@ 2021-06-21 8:10 =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-21 11:28 ` kernel test robot
0 siblings, 1 reply; 6+ messages in thread
From: =?unknown-8bit?q?J=C4=99drzej?= Jagielski @ 2021-06-21 8:10 UTC (permalink / raw)
To: intel-wired-lan
Add kernel trace that device was removed.
Currently there is no such information.
I.e. Host admin removes a PCI device from a VM,
than on VM shall be info about the event.
This patch adds info log to iavf_remove function.
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Signed-off-by: J?drzej Jagielski <jedrzej.jagielski@intel.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 4fead59..b2a5fcb 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -3973,6 +3973,7 @@ static void iavf_remove(struct pci_dev *pdev)
err);
}
+ dev_info(&adapter->pdev->dev, "Removing device\n");
/* Shut down all the garbage mashers on the detention level */
adapter->state = __IAVF_REMOVE;
adapter->aq_required = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-21 15:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18 8:47 [Intel-wired-lan] [PATCH net-next v1] iavf: Add trace while removing device =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-18 21:42 ` Nguyen, Anthony L
2021-06-21 8:10 =?unknown-8bit?q?J=C4=99drzej?= Jagielski
2021-06-21 11:28 ` kernel test robot
2021-06-21 11:28 ` kernel test robot
2021-06-21 15:25 ` Philip Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.