From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH 2/2] can: netlink: clear tdc if fd is turned off
Date: Fri, 18 Jun 2021 11:11:12 +0200 [thread overview]
Message-ID: <20210618091112.oi4ozyznneeabhan@pengutronix.de> (raw)
In-Reply-To: <20210618081904.141114-3-mailhol.vincent@wanadoo.fr>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On 18.06.2021 17:19:04, Vincent Mailhol wrote:
> When the FD is turned off through the netlink interface, the value
values
> still remain in struct can_tdc and are displayed despite of the
> feature being disabled.
>
> This patch clears priv->tdc whenever FD is set to off. This way, the
> TDC variables are not displayed anymore.
>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
> Hi Marc,
>
> I would suggest to squash that into commit 5eb2cd8e2ded ("can:
> netlink: add interface for CAN-FD Transmitter Delay Compensation
> (TDC)").
Will do.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-06-18 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 8:19 [PATCH 0/2] Stop showing data bittiming if FD is turned off Vincent Mailhol
2021-06-18 8:19 ` [PATCH 1/2] can: netlink: clear data_bittiming if fd " Vincent Mailhol
2021-06-18 9:10 ` Marc Kleine-Budde
2021-06-18 9:58 ` Vincent MAILHOL
2021-06-18 8:19 ` [PATCH 2/2] can: netlink: clear tdc " Vincent Mailhol
2021-06-18 9:11 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618091112.oi4ozyznneeabhan@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.