From: Pavel Machek <pavel@denx.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Colin Ian King <colin.king@canonical.com>,
Raju Rangoju <rajur@chelsio.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCHv2] cxgb4: fix wrong shift.
Date: Fri, 18 Jun 2021 11:29:48 +0200 [thread overview]
Message-ID: <20210618092948.GA19615@duo.ucw.cz> (raw)
In-Reply-To: <20210615095651.GA7479@duo.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
While fixing coverity warning, commit dd2c79677375 introduced typo in
shift value. Fix that.
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Fixes: dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
WORD_MASK, f->fs.nat_lip[3] |
f->fs.nat_lip[2] << 8 |
f->fs.nat_lip[1] << 16 |
- (u64)f->fs.nat_lip[0] << 25, 1);
+ (u64)f->fs.nat_lip[0] << 24, 1);
}
}
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-06-18 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:56 [PATCH] cxgb4: fix wrong shift Pavel Machek
2021-06-15 10:17 ` Greg KH
2021-06-15 18:22 ` David Miller
2021-06-18 9:30 ` Pavel Machek
2021-06-18 9:29 ` Pavel Machek [this message]
2021-06-18 19:00 ` [PATCHv2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618092948.GA19615@duo.ucw.cz \
--to=pavel@denx.de \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.