From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C237C48BE8 for ; Fri, 18 Jun 2021 12:30:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4372961248 for ; Fri, 18 Jun 2021 12:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234391AbhFRMcb (ORCPT ); Fri, 18 Jun 2021 08:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234352AbhFRMbu (ORCPT ); Fri, 18 Jun 2021 08:31:50 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4C63C0611C0 for ; Fri, 18 Jun 2021 05:29:34 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id s15so8365021edt.13 for ; Fri, 18 Jun 2021 05:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=osMXZB6zVUCRxwMKbtanTuzmkF8QH55sKJbs0+x3AmY=; b=fVsM4046HINJ+QXPvD+ppPBaulEvl1ZxQ1MH8dRFpJhgXjGHguP7eGr0SgfcKYh6yH qIy2w8HjMHa9OCz5oyskCTQub2iP+V+NFuVDD7ZzbzbXqEBPFvgy9egJo39iARxC5Qhc 1vFXSaypcnh7dCd5NTYkaj5yqd70jrRQLAdlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=osMXZB6zVUCRxwMKbtanTuzmkF8QH55sKJbs0+x3AmY=; b=kkliibKxwq90ZzpzQP9g5pkuF+ikBr39zGd94PNTopbfXZcARvgVwLrQKRqfBryQro XZAEZ14RFltMioWX1CBBex80yFsFLlsSWNBIwCsvVe0E0TLzv6J5ETkKRcdVWx7sGy62 ym2P/nWZU6kmwwfJvyn+axVIqxREuU8pwVM1DcaBDAptlIUO7Kz/ok84UB1nRoRdp04A 4q7tUtHgHa57dRWi9u1cVQ56NcFtVIr0rvUghCL2VQNF5ZTqWNH0P7NLuwuxwlAyhXVF axeWW9mfw05JXuygyVdTyKz6PVXroZP76KEQImxsxJjPu1jScs+PCqzresmt24yf3TeV V93w== X-Gm-Message-State: AOAM531cB3MZC3LR9l1iLecmwFxqoLB7U5gVPeRyhr9y8a1KL2YjWn7d Hcs7sHrIUPtfji9vhUtncIGmlg== X-Google-Smtp-Source: ABdhPJz9wWQk+ezYuhFBHw+H6Ox6XkwxaTroqTpWAQ/XCc2CXrQpbYH0+q8ymt1/A151HmjnZQCvRA== X-Received: by 2002:aa7:cdd9:: with SMTP id h25mr4692295edw.246.1624019373590; Fri, 18 Jun 2021 05:29:33 -0700 (PDT) Received: from alco.lan (80.71.134.83.ipv4.parknet.dk. [80.71.134.83]) by smtp.gmail.com with ESMTPSA id o26sm4336403edt.62.2021.06.18.05.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 05:29:33 -0700 (PDT) From: Ricardo Ribalda To: Laurent Pinchart , Hans Verkuil , Mauro Carvalho Chehab , Sergey Senozhatsky , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, tfiga@chromium.org Cc: Ricardo Ribalda Subject: [PATCH v10 12/21] media: uvcvideo: Increase the size of UVC_METADATA_BUF_SIZE Date: Fri, 18 Jun 2021 14:29:14 +0200 Message-Id: <20210618122923.385938-13-ribalda@chromium.org> X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog In-Reply-To: <20210618122923.385938-1-ribalda@chromium.org> References: <20210618122923.385938-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hans has discovered that in his test device, for the H264 format bytesused goes up to about 570, for YUYV it will actually go up to a bit over 5000 bytes, and for MJPG up to about 2706 bytes. We should also, according to V4L2_META_FMT_UVC docs, drop headers when the buffer is full. Credit-to: Hans Verkuil Reviewed-by: Hans Verkuil Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvcvideo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h index 5eb7e87f8430..37a092d717cf 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -524,7 +524,7 @@ struct uvc_stats_stream { unsigned int max_sof; /* Maximum STC.SOF value */ }; -#define UVC_METADATA_BUF_SIZE 1024 +#define UVC_METADATA_BUF_SIZE 10240 /** * struct uvc_copy_op: Context structure to schedule asynchronous memcpy -- 2.32.0.288.g62a8d224e6-goog