From: Mel Gorman <mgorman@techsingularity.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-mm@kvack.org
Subject: Re: [bug report] mm/page_alloc: add an array-based interface to the bulk page allocator
Date: Fri, 18 Jun 2021 13:49:00 +0100 [thread overview]
Message-ID: <20210618124900.GT30378@techsingularity.net> (raw)
In-Reply-To: <20210618115943.GY1901@kadam>
On Fri, Jun 18, 2021 at 02:59:43PM +0300, Dan Carpenter wrote:
> On Fri, Jun 18, 2021 at 11:14:41AM +0100, Mel Gorman wrote:
> > On Fri, Jun 18, 2021 at 12:03:45PM +0300, Dan Carpenter wrote:
> > > Hello Mel Gorman,
> > >
> > > The patch 0f87d9d30f21: "mm/page_alloc: add an array-based interface
> > > to the bulk page allocator" from Apr 29, 2021, leads to the following
> > > static checker warning:
> > >
> > > mm/page_alloc.c:5338 __alloc_pages_bulk()
> > > warn: potentially one past the end of array 'page_array[nr_populated]'
> > >
> >
> > Thanks Dan.
> >
> > Does this work for you?
> >
>
> It works for me. It doesn't silence the Smatch warning because Smatch
> thinks that all the callers pass a non-NULL "page_array" and gets
> confused by the "if (page_array)" checks. :/
>
Well..... it's technically correct because the list interface is currently
unused. The thinking is to leave it for now and delete the list interface
if it remains unused after a while.
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2021-06-18 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 9:03 [bug report] mm/page_alloc: add an array-based interface to the bulk page allocator Dan Carpenter
2021-06-18 10:14 ` Mel Gorman
2021-06-18 11:59 ` Dan Carpenter
2021-06-18 12:49 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618124900.GT30378@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=dan.carpenter@oracle.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.