From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] tpci: fix NULL pointer dereference on wrong test invocation
Date: Fri, 18 Jun 2021 15:05:35 +0200 [thread overview]
Message-ID: <20210618130536.54806-1-krzysztof.kozlowski@canonical.com> (raw)
Fix NULL pointer dereference when a ltp_tpci test case is started before
choosing the device:
ltp_tpci: test-case 12
ltp_tpci: assign resources
ltp_tpci: assign resource #0
BUG: kernel NULL pointer dereference, address: 00000000000003b8
...
Call Trace:
dev_attr_store+0x17/0x30
sysfs_kf_write+0x3e/0x50
kernfs_fop_write_iter+0x13c/0x1d0
new_sync_write+0x113/0x1a0
vfs_write+0x1c5/0x200
ksys_write+0x67/0xe0
__x64_sys_write+0x1a/0x20
do_syscall_64+0x49/0xc0
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
index 5b48aa0c7ece..f2d4a4ba497c 100644
--- a/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
+++ b/testcases/kernel/device-drivers/pci/tpci_kernel/ltp_tpci.c
@@ -556,6 +556,11 @@ static int test_case(unsigned int cmd)
{
int rc = TSKIP;
+ if (!ltp_pci.dev || !ltp_pci.bus) {
+ prk_err("device or bus not selected for test");
+ return TFAIL;
+ }
+
switch (cmd) {
case PCI_ENABLE:
rc = pci_enable();
--
2.27.0
next reply other threads:[~2021-06-18 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 13:05 Krzysztof Kozlowski [this message]
2021-06-18 13:05 ` [LTP] [PATCH 2/2] tpci: accept ENOMEM resource failure with virtio-pci Krzysztof Kozlowski
2021-06-28 20:24 ` Petr Vorel
2021-07-26 11:43 ` Petr Vorel
2021-06-24 19:32 ` [LTP] [PATCH 1/2] tpci: fix NULL pointer dereference on wrong test invocation Krzysztof Kozlowski
2021-06-28 20:00 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618130536.54806-1-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.