From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AEFC48BDF for ; Fri, 18 Jun 2021 14:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C27761260 for ; Fri, 18 Jun 2021 14:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234728AbhFROy6 (ORCPT ); Fri, 18 Jun 2021 10:54:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:44084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234558AbhFROy4 (ORCPT ); Fri, 18 Jun 2021 10:54:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90485610A3; Fri, 18 Jun 2021 14:52:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:52:42 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Andrew Jones Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210618145241.GG16116@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618132826.54670-8-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > +When this capability is enabled all memory in (non-device) memslots must not > +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > +in an -EINVAL return. "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as that's a kernel internal and not something the VMM needs to be aware of. Just say something like "memslots must be mapped as shareable (MAP_SHARED)". Otherwise: Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83707C48BE8 for ; Fri, 18 Jun 2021 14:53:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 111EA610A3 for ; Fri, 18 Jun 2021 14:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 111EA610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luFsJ-00070K-1C for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 10:53:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luFrX-0006Ln-6u for qemu-devel@nongnu.org; Fri, 18 Jun 2021 10:52:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:32788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luFrU-000278-Sq for qemu-devel@nongnu.org; Fri, 18 Jun 2021 10:52:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90485610A3; Fri, 18 Jun 2021 14:52:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:52:42 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210618145241.GG16116@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618132826.54670-8-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > +When this capability is enabled all memory in (non-device) memslots must not > +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > +in an -EINVAL return. "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as that's a kernel internal and not something the VMM needs to be aware of. Just say something like "memslots must be mapped as shareable (MAP_SHARED)". Otherwise: Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF2CC48BDF for ; Fri, 18 Jun 2021 14:52:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id A0EBB61260 for ; Fri, 18 Jun 2021 14:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0EBB61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 429A14A418; Fri, 18 Jun 2021 10:52:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8zdkz1umWFTe; Fri, 18 Jun 2021 10:52:50 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 660C14A4E5; Fri, 18 Jun 2021 10:52:50 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4094D4A3A3 for ; Fri, 18 Jun 2021 10:52:49 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ae55TfVipxZW for ; Fri, 18 Jun 2021 10:52:48 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4804D49F82 for ; Fri, 18 Jun 2021 10:52:48 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 90485610A3; Fri, 18 Jun 2021 14:52:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:52:42 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210618145241.GG16116@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210618132826.54670-8-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > +When this capability is enabled all memory in (non-device) memslots must not > +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > +in an -EINVAL return. "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as that's a kernel internal and not something the VMM needs to be aware of. Just say something like "memslots must be mapped as shareable (MAP_SHARED)". Otherwise: Reviewed-by: Catalin Marinas _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D802C49361 for ; Fri, 18 Jun 2021 14:54:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C33B261260 for ; Fri, 18 Jun 2021 14:54:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C33B261260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W97BN/vw2IzxytR5DNMxGd+0GoTIyxRB91Q7atgd9sU=; b=eSdCaAQ51Kujnr A81OtfR32aM7u2bzgdqjJRkq1YosT68WAe7GH6FED1NqVJJ2EURcfjVioR35SnKHsa554DUrfvPAa L0BhOpSLczsTQ1wCn2NhTdc7JqVg/aeypM3DMnD4OQbbSCXieK4GGDNZ1+ul0dClLggDxdWTaGRl8 9pvzHVUFeV1ZP0S/eF/NkssefUlj6IrpSJHEMeYO+Bt9r4HDQ9bKUaStmeQrYWyRqkWb51vYMC0c7 DIMOBaaBb9aysATSKC2venlblgUDqN9cZYLkn1xpwhAjx4ksuTKGSan4Ly/KqMX3vzq6gegpv2Hdy wiNSzHgInYWMOpizvLsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1luFrW-00EZDh-RN; Fri, 18 Jun 2021 14:52:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1luFrT-00EZDG-K8 for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 14:52:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90485610A3; Fri, 18 Jun 2021 14:52:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:52:42 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Andrew Jones Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210618145241.GG16116@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210618132826.54670-8-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210618_075247_716127_B72B1B3E X-CRM114-Status: UNSURE ( 7.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > +When this capability is enabled all memory in (non-device) memslots must not > +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > +in an -EINVAL return. "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as that's a kernel internal and not something the VMM needs to be aware of. Just say something like "memslots must be mapped as shareable (MAP_SHARED)". Otherwise: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel