From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82219C48BDF for ; Fri, 18 Jun 2021 13:34:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D64246124C for ; Fri, 18 Jun 2021 13:34:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D64246124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luEdr-0007tr-RR for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 09:34:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luEZL-0000tM-Vl for qemu-devel@nongnu.org; Fri, 18 Jun 2021 09:30:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luEZH-0002Ka-U2 for qemu-devel@nongnu.org; Fri, 18 Jun 2021 09:29:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624022994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hn3HWV81bK7fkB5VfHqbq8DBUVgzoU/fGjPi9u+ifN4=; b=GnpQespseg5q+2B6VotWs314AjafssaJAUZk6yIZzlLKTCc08m6cuVPM/OY5utStjr8waW DT/A6fI7+Jd2vGV7ReZAeh75m+Q+2GzDRKoyazt/3DRx0hzn/7B5BaQ/hrwryZj+6L+xaa e07gcViSpmGgZf7q9e2mu+wGL1RJN8Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-KXcBOs9rMUSurmO_wKt9Qg-1; Fri, 18 Jun 2021 09:29:50 -0400 X-MC-Unique: KXcBOs9rMUSurmO_wKt9Qg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 755798015F8; Fri, 18 Jun 2021 13:29:49 +0000 (UTC) Received: from localhost (unknown [10.43.2.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id 180165D6CF; Fri, 18 Jun 2021 13:29:43 +0000 (UTC) Date: Fri, 18 Jun 2021 15:29:43 +0200 From: Igor Mammedov To: Claudio Fontana Subject: Re: [RFC 0/3] qtest: pick tests that require KVM at runtime Message-ID: <20210618152943.2009ad82@redhat.com> In-Reply-To: <2f7ae379-92e0-3274-6944-84a5bce6e82e@suse.de> References: <20210616152455.1270264-1-imammedo@redhat.com> <20210618132647.07cf2008@redhat.com> <2f7ae379-92e0-3274-6944-84a5bce6e82e@suse.de> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.194, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, Eduardo Habkost , mst@redhat.com, Richard Henderson , qemu-devel@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Paolo Bonzini , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 18 Jun 2021 14:43:46 +0200 Claudio Fontana wrote: > On 6/18/21 1:26 PM, Igor Mammedov wrote: > > On Thu, 17 Jun 2021 18:49:17 +0200 > > Claudio Fontana wrote: > > > >> On 6/16/21 5:24 PM, Igor Mammedov wrote: > >>> > >>> Sometimes it's necessary to execute a test that depends on KVM, > >>> however qtest is not aware if tested QEMU binary supports KVM > >>> on the host it the test is executed. > >> > >> Hello, > >> > >> It seems to me that we are constantly re-implementing the same feature with slight variations? > >> > >> Didn't we have a generic series to introduce qtest_has_accel() from Philippe before? > > It's mentioned in cover letter (PS: part) and in [1/3] with rationale > > why this was posted. > > Thought it was separate, but now I see that it uses query-accel underneath. > > Seems strange to add another check to do the same thing, it may point to qtest_has_accel() needing some update? > You mention it is time consuming to use qtest_has_accel(), have you measured an important overhead? > With qtest_has_accel() not even being committed yet, is it already necessary to work around it because it's too slow? Tests are already take a lot of time as is, so I'd try to avoid slowing them down. proposed qtest_has_accel() requires spawning QEMU to probe, which is slow. Worst case would be: = qemu startup time * number of checks * number of targets It's fine to run occasionally, I can take a coffee break while tests run. But put it in context of CI and it multiplies by the number of push requests and starts to eat not only time but also limited CI resources. In current form qtest_has_accel() is only marginally better functionality wise, as it reports all built in accelerators while qtest_has_kvm() accounts only for KVM. qtest_has_kvm() is collecting info about built-in accelerators at configure/build time and that probably could be extended to other accelerators (not a thing that I'm interested in at the moment). So it could be extended to support the same accelerators as currently proposed qtest_has_accel(). Given a less expensive approach exists, the qtest_has_accel() in its current form might be not justifiable. > >> Does this series work with --disable-kvm builds? (TCG-only builds?) > > I'll test. But on the first glance it should work without issues. > > (i.e. kvm only tests will be skipped). > > > >> > >> Thanks, > >> > >> CLaudio > >> > >> > >>> > >>> For an example: > >>> test q35 machine with intel_iommu > >>> This test will run only is KVM is available and fail > >>> to start QEMU if it fallsback to TCG, thus failing whole test. > >>> So if test is executed in VM where nested KVM is not enabled > >>> or on other than x86 host, it will break 'make check-qtest' > >>> > >>> Series adds a lightweight qtest_has_kvm() check, which abuses > >>> build system and should help to avoid running KVM only tests > >>> on hosts that do not support it. > >>> > >>> PS: > >>> there is an alternative 'query-accels' QMP command proposal > >>> https://patchwork.kernel.org/project/qemu-devel/patch/20210503211020.894589-3-philmd@redhat.com/ > >>> which I think is more robust compared to qtest_has_kvm() and > >>> could be extended to take into account machine type. > >>> But it's more complex and what I dislike about it most, > >>> it requires execution of 'probing' QEMU instance to find > >>> execute 'query-accels' QMP command, which is rather resource > >>> consuming. So I'd use query-accels approach only when it's > >>> the only possible option to minimize load on CI systems. > >>> > >>> Igor Mammedov (2): > >>> tests: acpi: q35: test for x2APIC entries in SRAT > >>> tests: acpi: update expected tables blobs > >>> > >>> root (1): > >>> tests: qtest: add qtest_has_kvm() to check if tested bynary supports > >>> KVM > >>> > >>> tests/qtest/libqos/libqtest.h | 7 +++++++ > >>> meson.build | 1 + > >>> tests/data/acpi/q35/APIC.numamem | Bin 0 -> 2686 bytes > >>> tests/data/acpi/q35/DSDT.numamem | Bin 7865 -> 35222 bytes > >>> tests/data/acpi/q35/FACP.numamem | Bin 0 -> 244 bytes > >>> tests/data/acpi/q35/SRAT.numamem | Bin 224 -> 5080 bytes > >>> tests/qtest/bios-tables-test.c | 10 +++++++--- > >>> tests/qtest/libqtest.c | 20 ++++++++++++++++++++ > >>> 8 files changed, 35 insertions(+), 3 deletions(-) > >>> create mode 100644 tests/data/acpi/q35/APIC.numamem > >>> create mode 100644 tests/data/acpi/q35/FACP.numamem > >>> > >> > > >