From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: print name of function causing fs shutdown instead of hex pointer
Date: Fri, 18 Jun 2021 09:05:39 -0700 [thread overview]
Message-ID: <20210618160539.GF158209@locust> (raw)
In-Reply-To: <YMymlgzxg4IYHPyi@infradead.org>
On Fri, Jun 18, 2021 at 02:58:46PM +0100, Christoph Hellwig wrote:
> On Thu, Jun 17, 2021 at 09:10:41AM -0700, Darrick J. Wong wrote:
> > Um, we /do/ log the error already; a full shutdown report looks like:
> >
> > XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file
> > fs/xfs/xfs_log.c. Return address = xfs_trans_mod_sb+0x25
> > XFS (sda): Corruption of in-memory data detected. Shutting down
> > filesystem
>
> Yeah, it's pretty verbose.
>
> > Or are you saying that we should combine them into a single message?
> >
> > XFS (sda): Corruption of in-memory data detected at xlog_write+0x10
> > (fs/xfs/xfs_log.c:2440). Shutting down filesystem.
> >
> > XFS (sda): Log I/O error detected at xlog_write+0x10
> > (fs/xfs/xfs_log.c:2440). Shutting down filesystem.
> >
> > XFS (sda): I/O error detected at xlog_write+0x10
> > (fs/xfs/xfs_log.c:2440). Shutting down filesystem.
> >
> > etc?
>
> I think that reads much nicer. So if we cause some churn in this area
> we might as well go with that.
Ok, I'll prepare a new patch to consolidate all that.
--D
next prev parent reply other threads:[~2021-06-18 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 23:55 [PATCHSET 0/2] xfs: various small fixes Darrick J. Wong
2021-06-16 23:55 ` [PATCH 1/2] xfs: fix type mismatches in the inode reclaim functions Darrick J. Wong
2021-06-17 7:58 ` Christoph Hellwig
2021-06-17 15:14 ` Chandan Babu R
2021-06-18 14:33 ` Brian Foster
2021-06-18 14:59 ` Darrick J. Wong
2021-06-16 23:55 ` [PATCH 2/2] xfs: print name of function causing fs shutdown instead of hex pointer Darrick J. Wong
2021-06-17 8:11 ` Christoph Hellwig
2021-06-17 16:10 ` Darrick J. Wong
2021-06-18 13:58 ` Christoph Hellwig
2021-06-18 16:05 ` Darrick J. Wong [this message]
2021-06-18 14:34 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618160539.GF158209@locust \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.