Re: [PATCH RFC 4/4] ufs: Make host controller state change handling more systematic

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4158 bytes --]

Hi Bart,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on next-20210618]
[cannot apply to scsi/for-next bvanassche/for-next v5.13-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bart-Van-Assche/UFS-patches-for-Linux-kernel-v5-14/20210619-085409
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-randconfig-r035-20210618 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d1baf2895467735ab14f4b3415fce204c0cc8e7f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/0day-ci/linux/commit/fcc87d783f58d9f9ee2c0ccd19c61a57c5941bfb
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bart-Van-Assche/UFS-patches-for-Linux-kernel-v5-14/20210619-085409
        git checkout fcc87d783f58d9f9ee2c0ccd19c61a57c5941bfb
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from drivers/scsi/ufs/ufshcd.c:12:
   In file included from include/linux/async.h:12:
   In file included from include/linux/list.h:9:
   In file included from include/linux/kernel.h:12:
   In file included from include/linux/bitops.h:32:
   In file included from arch/powerpc/include/asm/bitops.h:62:
   arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
   #define __lwsync()      __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
           ^
   <built-in>:309:9: note: previous definition is here
   #define __lwsync __builtin_ppc_lwsync
           ^
>> drivers/scsi/ufs/ufshcd.c:4077:6: error: use of undeclared identifier 'old_state'
           if (old_state != UFSHCD_STATE_ERROR || new_state == UFSHCD_STATE_ERROR)
               ^
>> drivers/scsi/ufs/ufshcd.c:4079:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
                   return true;
                   ^
   drivers/scsi/ufs/ufshcd.c:4077:2: note: previous statement is here
           if (old_state != UFSHCD_STATE_ERROR || new_state == UFSHCD_STATE_ERROR)
           ^
>> drivers/scsi/ufs/ufshcd.c:4081:2: error: expected identifier or '('
           return false;
           ^
>> drivers/scsi/ufs/ufshcd.c:4082:1: error: extraneous closing brace ('}')
   }
   ^
   drivers/scsi/ufs/ufshcd.c:9361:44: warning: shift count >= width of type [-Wshift-count-overflow]
                   if (!dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(64)))
                                                            ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
   #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
                                                        ^ ~~~
   3 warnings and 3 errors generated.


vim +/old_state +4077 drivers/scsi/ufs/ufshcd.c

  4072	
  4073	static bool ufshcd_set_state(struct ufs_hba *hba, enum ufshcd_state new_state)
  4074	{
  4075		lockdep_assert_held(hba->host->host_lock);
  4076	
> 4077		if (old_state != UFSHCD_STATE_ERROR || new_state == UFSHCD_STATE_ERROR)
  4078			hba->ufshcd_state = new_state;
> 4079			return true;
  4080		}
> 4081		return false;
> 4082	}
  4083	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35987 bytes --]