All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: drivers/staging/rtl8723bs/core/rtw_security.c:95:9: warning: variable 'crc' set but not used
Date: Sat, 19 Jun 2021 18:26:08 +0800	[thread overview]
Message-ID: <202106191804.43B29pt1-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3696 bytes --]

tree:   https://github.com/0day-ci/linux/commits/UPDATE-20210619-155350/Jhih-Ming-Huang/rtw_security-fix-cast-to-restricted-__le32/20210616-131056
head:   ed0359e3fa64928e48021387a694f211bc840ff7
commit: ed0359e3fa64928e48021387a694f211bc840ff7 rtw_security: fix cast to restricted __le32
date:   3 hours ago
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ed0359e3fa64928e48021387a694f211bc840ff7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review UPDATE-20210619-155350/Jhih-Ming-Huang/rtw_security-fix-cast-to-restricted-__le32/20210616-131056
        git checkout ed0359e3fa64928e48021387a694f211bc840ff7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/rtl8723bs/core/rtw_security.c: In function 'rtw_wep_decrypt':
>> drivers/staging/rtl8723bs/core/rtw_security.c:95:9: warning: variable 'crc' set but not used [-Wunused-but-set-variable]
      95 |  __le32 crc;
         |         ^~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/crc +95 drivers/staging/rtl8723bs/core/rtw_security.c

    91	
    92	void rtw_wep_decrypt(struct adapter  *padapter, u8 *precvframe)
    93	{
    94		/*  exclude ICV */
  > 95		__le32 crc;
    96		signed int	length;
    97		u32 keylength;
    98		u8 *pframe, *payload, *iv, wepkey[16];
    99		u8  keyindex;
   100		struct	rx_pkt_attrib	 *prxattrib = &(((union recv_frame *)precvframe)->u.hdr.attrib);
   101		struct	security_priv *psecuritypriv = &padapter->securitypriv;
   102		struct arc4_ctx *ctx = &psecuritypriv->recv_arc4_ctx;
   103	
   104		pframe = (unsigned char *)((union recv_frame *)precvframe)->u.hdr.rx_data;
   105	
   106		/* start to decrypt recvframe */
   107		if ((prxattrib->encrypt == _WEP40_) || (prxattrib->encrypt == _WEP104_)) {
   108			iv = pframe+prxattrib->hdrlen;
   109			/* keyindex =(iv[3]&0x3); */
   110			keyindex = prxattrib->key_index;
   111			keylength = psecuritypriv->dot11DefKeylen[keyindex];
   112			memcpy(&wepkey[0], iv, 3);
   113			/* memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11PrivacyKeyIndex].skey[0], keylength); */
   114			memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[keyindex].skey[0], keylength);
   115			length = ((union recv_frame *)precvframe)->u.hdr.len-prxattrib->hdrlen-prxattrib->iv_len;
   116	
   117			payload = pframe+prxattrib->iv_len+prxattrib->hdrlen;
   118	
   119			/* decrypt payload include icv */
   120			arc4_setkey(ctx, wepkey, 3 + keylength);
   121			arc4_crypt(ctx, payload, payload,  length);
   122	
   123			/* calculate icv and compare the icv */
   124			crc = cpu_to_le32(~crc32_le(~0, payload, length - 4));
   125	
   126		}
   127	}
   128	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54837 bytes --]

             reply	other threads:[~2021-06-19 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 10:26 kernel test robot [this message]
2021-06-20 19:50 ` drivers/staging/rtl8723bs/core/rtw_security.c:95:9: warning: variable 'crc' set but not used Jhih Ming Huang
2021-06-21  0:18   ` Rong Chen
2021-06-21  6:25     ` Jhih-Ming Huang
2021-06-21 13:55 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202106191804.43B29pt1-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.