From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Harald Mommer <hmo@opensynergy.com>, linux-can@vger.kernel.org
Subject: Re: MSG_CONFIRM RX messages with SocketCAN known as unreliable under heavy load?
Date: Sat, 19 Jun 2021 23:42:28 +0200 [thread overview]
Message-ID: <20210619214228.7ojjr7fa77uzmv7g@pengutronix.de> (raw)
In-Reply-To: <4dad20db-b9be-24c8-d97b-7cc614a7c7c9@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
On 18.06.2021 20:23:39, Oliver Hartkopp wrote:
> > Even if the Linux Kernel doesn't drop any messages, not all CAN
> > controllers support that feature. On the Linux side we try our best, but
> > some USB attached devices don't report a TX complete event back, so the
> > driver triggers the CAN echo skb after the USB transfer has been
> > completed.
> >
> > We don't have a feature flag to query if the Linux driver support proper
> > CAN echo on TX complete notification.
>
> We have. It is set in struct netdevice.flags and called IFF_ECHO.
>
> https://elixir.bootlin.com/linux/v5.12.11/source/net/can/af_can.c#L257
The flag tells the rest of the stack, that the driver takes care of
generating the CAN echo packages.
Several USB based driver set the IFF_ECHO flag, but the USB device don't
signal the TX-complete to the host. These drivers generate the CAN echo
frame after the successful USB TX transmission. This is better than
letting the networking stack generate the CAN echo frame, but it's not
100% perfect.
> E.g. the slcan driver does not have this bit set.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-19 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:22 MSG_CONFIRM RX messages with SocketCAN known as unreliable under heavy load? Harald Mommer
2021-06-18 9:16 ` Marc Kleine-Budde
2021-06-18 18:23 ` Oliver Hartkopp
2021-06-19 21:42 ` Marc Kleine-Budde [this message]
2021-06-24 15:21 ` Harald Mommer
2021-06-24 18:45 ` Oliver Hartkopp
2021-06-28 13:47 ` Harald Mommer
2021-06-25 9:19 ` review of virtio-can (was: Re: MSG_CONFIRM RX messages with SocketCAN known as unreliable under heavy load?) Marc Kleine-Budde
2021-06-25 9:19 ` [virtio-dev] " Marc Kleine-Budde
2021-06-29 17:14 ` Harald Mommer
2021-06-29 17:14 ` [virtio-dev] " Harald Mommer
2021-07-14 7:15 ` [virtio-dev] " Michael S. Tsirkin
2021-07-14 7:15 ` Michael S. Tsirkin
2021-07-15 16:04 ` Harald Mommer
2021-07-15 16:04 ` Harald Mommer
2021-06-25 9:39 ` MSG_CONFIRM RX messages with SocketCAN known as unreliable under heavy load? Marc Kleine-Budde
2021-06-29 19:39 Harald Mommer
2021-06-30 7:27 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619214228.7ojjr7fa77uzmv7g@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=hmo@opensynergy.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.