[PATCH] drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN

[PATCH] drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN

[Marek Vasut]

The iMX8MM and iMX8MN do not support the overlay plane, so they
are MXSFB V4. Add the compatible strings to reflect this. Note
that iMX8MQ does support the overlay plane, so it is MXSFB V6.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Abrecht <public@danielabrecht.ch>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Stefan Agner <stefan@agner.ch>
---
 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index c277d3f61a5e..0ae4a3553304 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -308,6 +308,8 @@ static const struct of_device_id mxsfb_dt_ids[] = {
 	{ .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], },
 	{ .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
 	{ .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
+	{ .compatible = "fsl,imx8mm-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
+	{ .compatible = "fsl,imx8mn-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);
-- 
2.30.2

Re: [PATCH] drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN

[Lucas Stach]

Am Montag, dem 21.06.2021 um 00:48 +0200 schrieb Marek Vasut:
> The iMX8MM and iMX8MN do not support the overlay plane, so they
> are MXSFB V4. Add the compatible strings to reflect this. Note
> that iMX8MQ does support the overlay plane, so it is MXSFB V6.

Do we need this compatible in the driver? If there are no other changes
known at this time, shouldn't we be able to just specify "fsl,imx28-
lcdif" as the fallback compatible in the DT, besides the imx8m*
specific ones?

Regards,
Lucas

> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Daniel Abrecht <public@danielabrecht.ch>
> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Stefan Agner <stefan@agner.ch>
> ---
>  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index c277d3f61a5e..0ae4a3553304 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -308,6 +308,8 @@ static const struct of_device_id mxsfb_dt_ids[] = {
>  	{ .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], },
>  	{ .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
>  	{ .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], },
> +	{ .compatible = "fsl,imx8mm-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
> +	{ .compatible = "fsl,imx8mn-lcdif", .data = &mxsfb_devdata[MXSFB_V4], },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);

Re: [PATCH] drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN

[Marek Vasut]

On 6/21/21 2:10 PM, Lucas Stach wrote:
> Am Montag, dem 21.06.2021 um 00:48 +0200 schrieb Marek Vasut:
>> The iMX8MM and iMX8MN do not support the overlay plane, so they
>> are MXSFB V4. Add the compatible strings to reflect this. Note
>> that iMX8MQ does support the overlay plane, so it is MXSFB V6.
> 
> Do we need this compatible in the driver? If there are no other changes
> known at this time, shouldn't we be able to just specify "fsl,imx28-
> lcdif" as the fallback compatible in the DT, besides the imx8m*
> specific ones?

Yes, we should discard this patch and use the fallback compatible, 
although it is quite counter-intuitive.