All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org
Subject: [PATCH 18/26] target/riscv: Use translator_use_goto_tb
Date: Sun, 20 Jun 2021 18:34:31 -0700	[thread overview]
Message-ID: <20210621013439.1791385-19-richard.henderson@linaro.org> (raw)
In-Reply-To: <20210621013439.1791385-1-richard.henderson@linaro.org>

Just use translator_use_goto_tb directly at the one call site,
rather than maintaining a local wrapper.

Cc: qemu-riscv@nongnu.org
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/riscv/translate.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index c6e8739614..ecd3764338 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -168,29 +168,11 @@ static void gen_exception_inst_addr_mis(DisasContext *ctx)
     generate_exception_mtval(ctx, RISCV_EXCP_INST_ADDR_MIS);
 }
 
-static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest)
-{
-    if (unlikely(ctx->base.singlestep_enabled)) {
-        return false;
-    }
-
-#ifndef CONFIG_USER_ONLY
-    return (ctx->base.tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK);
-#else
-    return true;
-#endif
-}
-
 static void gen_goto_tb(DisasContext *ctx, int n, target_ulong dest)
 {
-    if (use_goto_tb(ctx, dest)) {
-        /* chaining is only allowed when the jump is to the same page */
+    if (translator_use_goto_tb(&ctx->base, dest)) {
         tcg_gen_goto_tb(n);
         tcg_gen_movi_tl(cpu_pc, dest);
-
-        /* No need to check for single stepping here as use_goto_tb() will
-         * return false in case of single stepping.
-         */
         tcg_gen_exit_tb(ctx->base.tb, n);
     } else {
         tcg_gen_movi_tl(cpu_pc, dest);
-- 
2.25.1



  parent reply	other threads:[~2021-06-21  1:48 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21  1:34 [PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 01/26] " Richard Henderson
2021-06-21  6:24   ` Max Filippov
2021-06-21 12:50   ` Philippe Mathieu-Daudé
2021-06-21 13:47     ` Richard Henderson
2021-06-21 15:03       ` Philippe Mathieu-Daudé
2021-06-21 13:45   ` Luis Fernando Fujita Pires
2021-06-21  1:34 ` [PATCH 02/26] target/alpha: Remove use_exit_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 03/26] target/alpha: Remove in_superpage Richard Henderson
2021-06-21  1:34 ` [PATCH 04/26] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 05/26] target/arm: " Richard Henderson
2021-06-21 10:20   ` Peter Maydell
2021-06-21  1:34 ` [PATCH 06/26] target/avr: " Richard Henderson
2021-06-21  1:34 ` [PATCH 07/26] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-21  5:39   ` Michael Rolnik
2021-06-21 12:31   ` Philippe Mathieu-Daudé
2021-06-21  1:34 ` [PATCH 08/26] target/cris: Use translator_use_goto_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 09/26] target/hppa: " Richard Henderson
2021-06-21  1:34 ` [PATCH 10/26] target/i386: " Richard Henderson
2021-06-21  1:34 ` [PATCH 11/26] target/m68k: " Richard Henderson
2021-06-21  7:35   ` Laurent Vivier
2021-06-21  1:34 ` [PATCH 12/26] target/microblaze: " Richard Henderson
2021-06-21  1:34 ` [PATCH 13/26] target/mips: " Richard Henderson
2021-06-21  1:34 ` [PATCH 14/26] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-21 12:25   ` Philippe Mathieu-Daudé
2021-06-21  1:34 ` [PATCH 15/26] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 16/26] target/openrisc: " Richard Henderson
2021-06-21  1:34 ` [PATCH 17/26] target/ppc: " Richard Henderson
2021-06-21 13:45   ` Luis Fernando Fujita Pires
2021-06-21  1:34 ` Richard Henderson [this message]
2021-06-21 22:22   ` [PATCH 18/26] target/riscv: " Alistair Francis
2021-06-21 22:22     ` Alistair Francis
2021-06-21  1:34 ` [PATCH 19/26] target/rx: " Richard Henderson
2021-06-21  1:34 ` [PATCH 20/26] target/s390x: " Richard Henderson
2021-06-21  1:34 ` [PATCH 21/26] target/s390x: Remove use_exit_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 22/26] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-06-21  1:34 ` [PATCH 23/26] target/sparc: " Richard Henderson
2021-06-21  9:09   ` Mark Cave-Ayland
2021-06-21  1:34 ` [PATCH 24/26] target/tricore: " Richard Henderson
2021-06-21 14:27   ` Bastian Koppelmann
2021-06-21  1:34 ` [PATCH 25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-21 14:32   ` Bastian Koppelmann
2021-06-21  1:34 ` [PATCH 26/26] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-06-21  6:24   ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621013439.1791385-19-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.