From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8206616846683950889==" MIME-Version: 1.0 From: Jhih-Ming Huang To: kbuild-all@lists.01.org Subject: Re: drivers/staging/rtl8723bs/core/rtw_security.c:95:9: warning: variable 'crc' set but not used Date: Mon, 21 Jun 2021 14:25:19 +0800 Message-ID: <20210621062519.z4rmsjavobfu54ox@gmail.com> In-Reply-To: <0db2ba53-2898-c56e-7af8-dc042636b057@intel.com> List-Id: --===============8206616846683950889== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2021 at 08:18:46AM +0800, Rong Chen wrote: > = > = > On 6/21/21 3:50 AM, Jhih Ming Huang wrote: > > On Sat, Jun 19, 2021 at 6:27 PM kernel test robot wro= te: > > > tree: https://github.com/0day-ci/linux/commits/UPDATE-20210619-1553= 50/Jhih-Ming-Huang/rtw_security-fix-cast-to-restricted-__le32/20210616-1310= 56 > > > head: ed0359e3fa64928e48021387a694f211bc840ff7 > > > commit: ed0359e3fa64928e48021387a694f211bc840ff7 rtw_security: fix ca= st to restricted __le32 > > > date: 3 hours ago > > > config: sh-allmodconfig (attached as .config) > > > compiler: sh4-linux-gcc (GCC) 9.3.0 > > > reproduce (this is a W=3D1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/maste= r/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/ed0359e3fa64928e48= 021387a694f211bc840ff7 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review UPDATE-20210619-155350/Jhih= -Ming-Huang/rtw_security-fix-cast-to-restricted-__le32/20210616-131056 > > > git checkout ed0359e3fa64928e48021387a694f211bc840ff7 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make= .cross ARCH=3Dsh > > > = > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > = > > > All warnings (new ones prefixed by >>): > > > = > > > drivers/staging/rtl8723bs/core/rtw_security.c: In function 'rtw_w= ep_decrypt': > > > > > drivers/staging/rtl8723bs/core/rtw_security.c:95:9: warning: vari= able 'crc' set but not used [-Wunused-but-set-variable] > > > 95 | __le32 crc; > > > | ^~~ > > > = > > > Kconfig warnings: (for reference only) > > > WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC > > > Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HA= S_DMA > > > Selected by > > > - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATM= EL_SOC > > > - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND= _ATMEL_SOC && ATMEL_SSC > > > = > > > = > > > vim +/crc +95 drivers/staging/rtl8723bs/core/rtw_security.c > > > = > > > 91 > > > 92 void rtw_wep_decrypt(struct adapter *padapter, u8 *precvfra= me) > > > 93 { > > > 94 /* exclude ICV */ > > > > 95 __le32 crc; > > > 96 signed int length; > > > 97 u32 keylength; > > > 98 u8 *pframe, *payload, *iv, wepkey[16]; > > > 99 u8 keyindex; > > > 100 struct rx_pkt_attrib *prxattrib =3D &(((union re= cv_frame *)precvframe)->u.hdr.attrib); > > > 101 struct security_priv *psecuritypriv =3D &padapter->= securitypriv; > > > 102 struct arc4_ctx *ctx =3D &psecuritypriv->recv_arc4_c= tx; > > > 103 > > > 104 pframe =3D (unsigned char *)((union recv_frame *)pre= cvframe)->u.hdr.rx_data; > > > 105 > > > 106 /* start to decrypt recvframe */ > > > 107 if ((prxattrib->encrypt =3D=3D _WEP40_) || (prxattri= b->encrypt =3D=3D _WEP104_)) { > > > 108 iv =3D pframe+prxattrib->hdrlen; > > > 109 /* keyindex =3D(iv[3]&0x3); */ > > > 110 keyindex =3D prxattrib->key_index; > > > 111 keylength =3D psecuritypriv->dot11DefKeylen[= keyindex]; > > > 112 memcpy(&wepkey[0], iv, 3); > > > 113 /* memcpy(&wepkey[3], &psecuritypriv->dot11D= efKey[psecuritypriv->dot11PrivacyKeyIndex].skey[0], keylength); */ > > > 114 memcpy(&wepkey[3], &psecuritypriv->dot11DefK= ey[keyindex].skey[0], keylength); > > > 115 length =3D ((union recv_frame *)precvframe)-= >u.hdr.len-prxattrib->hdrlen-prxattrib->iv_len; > > > 116 > > > 117 payload =3D pframe+prxattrib->iv_len+prxattr= ib->hdrlen; > > > 118 > > > 119 /* decrypt payload include icv */ > > > 120 arc4_setkey(ctx, wepkey, 3 + keylength); > > > 121 arc4_crypt(ctx, payload, payload, length); > > > 122 > > > 123 /* calculate icv and compare the icv */ > > > 124 crc =3D cpu_to_le32(~crc32_le(~0, payload, l= ength - 4)); > > > 125 > > > 126 } > > > 127 } > > > 128 > > > = > > > --- > > > 0-DAY CI Kernel Test Service, Intel Corporation > > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > > This warning was introduced by my pull request, > > but I am fixing the sparse warning and the unused variable was > > declared in the previous commit. > > The original author did not compare the crc and payload in > > rtw_wep_decrypt, so the variable 'crc' was set but not used. > > = > > Should I fix this in my pull request? > > BTW, in the following message, it mentioned *If you fix the issue, > > kindly add following tag as appropriate*, > > What's the meaning of the _tag_? > = > Hi jmhuang, > = > It means you can add 'Reported-by' tag in a fix commit, but > you can ignore it if you fix it in the original patch. > = > Best Regards, > Rong Chen > = Hi Rong, Got it. Thanks for your explanation. = --jmhuang > > = > > thanks. > > = > > --jmhuang > > _______________________________________________ > > kbuild-all mailing list -- kbuild-all(a)lists.01.org > > To unsubscribe send an email to kbuild-all-leave(a)lists.01.org >=20 --===============8206616846683950889==--