From: Christoph Hellwig <hch@lst.de>
To: viro@zeniv.linux.org.uk
Cc: Vivek Goyal <vgoyal@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
virtio-fs@redhat.com
Subject: [PATCH 1/2] init: split get_fs_names
Date: Mon, 21 Jun 2021 08:26:56 +0200 [thread overview]
Message-ID: <20210621062657.3641879-2-hch@lst.de> (raw)
In-Reply-To: <20210621062657.3641879-1-hch@lst.de>
Split get_fs_names into one function that splits up the command line
argument, and one that gets the list of all registered file systems.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
init/do_mounts.c | 48 ++++++++++++++++++++++++++----------------------
1 file changed, 26 insertions(+), 22 deletions(-)
diff --git a/init/do_mounts.c b/init/do_mounts.c
index 74aede860de7..ec32de3ad52b 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -338,30 +338,31 @@ __setup("rootflags=", root_data_setup);
__setup("rootfstype=", fs_names_setup);
__setup("rootdelay=", root_delay_setup);
-static void __init get_fs_names(char *page)
+static void __init split_fs_names(char *page, char *names)
{
- char *s = page;
-
- if (root_fs_names) {
- strcpy(page, root_fs_names);
- while (*s++) {
- if (s[-1] == ',')
- s[-1] = '\0';
- }
- } else {
- int len = get_filesystem_list(page);
- char *p, *next;
+ strcpy(page, root_fs_names);
+ while (*page++) {
+ if (page[-1] == ',')
+ page[-1] = '\0';
+ }
+ *page = '\0';
+}
- page[len] = '\0';
- for (p = page-1; p; p = next) {
- next = strchr(++p, '\n');
- if (*p++ != '\t')
- continue;
- while ((*s++ = *p++) != '\n')
- ;
- s[-1] = '\0';
- }
+static void __init get_all_fs_names(char *page)
+{
+ int len = get_filesystem_list(page);
+ char *s = page, *p, *next;
+
+ page[len] = '\0';
+ for (p = page - 1; p; p = next) {
+ next = strchr(++p, '\n');
+ if (*p++ != '\t')
+ continue;
+ while ((*s++ = *p++) != '\n')
+ ;
+ s[-1] = '\0';
}
+
*s = '\0';
}
@@ -411,7 +412,10 @@ void __init mount_block_root(char *name, int flags)
scnprintf(b, BDEVNAME_SIZE, "unknown-block(%u,%u)",
MAJOR(ROOT_DEV), MINOR(ROOT_DEV));
- get_fs_names(fs_names);
+ if (root_fs_names)
+ split_fs_names(fs_names, root_fs_names);
+ else
+ get_all_fs_names(fs_names);
retry:
for (p = fs_names; *p; p += strlen(p)+1) {
int err = do_mount_root(name, p, flags, root_mount_data);
--
2.30.2
next prev parent reply other threads:[~2021-06-21 6:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 6:26 support booting of arbitrary non-blockdevice file systems v2 Christoph Hellwig
2021-06-21 6:26 ` Christoph Hellwig [this message]
2021-06-21 14:46 ` [PATCH 1/2] init: split get_fs_names Al Viro
2021-06-21 14:51 ` Al Viro
2021-06-21 14:53 ` Christoph Hellwig
2021-06-21 14:59 ` Al Viro
2021-06-21 15:09 ` Matthew Wilcox
2021-06-21 15:22 ` Christoph Hellwig
2021-06-21 6:26 ` [PATCH 2/2] init: allow mounting arbitrary non-blockdevice filesystems as root Christoph Hellwig
2021-06-21 13:31 ` [Virtio-fs] support booting of arbitrary non-blockdevice file systems v2 Stefan Hajnoczi
2021-06-21 14:35 ` Vivek Goyal
2021-06-22 8:12 ` [PATCH 3/2] fs: simplify get_filesystem_list / get_all_fs_names Christoph Hellwig
2021-06-22 8:36 ` [Virtio-fs] " Stefan Hajnoczi
2021-06-29 20:50 ` Vivek Goyal
2021-06-30 5:36 ` Christoph Hellwig
2021-06-30 17:33 ` Vivek Goyal
2021-07-07 21:04 ` Vivek Goyal
2021-07-07 21:06 ` Vivek Goyal
2021-07-08 12:59 ` Vivek Goyal
2021-07-12 18:21 ` Vivek Goyal
2021-07-13 5:40 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-06-17 15:36 support booting of arbitrary non-blockdevice file systems Christoph Hellwig
2021-06-17 15:36 ` [PATCH 1/2] init: split get_fs_names Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621062657.3641879-2-hch@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.