From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF25C49EA2 for ; Mon, 21 Jun 2021 06:59:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A0F761042 for ; Mon, 21 Jun 2021 06:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbhFUHBV (ORCPT ); Mon, 21 Jun 2021 03:01:21 -0400 Received: from verein.lst.de ([213.95.11.211]:40759 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhFUHBU (ORCPT ); Mon, 21 Jun 2021 03:01:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4AC9068BEB; Mon, 21 Jun 2021 08:59:04 +0200 (CEST) Date: Mon, 21 Jun 2021 08:59:04 +0200 From: Christoph Hellwig To: Marek Szyprowski Cc: Christoph Hellwig , Ulf Hansson , linux-mmc@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 2/2] mmc: switch to blk_mq_alloc_disk Message-ID: <20210621065904.GA6198@lst.de> References: <20210616053934.880951-1-hch@lst.de> <20210616053934.880951-3-hch@lst.de> <1c5b5018-f7ca-609b-b607-827cedc161e6@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c5b5018-f7ca-609b-b607-827cedc161e6@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jun 21, 2021 at 08:22:07AM +0200, Marek Szyprowski wrote: > Hi > > On 16.06.2021 07:39, Christoph Hellwig wrote: > > Use the blk_mq_alloc_disk to allocate the request_queue and gendisk > > together. > > > > Signed-off-by: Christoph Hellwig > > This patch landed recently in linux-next as commit 281ea6a5bfdc ("mmc: > switch to blk_mq_alloc_disk"). It triggers the following warning during > boot on all my systems with MMC devices: Please try this, I lost this hunk in the final cleanup, sorry: diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index e7f89cbf9232..9890a1532cb0 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -2331,6 +2331,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card, md->queue.blkdata = md; md->disk->major = MMC_BLOCK_MAJOR; + md->disk->minors = perdev_minors; md->disk->first_minor = devidx * perdev_minors; md->disk->fops = &mmc_bdops; md->disk->private_data = md;