From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E41C48BE5 for ; Mon, 21 Jun 2021 08:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC7CC611BD for ; Mon, 21 Jun 2021 08:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbhFUIu2 (ORCPT ); Mon, 21 Jun 2021 04:50:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:38956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhFUIu0 (ORCPT ); Mon, 21 Jun 2021 04:50:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 399FA60C3D; Mon, 21 Jun 2021 08:48:10 +0000 (UTC) Date: Mon, 21 Jun 2021 09:48:07 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Andrew Jones Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210621084806.GA11552@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> <20210618145241.GG16116@arm.com> <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 09:18:31AM +0100, Steven Price wrote: > On 18/06/2021 15:52, Catalin Marinas wrote: > > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > >> +When this capability is enabled all memory in (non-device) memslots must not > >> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > >> +in an -EINVAL return. > > > > "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as > > that's a kernel internal and not something the VMM needs to be aware of. > > Just say something like "memslots must be mapped as shareable > > (MAP_SHARED)". > > I think I meant "must not use" - and indeed memslots must *not* be > mapped as shareable. I'll update to this wording: > > When this capability is enabled all memory in memslots must be mapped as > not-shareable (no MAP_SHARED), attempts to create a memslot with MAP_SHARED > will result in an -EINVAL return. It looks fine. Feel free to keep my reviewed-by. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBF8C48BE5 for ; Mon, 21 Jun 2021 08:49:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D100461164 for ; Mon, 21 Jun 2021 08:49:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D100461164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvFcH-0001QS-UD for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 04:49:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvFbP-0000k3-UB for qemu-devel@nongnu.org; Mon, 21 Jun 2021 04:48:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:55884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvFbL-0003Ec-U6 for qemu-devel@nongnu.org; Mon, 21 Jun 2021 04:48:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 399FA60C3D; Mon, 21 Jun 2021 08:48:10 +0000 (UTC) Date: Mon, 21 Jun 2021 09:48:07 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210621084806.GA11552@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> <20210618145241.GG16116@arm.com> <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 21, 2021 at 09:18:31AM +0100, Steven Price wrote: > On 18/06/2021 15:52, Catalin Marinas wrote: > > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > >> +When this capability is enabled all memory in (non-device) memslots must not > >> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > >> +in an -EINVAL return. > > > > "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as > > that's a kernel internal and not something the VMM needs to be aware of. > > Just say something like "memslots must be mapped as shareable > > (MAP_SHARED)". > > I think I meant "must not use" - and indeed memslots must *not* be > mapped as shareable. I'll update to this wording: > > When this capability is enabled all memory in memslots must be mapped as > not-shareable (no MAP_SHARED), attempts to create a memslot with MAP_SHARED > will result in an -EINVAL return. It looks fine. Feel free to keep my reviewed-by. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67C4C48BE5 for ; Mon, 21 Jun 2021 08:48:19 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 12D67611B0 for ; Mon, 21 Jun 2021 08:48:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12D67611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8D59E4024F; Mon, 21 Jun 2021 04:48:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QWb7VBQgs4YM; Mon, 21 Jun 2021 04:48:17 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4A67940629; Mon, 21 Jun 2021 04:48:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EACD54029F for ; Mon, 21 Jun 2021 04:48:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YG45XfqoQOxC for ; Mon, 21 Jun 2021 04:48:14 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1193D4024F for ; Mon, 21 Jun 2021 04:48:13 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 399FA60C3D; Mon, 21 Jun 2021 08:48:10 +0000 (UTC) Date: Mon, 21 Jun 2021 09:48:07 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210621084806.GA11552@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> <20210618145241.GG16116@arm.com> <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jun 21, 2021 at 09:18:31AM +0100, Steven Price wrote: > On 18/06/2021 15:52, Catalin Marinas wrote: > > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > >> +When this capability is enabled all memory in (non-device) memslots must not > >> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > >> +in an -EINVAL return. > > > > "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as > > that's a kernel internal and not something the VMM needs to be aware of. > > Just say something like "memslots must be mapped as shareable > > (MAP_SHARED)". > > I think I meant "must not use" - and indeed memslots must *not* be > mapped as shareable. I'll update to this wording: > > When this capability is enabled all memory in memslots must be mapped as > not-shareable (no MAP_SHARED), attempts to create a memslot with MAP_SHARED > will result in an -EINVAL return. It looks fine. Feel free to keep my reviewed-by. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC3DC48BE5 for ; Mon, 21 Jun 2021 08:49:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15D2860FDA for ; Mon, 21 Jun 2021 08:49:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15D2860FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rbZFNJMU5TFvVbFpQwBRmO40mZO/h8cXCTnU4Zh1FF8=; b=eJ6KbDwRCNiPu3 WLZ5Zoj4Uzjc1PlGc04Wdj6wrASgPUJ9cPVIrEBggsD4US5io1aOexhumaiCc7uUpSjsM+kC0wovG rcL/whZVAsNRsrKVNwIf5IKx6oGzRiHJ9w62CANHIBN+j8r4E4TSSuq7nCjlmVfdQ2RIH+SMLUB/R W0/uP0uyCkR/2VBHm8/l8X0litLN7JQu5ae3VCYz4IZW4uH/3cByj0W2rEUxnd1PD3IO0jZnYAJ3V UU5TVr0WrIgDRrQDBaZIUJaoQoI/wOyhY446WLfMc5bfYUKkzoE47y1skpa5QUshtuEhcPiPUFM1b zddPxzESua2PWEwD/Xjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvFbM-002l3E-DJ; Mon, 21 Jun 2021 08:48:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvFbJ-002l2s-IZ for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 08:48:14 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 399FA60C3D; Mon, 21 Jun 2021 08:48:10 +0000 (UTC) Date: Mon, 21 Jun 2021 09:48:07 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Andrew Jones Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210621084806.GA11552@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> <20210618145241.GG16116@arm.com> <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1273c642-d2b0-b81d-2052-1f2f0deafdae@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_014813_667779_63F7491F X-CRM114-Status: GOOD ( 13.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 21, 2021 at 09:18:31AM +0100, Steven Price wrote: > On 18/06/2021 15:52, Catalin Marinas wrote: > > On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > >> +When this capability is enabled all memory in (non-device) memslots must not > >> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > >> +in an -EINVAL return. > > > > "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as > > that's a kernel internal and not something the VMM needs to be aware of. > > Just say something like "memslots must be mapped as shareable > > (MAP_SHARED)". > > I think I meant "must not use" - and indeed memslots must *not* be > mapped as shareable. I'll update to this wording: > > When this capability is enabled all memory in memslots must be mapped as > not-shareable (no MAP_SHARED), attempts to create a memslot with MAP_SHARED > will result in an -EINVAL return. It looks fine. Feel free to keep my reviewed-by. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel