All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	David Brazdil <dbrazdil@google.com>,
	Marc Zyngier <maz@kernel.org>,
	Mikhail Petrov <Mikhail.Petrov@mir.dev>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marty Faltesek <mfaltesek@google.com>
Subject: Re: [PATCH] kallsyms: fix nonconverging kallsyms table with lld
Date: Mon, 21 Jun 2021 04:47:52 -0700	[thread overview]
Message-ID: <20210621114752.GA116119@roeck-us.net> (raw)
In-Reply-To: <CAK8P3a2LTXme3pa-es=7s7aHX2EvC+2Dxegs=reuJrjeS4sygg@mail.gmail.com>

On Thu, Jun 10, 2021 at 02:26:50PM +0200, Arnd Bergmann wrote:
> On Thu, Jun 10, 2021 at 2:05 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > On Wed, Jun 09, 2021 at 10:30:23PM +0200, Arnd Bergmann wrote:
> > > > I thought I'd see the added symbols, but it looks like the only difference
> > > > between the two files is the addresses.
> > > >
> > > > What am I missing ?
> > >
> > > I probably misremembered the part about 'objdump --syms' and there was
> > > something more to it.
> > >
> > > Maybe this was the last version before converging? It looks like the '<' version
> > > has one extra symbol ompared to the '>' version. The diff has no context, but I
> >
> > It is the difference between step 1 and 2. Why would diff on objdump not
> > show the additional symbol ? Is it possible that the symbol is not added
> > to the object file ?
> 
> Note sure. The symbol must be in the object file, but perhaps the
> 'objdump --syms' output skips a different set of symbols compared
> to the list that is used as input for kallsyms, which comes from '${NM}'.
> 
> Comparing the nm output might be another thing to try.
> 
Just following up on this: As Murphy would have told us, the problem
disappeared while trying to track it down. We'll add some instrumentation
into the ChromeOS kernel build to get data once/if/when it shows up again.
When that happens, we'll try to come up with a patch to show the symbol
file differences in the kernel build and submit it upstream.

Thanks,
Guenter

      reply	other threads:[~2021-06-21 11:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 15:29 [PATCH] kallsyms: fix nonconverging kallsyms table with lld Arnd Bergmann
2021-02-05  8:41 ` Masahiro Yamada
2021-06-09 11:05 ` Guenter Roeck
2021-06-09 11:24   ` Arnd Bergmann
2021-06-09 15:16     ` Guenter Roeck
2021-06-09 15:23       ` Arnd Bergmann
2021-06-09 19:15       ` Guenter Roeck
2021-06-09 20:30         ` Arnd Bergmann
2021-06-10 12:05           ` Guenter Roeck
2021-06-10 12:26             ` Arnd Bergmann
2021-06-21 11:47               ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621114752.GA116119@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Mikhail.Petrov@mir.dev \
    --cc=arnd@kernel.org \
    --cc=dbrazdil@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=maz@kernel.org \
    --cc=mfaltesek@google.com \
    --cc=michal.lkml@markovi.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.