From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9164071 for ; Mon, 21 Jun 2021 14:22:37 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id w31so14301136pga.6 for ; Mon, 21 Jun 2021 07:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8L+cd+ZQnTliBnbuqbahlYKMU/bFlGdaEWT+XDryuZI=; b=dDIxGFZonS5d2guwsqbUn2ZNdVnahSjKxnJNiJ2rDNoD8zO8Jk0pUBBIAWfU3PkRPH KuFeaDX33DXkPKL/5wJCUaMyaYDyC+RDoYasJymcxt68eNG69MeQei7wGMSk9S8FYP0k VMyIVd1WlDqNOTkQZDQVqlUuXCqEXCUZEIDkH+u/JJKbuvJQqKCZ1Yr60pm7+gT6Ra9L fNj24dLytBMmOz0TRnxMuIsGRkG59I3GALaGaxtF0Vmhk1KhcWXcxTNMjJdOAvK3nlIU Je8nYmTxMYaiOxR+Xw6+myXxmoyuoXDSJ4vcpacn6Dw9jJg/QrLiOKyAD5ygpjr+XHYM 1Aww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8L+cd+ZQnTliBnbuqbahlYKMU/bFlGdaEWT+XDryuZI=; b=jaPpLCig+SaZWmzfsQoYJlK96u7Hg/bEu9/jq7fSF12RIliJ6kOgEw441SLjiiMMjM Ph6gGOI6JsEEL7Nk3YrQukQaEp145Cgs7NTe9Z8oIj28gkTNNjK2oQzV2wpadvyZ0GuS 4GYLC/wlVY88ej+lzNznBVE3C1KCHRsCf4YT8Wjeo6jO8mq3KPDxgdGbFwKfo3SgZXli /AbLaKaPaG/qWTvZ8RFIpodBB9mhiyr0hUAw7fpPCO3fSD93VNOTdcT1CH5++7UiPa4F dBDkfzkh0a0zAahbx9A7Iz3PsQgUSRfPOyG6evpgoweq+mNsez4+65DAS/ZK/IWJviit J0cQ== X-Gm-Message-State: AOAM532UQPmLHF88Jqh9NTEn1cLortD7WMAyVCgwOAP0cguCFlCgaLSC 2bw1zZd2OvqILmCi/tx7HoU= X-Google-Smtp-Source: ABdhPJzZ6AmPiFqoTJcZ4tUQRgeJ1RJjJAfN/W5xkONC67cFCSfCwrZunMX6TFVg9VAcgVbj4ZSUEQ== X-Received: by 2002:a63:185b:: with SMTP id 27mr24580741pgy.164.1624285357096; Mon, 21 Jun 2021 07:22:37 -0700 (PDT) Received: from ojas ([122.177.154.120]) by smtp.gmail.com with ESMTPSA id v4sm17119750pgr.65.2021.06.21.07.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:22:36 -0700 (PDT) Date: Mon, 21 Jun 2021 19:52:26 +0530 From: Ojaswin Mujoo To: Dan Carpenter Cc: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com, arnd@arndb.de, phil@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] staging: vchiq: Refactor vchiq cdev code Message-ID: <20210621142226.GA186979@ojas> References: <20210621082132.GC1901@kadam> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621082132.GC1901@kadam> Hello Dan, On Mon, Jun 21, 2021 at 11:21:32AM +0300, Dan Carpenter wrote: > On Sun, Jun 20, 2021 at 06:25:46PM +0530, Ojaswin Mujoo wrote: > > vchiq_debugfs_init(); > > > > vchiq_log_info(vchiq_arm_log_level, > > - "vchiq: initialised - version %d (min %d), device %d.%d", > > - VCHIQ_VERSION, VCHIQ_VERSION_MIN, > > - MAJOR(vchiq_devid), MINOR(vchiq_devid)); > > + "vchiq: platform initialised - version %d (min %d)", > > + VCHIQ_VERSION, VCHIQ_VERSION_MIN); > > + > > + /* > > + * We don't handle error here since the function handles > > + * cleanup in cases of failure. Further, we can proceed > > + * even if this function fails. > > + */ > > + vchiq_register_chrdev(&pdev->dev); > > I feel like ignoring errors and just continuing seems helpful, but it's > actually doing the users a disservice. If it's an error during, boot > that's different, in that case it's better to get some kind of minimally > useful boot so the user can debug the problem. But if the error isn't > going to prevent the system from booting then it's better to just return > an error so they can fix the problem and try again. Got it, I'll fix this in the next revision. Thank you, Ojaswin > > regards, > dan carpenter > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B05E4C48BE5 for ; Mon, 21 Jun 2021 14:24:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E9386112D for ; Mon, 21 Jun 2021 14:24:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E9386112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MxlFLkQcsxoOGtM8Xq3TCqVNrVu7JE0qcoKTDkT5Ub8=; b=5DxcPGcGBsIHJ3 /qDJwgcwi7V9IXbfRI2Xnm4YS/86rJVH97DUqMgSlsncGisnk+FNqenKBVh+Frik9gP56MDMRrT3u jS7fWivvVRtDWSQL3g5+fCp8f2dfQ9LgB1LGB0OzJw+KzZqt83sAonX6JYMTJK1ZuDHfdp825PEIQ 3Bxvvh+rlVn9N/naIzQbsIVBcTa3dZjrUftDw82E9oV61C0EhEdVLLNAcEWKVdo++X5uKTZeXvCLM SMy4EQNhh+s2OCBi0+9GfS4D1xM42TFji2LwrQMXXK0a8BsTjmIA4SunhEm+3GREc4yzD312JuTBN d3KBJLkNEcuD7A97ijBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvKp0-003jwL-14; Mon, 21 Jun 2021 14:22:42 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvKov-003jur-QS for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 14:22:39 +0000 Received: by mail-pg1-x535.google.com with SMTP id e33so14296485pgm.3 for ; Mon, 21 Jun 2021 07:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8L+cd+ZQnTliBnbuqbahlYKMU/bFlGdaEWT+XDryuZI=; b=dDIxGFZonS5d2guwsqbUn2ZNdVnahSjKxnJNiJ2rDNoD8zO8Jk0pUBBIAWfU3PkRPH KuFeaDX33DXkPKL/5wJCUaMyaYDyC+RDoYasJymcxt68eNG69MeQei7wGMSk9S8FYP0k VMyIVd1WlDqNOTkQZDQVqlUuXCqEXCUZEIDkH+u/JJKbuvJQqKCZ1Yr60pm7+gT6Ra9L fNj24dLytBMmOz0TRnxMuIsGRkG59I3GALaGaxtF0Vmhk1KhcWXcxTNMjJdOAvK3nlIU Je8nYmTxMYaiOxR+Xw6+myXxmoyuoXDSJ4vcpacn6Dw9jJg/QrLiOKyAD5ygpjr+XHYM 1Aww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8L+cd+ZQnTliBnbuqbahlYKMU/bFlGdaEWT+XDryuZI=; b=hlWshVH1vjgLOBUoJG5syZ7urojDlzXFprgtynjWLISi3SK3HtvwKfD5WFALDTHt8p TImfoPApwaEDNQAzT4zV2NlxNAiIN9HEOEMDQU4q9pLtM2zPCw7wTAqGy/hKU9bBibl7 flxAbBaSdX4+NghPpXDntr+6jn0L1RBp5sc78ULPLcAOV3VGwU6iN1nLASHiNToyN5Yi EOImfeiW7Uqoe7yC2cVZRt02y+ZwC566baNOKzOa589Caqs1v0hCmLL7uj8MJVVDFrhN usm82UJsWO9OSfOdr0TXTyIusGs7jW3RH7heNM+WLDohQwRdbdp+SZRWIJIAg4sKQix+ jrrQ== X-Gm-Message-State: AOAM531YRJ9nxM7BxqfpCDZXhIJqVuEjW0LnXupkqmRea6jvezA8maTB SVDuqSFw81urRbadPjIJAoQ= X-Google-Smtp-Source: ABdhPJzZ6AmPiFqoTJcZ4tUQRgeJ1RJjJAfN/W5xkONC67cFCSfCwrZunMX6TFVg9VAcgVbj4ZSUEQ== X-Received: by 2002:a63:185b:: with SMTP id 27mr24580741pgy.164.1624285357096; Mon, 21 Jun 2021 07:22:37 -0700 (PDT) Received: from ojas ([122.177.154.120]) by smtp.gmail.com with ESMTPSA id v4sm17119750pgr.65.2021.06.21.07.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 07:22:36 -0700 (PDT) Date: Mon, 21 Jun 2021 19:52:26 +0530 From: Ojaswin Mujoo To: Dan Carpenter Cc: nsaenz@kernel.org, gregkh@linuxfoundation.org, stefan.wahren@i2se.com, arnd@arndb.de, phil@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] staging: vchiq: Refactor vchiq cdev code Message-ID: <20210621142226.GA186979@ojas> References: <20210621082132.GC1901@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210621082132.GC1901@kadam> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_072238_403790_74DEEC3A X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Dan, On Mon, Jun 21, 2021 at 11:21:32AM +0300, Dan Carpenter wrote: > On Sun, Jun 20, 2021 at 06:25:46PM +0530, Ojaswin Mujoo wrote: > > vchiq_debugfs_init(); > > > > vchiq_log_info(vchiq_arm_log_level, > > - "vchiq: initialised - version %d (min %d), device %d.%d", > > - VCHIQ_VERSION, VCHIQ_VERSION_MIN, > > - MAJOR(vchiq_devid), MINOR(vchiq_devid)); > > + "vchiq: platform initialised - version %d (min %d)", > > + VCHIQ_VERSION, VCHIQ_VERSION_MIN); > > + > > + /* > > + * We don't handle error here since the function handles > > + * cleanup in cases of failure. Further, we can proceed > > + * even if this function fails. > > + */ > > + vchiq_register_chrdev(&pdev->dev); > > I feel like ignoring errors and just continuing seems helpful, but it's > actually doing the users a disservice. If it's an error during, boot > that's different, in that case it's better to get some kind of minimally > useful boot so the user can debug the problem. But if the error isn't > going to prevent the system from booting then it's better to just return > an error so they can fix the problem and try again. Got it, I'll fix this in the next revision. Thank you, Ojaswin > > regards, > dan carpenter > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel