From: Mark Yacoub <markyacoub@chromium.org>
To: igt-dev@lists.freedesktop.org
Cc: seanpaul@chromium.org, petri.latvala@intel.com,
Mark Yacoub <markyacoub@google.com>
Subject: [igt-dev] [PATCH v3] tests/kms_vblank: Turn on hardware before testing invalid vblank.
Date: Mon, 21 Jun 2021 18:30:38 +0000 [thread overview]
Message-ID: <20210621183038.1030733-1-markyacoub@chromium.org> (raw)
From: Mark Yacoub <markyacoub@google.com>
[Why]
Before any hardware is on, the vblank is off and its ref counter is in
an initialized state as each driver handles toggling it differently.
Ioctl DRM_IOCTL_WAIT_VBLANK could return 0 such as on i915, or an invalid
integer that doesn't mean much, such as on Zork running Kernel 5.4 due
to the kernel workaround that increments the vblank ref count to prevent
a get from enabling the interrupt.
[How]
For invalid_subtest(), active the CRTCs to turn the hardware on so
DRM_IOCTL_WAIT_VBLANK returns something meaningful.
Changes since v3:
Turn on only 1 output instead of all.
Changes since v2:
1. Updated Signed-off-by.
Changes since v1:
1. Update Commit message
2. Rename variable p to pipe_number
Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
---
tests/kms_vblank.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 93b01eba..19284257 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -475,8 +475,13 @@ static void invalid_subtest(data_t *data, int fd)
{
union drm_wait_vblank vbl;
unsigned long valid_flags;
+ igt_display_t* display = &data->display;
+ igt_output_t* output;
- igt_display_require_output_on_pipe(&data->display, 0);
+ igt_display_require_output_on_pipe(display, 0);
+ igt_require(display->n_outputs);
+ output = &display->outputs[0];
+ prepare_crtc(data, fd, output);
/* First check all is well with a simple query */
memset(&vbl, 0, sizeof(vbl));
@@ -511,6 +516,8 @@ static void invalid_subtest(data_t *data, int fd)
vbl.request.type |= _DRM_VBLANK_SECONDARY;
vbl.request.type |= _DRM_VBLANK_FLAGS_MASK;
igt_assert_eq(wait_vblank(fd, &vbl), -EINVAL);
+
+ cleanup_crtc(data, fd, output);
}
igt_main
--
2.32.0.288.g62a8d224e6-goog
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2021-06-21 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 18:30 Mark Yacoub [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-21 18:28 [igt-dev] [PATCH v3] tests/kms_vblank: Turn on hardware before testing invalid vblank Mark Yacoub
2021-06-17 15:20 Mark Yacoub
2021-06-21 10:55 ` Petri Latvala
2021-06-21 18:54 ` Mark Yacoub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621183038.1030733-1-markyacoub@chromium.org \
--to=markyacoub@chromium.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=markyacoub@google.com \
--cc=petri.latvala@intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.