From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
acme@kernel.org
Subject: Re: [PATCH] kprobes: Print an error if probe is rejected
Date: Mon, 21 Jun 2021 21:54:52 +0900 [thread overview]
Message-ID: <20210621215452.0eea52e14dbe5969b66ae149@kernel.org> (raw)
In-Reply-To: <1624266910.z97eue1i84.naveen@linux.ibm.com>
On Mon, 21 Jun 2021 15:06:24 +0530
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> Hi Masami,
>
> Masami Hiramatsu wrote:
> > Hi Naveen,
> >
> > On Mon, 14 Jun 2021 21:00:52 +0530
> > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> >
> >> Steven Rostedt wrote:
> >> > On Fri, 11 Jun 2021 19:25:38 +0530
> >> > "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> wrote:
> >> >
> >> >> We also have perf_event_open() as an interface to add probes, and I
> >> >> don't think it would be helpful to require all tools to utilize the
> >> >> error log from tracefs for this purpose.
> >> >
> >> > The there should be a perf interface to read the errors. I agree with
> >> > Masami. Let's not have console logs for probe errors.
> >>
> >> Ok, understood.
> >
> > Will you update this?
>
> Not sure if you are asking about error logging with perf_event_open(),
> or about reading error_log from tracefs.
>
> For perf_event_open(), I think we will just need to return the error
> code, and interpret the return value in userspace. I don't think there
> is any other way to pass error log or strings back from the kernel.
Yeah, I think that's good idea.
>
> I will update this series to return the correct return value as
> suggested.
OK, then I will update tracefs to interpret the code and put appropriate
error message on error_log.
Thank you!
>
>
> Thanks,
> Naveen
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-06-21 12:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:56 [PATCH] kprobes: Print an error if probe is rejected Naveen N. Rao
2021-06-10 10:16 ` Masami Hiramatsu
2021-06-10 17:33 ` Steven Rostedt
2021-06-11 1:50 ` Masami Hiramatsu
2021-06-11 13:55 ` Naveen N. Rao
2021-06-11 19:40 ` Steven Rostedt
2021-06-14 15:30 ` Naveen N. Rao
2021-06-18 16:15 ` Masami Hiramatsu
2021-06-21 9:36 ` Naveen N. Rao
2021-06-21 12:54 ` Masami Hiramatsu [this message]
2021-06-12 1:13 ` Masami Hiramatsu
2021-06-14 15:37 ` Naveen N. Rao
2021-06-15 5:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621215452.0eea52e14dbe5969b66ae149@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.