From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/15] package/pkg-generic.mk: Fix .la files overwrite detection
Date: Mon, 21 Jun 2021 22:54:11 +0200 [thread overview]
Message-ID: <20210621225411.1c5280f0@windsurf> (raw)
In-Reply-To: <20210621141130.48654-5-herve.codina@bootlin.com>
On Mon, 21 Jun 2021 16:11:19 +0200
Herve Codina <herve.codina@bootlin.com> wrote:
> During per-package build, original .la files are modified by
> fixup-libtool-files calls.
> But since fixup-libtool-files modifies files using sed --in-place,
> these modification are done using a temporary file and a call to
> rename. Rename breaks the hardlink to the original file and leave the
> temporary file in per-package TARGET dir.
> As the original file is not modified, this is no longer considered as
> an overwrite.
>
> To fix this detection, this patch simply considers the what is done
"the what" -> "that what"
> by fixup-libtool-files is part of the original snapshot used to
> detect overwrites. And so, the original snapshot is taken after
> fixup-libtool-files call.
>
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
With that:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-06-21 20:54 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 14:11 [Buildroot] [PATCH 00/15] Overwritten file detection and fixes, one more step to TLP build Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 01/15] package/pkg-generic.mk: detect files overwritten in TARGET_DIR and HOST_DIR Herve Codina
2021-06-21 21:31 ` Yann E. MORIN
2021-06-22 7:40 ` Herve Codina
2021-06-22 9:30 ` Thomas Petazzoni
2021-06-22 9:57 ` Nicolas Cavallari
2021-06-22 10:24 ` Yann E. MORIN
2021-06-24 14:09 ` Herve Codina
2021-06-24 16:18 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 02/15] package/e2fsprogs: fix fsck overwrite in HOST_DIR Herve Codina
2021-06-21 20:52 ` Thomas Petazzoni
2021-06-22 16:26 ` Herve Codina
2021-06-22 19:40 ` Yann E. MORIN
2021-06-24 14:13 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 03/15] package/pkg-generic.mk: Remove Info documents dir entry Herve Codina
2021-06-21 20:51 ` Thomas Petazzoni
2021-06-22 8:43 ` Herve Codina
2021-06-22 9:34 ` Thomas Petazzoni
2021-06-22 20:18 ` Yann E. MORIN
2021-06-24 15:03 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 04/15] package/pkg-generic.mk: Fix .la files overwrite detection Herve Codina
2021-06-21 20:54 ` Thomas Petazzoni [this message]
2021-06-22 18:01 ` Herve Codina
2021-06-21 21:42 ` Yann E. MORIN
2021-06-22 9:31 ` Herve Codina
2021-06-22 9:56 ` Yann E. MORIN
2021-06-22 10:12 ` Thomas Petazzoni
2021-06-22 10:30 ` Yann E. MORIN
2021-06-24 15:44 ` Herve Codina
2021-06-24 16:22 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 05/15] package/pkg-generic.mk: Perform .la files fixup in per-package HOST_DIR Herve Codina
2021-06-21 20:48 ` Thomas Petazzoni
2021-06-22 9:38 ` Herve Codina
2021-06-22 10:12 ` Yann E. MORIN
2021-06-24 16:20 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 06/15] package/pkg-generic.mk: Introduce <PKG>_PER_PACKAGE_TWEAK_HOOKS Herve Codina
2021-06-21 15:10 ` Thomas Petazzoni
2021-06-22 20:39 ` Yann E. MORIN
2021-06-23 12:40 ` Thomas Petazzoni
2021-06-25 7:15 ` Herve Codina
2021-06-25 7:21 ` Herve Codina
2021-07-02 7:18 ` Herve Codina
2021-07-03 6:21 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 07/15] package/apr-util: Use <PKG>_PER_PACKAGE_TWEAK_HOOKS Herve Codina
2021-06-21 20:56 ` Thomas Petazzoni
2021-06-22 9:47 ` Herve Codina
2021-06-22 20:42 ` Yann E. MORIN
2021-06-25 7:30 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 08/15] package/apache: Move APACHE_FIXUP_APR_LIBTOOL to <PKG>_PER_PACKAGE_TWEAK_HOOKS Herve Codina
2021-06-22 20:43 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 09/15] package/pkg-python: Remove _sysconfigdata*.pyc files when _sysconfigdata*.py are changed Herve Codina
2021-06-21 15:12 ` Thomas Petazzoni
2021-06-22 17:52 ` Herve Codina
2021-06-22 20:50 ` Yann E. MORIN
2021-06-25 8:04 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 10/15] package/pkg-generic.mk: Move python fixup to generic package infrastructure Herve Codina
2021-06-22 21:01 ` Yann E. MORIN
2021-06-25 8:22 ` Herve Codina
2021-06-25 9:27 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 11/15] package/owfs: Remove Python sysconfigdata fixup Herve Codina
2021-06-22 21:02 ` Yann E. MORIN
2021-06-25 8:25 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 12/15] package/pkg-generic.mk: Generate final rsync exclude file list Herve Codina
2021-06-22 21:15 ` Yann E. MORIN
2021-06-25 9:05 ` Herve Codina
2021-06-25 9:32 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 13/15] Makefile: Rsync global {TARGET, HOST}_DIR using exclusion " Herve Codina
2021-06-24 20:20 ` Yann E. MORIN
2021-06-24 20:34 ` Yann E. MORIN
2021-06-25 11:59 ` Herve Codina
2021-06-25 12:50 ` Yann E. MORIN
2021-06-25 12:00 ` Herve Codina
2021-06-21 14:11 ` [Buildroot] [PATCH 14/15] Makefile: Breaks hardlinks in global {TARGET, HOST}_DIR on per-package build Herve Codina
2021-06-24 20:22 ` Yann E. MORIN
2021-06-21 14:11 ` [Buildroot] [PATCH 15/15] package/pkg-generic.mk: Fix per-package <pkg>-{reconfigure, rebuild, reinstall} Herve Codina
2021-06-24 20:44 ` Yann E. MORIN
2021-06-25 14:00 ` Herve Codina
2021-06-21 20:42 ` [Buildroot] [PATCH 00/15] Overwritten file detection and fixes, one more step to TLP build Arnout Vandecappelle
2021-07-06 14:15 ` Herve Codina
2021-06-24 20:53 ` Yann E. MORIN
2021-06-25 9:08 ` Andreas Naumann
2021-06-25 13:13 ` Herve Codina
2021-06-25 14:55 ` Andreas Naumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621225411.1c5280f0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.