From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F68C48BE5 for ; Tue, 22 Jun 2021 00:39:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD84A6135F for ; Tue, 22 Jun 2021 00:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbhFVAmI (ORCPT ); Mon, 21 Jun 2021 20:42:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbhFVAmG (ORCPT ); Mon, 21 Jun 2021 20:42:06 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA951C06175F for ; Mon, 21 Jun 2021 17:39:50 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id q192so8461414pfc.7 for ; Mon, 21 Jun 2021 17:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=s0hSFyBOMIAWlCuSu1vBbDo1kcTnOHZBktwNR9sfYvA=; b=qPJdSN7g1AsTCXEWl0N7D5lxwqBZepXT3xL4VOp1k3OpauOOUFtJUck7NEIAOh9UWY pAjIzFSmKm2YCTX+CTW0dyhaW53po289RV/eVDwTpEWi0lDhxs/XflWq7fLhopWl3AZh V24oVr/ZKaElrwBOdqDzwE4cXevRsoRvu3OKPpdiL6UwEkfliqTMPtJYH+ARZInZHAbY 23JzTiG2ynK7AwYqVPwbPK2VmSjFzPlHlN2sYRvIEl1q8lFeS0U37kDLJ2lpaKsD+Y7C YXlFPLDaMKFH8P1ceC9Qhr50FDDpMTl1V1GfmW1BbCtiv4Rx043gIP3kLQjLIfieQG75 4uHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s0hSFyBOMIAWlCuSu1vBbDo1kcTnOHZBktwNR9sfYvA=; b=H+0NAcUTin5xplCTiAH0Engz7UsD/1tD/i9KybHGf6rYQt/tD0mE1mCGRWNUGLKpDw TuRZmqOW8414S0PcaHVkK5GN2OWa/Ki1WyNgkuIKyzMSmsGPMQL3zQCVBqmrNx1ih0wj HitZkEApI+MEzpcpjKqNNmJ/DUbOExR4dkhtUgDoU1UR80C3Q0FTmigsmTadlzh8gWi8 CkdFDKjQcCSS9Fu3hXJNcNxjxBexwv9Gy5DfC6BSOAEnwhIj/4LpPm0jb9pa09bXUsgO gJyo4cqNvfE+yOX2v4+Lj4pZX6VakdOewTdPVCeTDWqScIL/JQCTFvw3h0wniiPsIiV6 WX6g== X-Gm-Message-State: AOAM532I/GZoS3F4x/s8KQDFgoFvVfTzIvQ2ZF4rbHwxMpl3S9TDrr2G 8p2wkspvHly2DLElbjWbjF57fg== X-Google-Smtp-Source: ABdhPJxlEhuoFcHTsQnLHecAqG8hLUmDQm1gRFgQQWrBkWCoX6wr4nEvTWJDiCqzeSm2SPW35s7ZZw== X-Received: by 2002:a63:c1e:: with SMTP id b30mr1142770pgl.118.1624322390352; Mon, 21 Jun 2021 17:39:50 -0700 (PDT) Received: from localhost.localdomain (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id h11sm17722762pgq.68.2021.06.21.17.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 17:39:50 -0700 (PDT) From: Shawn Guo To: Jassi Brar Cc: Rob Herring , Sivaprakash Murugesan , Bjorn Andersson , Benjamin Li , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Guo Subject: [PATCH v3 2/3] mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device Date: Tue, 22 Jun 2021 08:39:18 +0800 Message-Id: <20210622003919.10442-3-shawn.guo@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210622003919.10442-1-shawn.guo@linaro.org> References: <20210622003919.10442-1-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org In adding APCS clock support for MSM8939, the second clock registration fails due to duplicate device name like below. [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' ... [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk This is because MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect). Although only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock control bits. That said, 3 'qcom-apcs-msm8916-clk' devices need to be registered to instantiate all 3 clocks. Use PLATFORM_DEVID_AUTO rather than PLATFORM_DEVID_NONE for platform_device_register_data() call to fix the issue above. Signed-off-by: Shawn Guo Reviewed-by: Bjorn Andersson --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index f25324d03842..15236d729625 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -132,7 +132,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) if (apcs_data->clk_name) { apcs->clk = platform_device_register_data(&pdev->dev, apcs_data->clk_name, - PLATFORM_DEVID_NONE, + PLATFORM_DEVID_AUTO, NULL, 0); if (IS_ERR(apcs->clk)) dev_err(&pdev->dev, "failed to register APCS clk\n"); -- 2.17.1