From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
vladyslavt@nvidia.com, mkubecek@suse.cz, moshe@nvidia.com,
mlxsw@nvidia.com, Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 4/7] ethtool: Document behavior when module EEPROM bank attribute is omitted
Date: Tue, 22 Jun 2021 09:50:49 +0300 [thread overview]
Message-ID: <20210622065052.2545107-5-idosch@idosch.org> (raw)
In-Reply-To: <20210622065052.2545107-1-idosch@idosch.org>
From: Ido Schimmel <idosch@nvidia.com>
The kernel assumes bank 0 when 'ETHTOOL_MSG_MODULE_EEPROM_GET' is sent
without 'ETHTOOL_A_MODULE_EEPROM_BANK'.
Document it as part of the interface documentation.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
Documentation/networking/ethtool-netlink.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
index 8ae644f800f0..6ea91e41593f 100644
--- a/Documentation/networking/ethtool-netlink.rst
+++ b/Documentation/networking/ethtool-netlink.rst
@@ -1383,6 +1383,8 @@ Request contents:
``ETHTOOL_A_MODULE_EEPROM_I2C_ADDRESS`` u8 page I2C address
======================================= ====== ==========================
+If ``ETHTOOL_A_MODULE_EEPROM_BANK`` is not specified, bank 0 is assumed.
+
Kernel response contents:
+---------------------------------------------+--------+---------------------+
--
2.31.1
next prev parent reply other threads:[~2021-06-22 6:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 6:50 [PATCH net-next 0/7] ethtool: Module EEPROM API improvements Ido Schimmel
2021-06-22 6:50 ` [PATCH net-next 1/7] ethtool: Use correct command name in title Ido Schimmel
2021-06-22 6:50 ` [PATCH net-next 2/7] ethtool: Document correct attribute type Ido Schimmel
2021-06-22 6:50 ` [PATCH net-next 3/7] ethtool: Decrease size of module EEPROM get policy array Ido Schimmel
2021-06-22 6:50 ` Ido Schimmel [this message]
2021-06-22 6:50 ` [PATCH net-next 5/7] ethtool: Use kernel data types for internal EEPROM struct Ido Schimmel
2021-06-22 6:50 ` [PATCH net-next 6/7] ethtool: Validate module EEPROM length as part of policy Ido Schimmel
2021-06-22 6:50 ` [PATCH net-next 7/7] ethtool: Validate module EEPROM offset " Ido Schimmel
2021-06-22 16:30 ` [PATCH net-next 0/7] ethtool: Module EEPROM API improvements Jakub Kicinski
2021-06-22 23:10 ` Michal Kubecek
2021-06-22 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622065052.2545107-5-idosch@idosch.org \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=vladyslavt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.