From mboxrd@z Thu Jan  1 00:00:00 1970
From: Herve Codina <herve.codina@bootlin.com>
Date: Tue, 22 Jun 2021 11:47:59 +0200
Subject: [Buildroot] [PATCH 07/15] package/apr-util: Use
 <PKG>_PER_PACKAGE_TWEAK_HOOKS
In-Reply-To: <20210621225632.25d19d4d@windsurf>
References: <20210621141130.48654-1-herve.codina@bootlin.com>
 <20210621141130.48654-8-herve.codina@bootlin.com>
 <20210621225632.25d19d4d@windsurf>
Message-ID: <20210622114759.40df3f6b@bootlin.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi,

On Mon, 21 Jun 2021 22:56:32 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Mon, 21 Jun 2021 16:11:22 +0200
> Herve Codina <herve.codina@bootlin.com> wrote:
> 
> > rules.mk is generated by apr-util configure step and it is private
> > to apr-util. The modification performed needs to be kept in
> > <PKG>_POST_CONFIGURE_HOOKS.  
> 
> Are you sure ? Both the tweak to build-1/libtool and rules.mk were
> introduced in commit 84b4c19e551288911a230c2b73e96bc6e2ed12f9 to solve
> per-package issues. So I would strongly suspect that both of them need
> to be moved to APR_UTIL_PER_PACKAGE_TWEAK_HOOKS.
> 

Yes, both of them need to be done but
rules.mk is generated by apr-util itself at configure step.
This file is not present (not yet generated) when APR_UTIL_PER_PACKAGE_TWEAK_HOOKS
are called.

XXX_PER_PACKAGE_TWEAK_HOOKS are for tweaking files external to current package
that leads to overwrite -> Ok for build-1/libtool

rules.mk is not correct for per-package build but it is generated by 
apr-util package for apr-util package without any overwrites
-> Keep tweak in <PKG>_POST_CONFIGURE_HOOKS.

Herv?

-- 
Herv? Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com