From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Tue, 22 Jun 2021 22:42:18 +0200
Subject: [Buildroot] [PATCH 07/15] package/apr-util: Use
 <PKG>_PER_PACKAGE_TWEAK_HOOKS
In-Reply-To: <20210622114759.40df3f6b@bootlin.com>
References: <20210621141130.48654-1-herve.codina@bootlin.com>
 <20210621141130.48654-8-herve.codina@bootlin.com>
 <20210621225632.25d19d4d@windsurf>
 <20210622114759.40df3f6b@bootlin.com>
Message-ID: <20210622204218.GK44262@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Herv?, All,

On 2021-06-22 11:47 +0200, Herve Codina spake thusly:
> On Mon, 21 Jun 2021 22:56:32 +0200
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> > On Mon, 21 Jun 2021 16:11:22 +0200
> > Herve Codina <herve.codina@bootlin.com> wrote:
> > 
> > > rules.mk is generated by apr-util configure step and it is private
> > > to apr-util. The modification performed needs to be kept in
> > > <PKG>_POST_CONFIGURE_HOOKS.  
> > 
> > Are you sure ? Both the tweak to build-1/libtool and rules.mk were
> > introduced in commit 84b4c19e551288911a230c2b73e96bc6e2ed12f9 to solve
> > per-package issues. So I would strongly suspect that both of them need
> > to be moved to APR_UTIL_PER_PACKAGE_TWEAK_HOOKS.
> > 
> 
> Yes, both of them need to be done but
> rules.mk is generated by apr-util itself at configure step.
> This file is not present (not yet generated) when APR_UTIL_PER_PACKAGE_TWEAK_HOOKS
> are called.
> 
> XXX_PER_PACKAGE_TWEAK_HOOKS are for tweaking files external to current package
> that leads to overwrite -> Ok for build-1/libtool
> 
> rules.mk is not correct for per-package build but it is generated by 
> apr-util package for apr-util package without any overwrites
> -> Keep tweak in <PKG>_POST_CONFIGURE_HOOKS.

Yes, this all makes sense now.

Also, for apr and apr-utils, we are fortunate enough that the tweak is
not required at configure time, but at build time, which so far allowed
us to use POST_CONFIGURE hooks.

However, for some other packages, we might not be so lucky, and we would
have needed pre- and -postconfigure hooks. The pre-hooks can't be used
anymore for such tweaks, because of file-overwrite detection, so we need
those earlier hook.

Makes sense, makes sense.

So, except for the naming of the variable, when you respin, you can
carry my:

    Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> Herv?
> 
> -- 
> Herv? Codina, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'