All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: linux-renesas-soc@vger.kernel.org
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
	LUU HOAI <hoai.luu.ub@renesas.com>
Subject: [RFC PATCH 04/15] drm: rcar-du: dsi: Reorganize probe function
Date: Wed, 23 Jun 2021 06:46:45 +0300	[thread overview]
Message-ID: <20210623034656.10316-5-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20210623034656.10316-1-laurent.pinchart+renesas@ideasonboard.com>

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
index 0c9887557761..92cd431631bf 100644
--- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
+++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
@@ -832,10 +832,7 @@ static int rcar_mipi_dsi_probe(struct platform_device *pdev)
 	if (ret < 0)
 		return ret;
 
-	/* Initialize the DRM bridge. */
-	mipi_dsi->bridge.funcs = &rcar_mipi_dsi_bridge_ops;
-	mipi_dsi->bridge.of_node = pdev->dev.of_node;
-
+	/* Acquire resources. */
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	mipi_dsi->mmio = devm_ioremap_resource(&pdev->dev, mem);
 	if (IS_ERR(mipi_dsi->mmio))
@@ -851,13 +848,16 @@ static int rcar_mipi_dsi_probe(struct platform_device *pdev)
 		return PTR_ERR(mipi_dsi->rstc);
 	}
 
-	/* Initialize the DST host. */
+	/* Initialize the DSI host. */
 	mipi_dsi->host.dev = dev;
 	mipi_dsi->host.ops = &rcar_mipi_dsi_host_ops;
 	ret = mipi_dsi_host_register(&mipi_dsi->host);
 	if (ret < 0)
 		return ret;
 
+	/* Initialize the DRM bridge. */
+	mipi_dsi->bridge.funcs = &rcar_mipi_dsi_bridge_ops;
+	mipi_dsi->bridge.of_node = pdev->dev.of_node;
 	drm_bridge_add(&mipi_dsi->bridge);
 
 	return 0;
-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2021-06-23  3:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  3:46 [RFC PATCH 00/15] R-Car V3U: DSI encoder driver Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 01/15] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX Laurent Pinchart
2021-06-23  9:06   ` Kieran Bingham
2021-06-23 13:06     ` Laurent Pinchart
2021-06-23 13:12     ` Geert Uytterhoeven
2021-06-23 14:36       ` Kieran Bingham
2021-06-23  3:46 ` [RFC PATCH 02/15] drm: rcar-du: Add R-Car DSI driver Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 03/15] drm: rcar-du: dsi: Use the correct compatible Laurent Pinchart
2021-06-23  3:46 ` Laurent Pinchart [this message]
2021-06-23  3:46 ` [RFC PATCH 05/15] drm: rcar-du: dsi: Use dev_err_probe() Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 06/15] drm: rcar-du: dsi: Shorten mipi_dsi variable name to dsi Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 07/15] drm: rcar-du: dsi: Use dsi->dev consistently in probe() Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 08/15] drm: rcar-du: dsi: Get next bridge " Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 09/15] drm: rcar-du: dsi: Simplify DT parsing Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 10/15] drm: rcar-du: dsi: Add error handling in rcar_mipi_dsi_clk_enable() Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 11/15] drm: rcar-du: dsi: Simplify error handling in rcar_mipi_dsi_enable() Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 12/15] drm: rcar-du: dsi: Turn container_of() wrappers to inline functions Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 13/15] drm: rcar-du: dsi: Various style and typo fixes Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 14/15] drm: rcar-du: dsi: Use read_poll_timeout() Laurent Pinchart
2021-06-23  3:46 ` [RFC PATCH 15/15] drm: rcar-du: dsi: Include the DSI header Laurent Pinchart
2021-06-23 11:00 ` [RFC PATCH 16/15] rcar-du: dsi: Unexport clock functions Kieran Bingham
2021-06-23 13:11   ` Laurent Pinchart
2021-06-23 11:23 ` [RFC PATCH 00/15] R-Car V3U: DSI encoder driver Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210623034656.10316-5-laurent.pinchart+renesas@ideasonboard.com \
    --to=laurent.pinchart+renesas@ideasonboard.com \
    --cc=hoai.luu.ub@renesas.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.