[PATCH] regulator: bd9576: Fix testing wrong flag in check_temp_flag_mismatch

[PATCH] regulator: bd9576: Fix testing wrong flag in check_temp_flag_mismatch

[Axel Lin]

Fix trivial copy-paste typo.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/bd9576-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/bd9576-regulator.c b/drivers/regulator/bd9576-regulator.c
index 8b54d88827be..3023069536ff 100644
--- a/drivers/regulator/bd9576-regulator.c
+++ b/drivers/regulator/bd9576-regulator.c
@@ -294,9 +294,9 @@ static bool check_temp_flag_mismatch(struct regulator_dev *rdev, int severity,
 				    struct bd957x_regulator_data *r)
 {
 	if ((severity == REGULATOR_SEVERITY_ERR &&
-	     r->ovd_notif != REGULATOR_EVENT_OVER_TEMP) ||
+	     r->temp_notif != REGULATOR_EVENT_OVER_TEMP) ||
 	     (severity == REGULATOR_SEVERITY_WARN &&
-	     r->ovd_notif != REGULATOR_EVENT_OVER_TEMP_WARN)) {
+	     r->temp_notif != REGULATOR_EVENT_OVER_TEMP_WARN)) {
 		dev_warn(rdev_get_dev(rdev),
 			 "Can't support both thermal WARN and ERR\n");
 		if (severity == REGULATOR_SEVERITY_WARN)
-- 
2.25.1

Re: [PATCH] regulator: bd9576: Fix testing wrong flag in check_temp_flag_mismatch

[Matti Vaittinen]

On Wed, 2021-06-23 at 23:34 +0800, Axel Lin wrote:
> Fix trivial copy-paste typo.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/bd9576-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/bd9576-regulator.c
> b/drivers/regulator/bd9576-regulator.c
> index 8b54d88827be..3023069536ff 100644
> --- a/drivers/regulator/bd9576-regulator.c
> +++ b/drivers/regulator/bd9576-regulator.c
> @@ -294,9 +294,9 @@ static bool check_temp_flag_mismatch(struct
> regulator_dev *rdev, int severity,
>  				    struct bd957x_regulator_data *r)
>  {
>  	if ((severity == REGULATOR_SEVERITY_ERR &&
> -	     r->ovd_notif != REGULATOR_EVENT_OVER_TEMP) ||
> +	     r->temp_notif != REGULATOR_EVENT_OVER_TEMP) ||
>  	     (severity == REGULATOR_SEVERITY_WARN &&
> -	     r->ovd_notif != REGULATOR_EVENT_OVER_TEMP_WARN)) {
> +	     r->temp_notif != REGULATOR_EVENT_OVER_TEMP_WARN)) {
>  		dev_warn(rdev_get_dev(rdev),
>  			 "Can't support both thermal WARN and ERR\n");
>  		if (severity == REGULATOR_SEVERITY_WARN)

 Once again, Thanks a lot Axel!

Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

Re: [PATCH] regulator: bd9576: Fix testing wrong flag in check_temp_flag_mismatch

[Mark Brown]

On Wed, 23 Jun 2021 23:34:43 +0800, Axel Lin wrote:
> Fix trivial copy-paste typo.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: bd9576: Fix testing wrong flag in check_temp_flag_mismatch
      commit: 8888ef2304d0ae78f3d5ec19653fa7cc4ffdbd7a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark