From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 485BEC48BC2 for ; Wed, 23 Jun 2021 16:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2620161026 for ; Wed, 23 Jun 2021 16:41:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhFWQoI (ORCPT ); Wed, 23 Jun 2021 12:44:08 -0400 Received: from netrider.rowland.org ([192.131.102.5]:56843 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S229938AbhFWQoH (ORCPT ); Wed, 23 Jun 2021 12:44:07 -0400 Received: (qmail 500580 invoked by uid 1000); 23 Jun 2021 12:41:48 -0400 Date: Wed, 23 Jun 2021 12:41:48 -0400 From: Alan Stern To: Claudiu.Beznea@microchip.com Cc: gregkh@linuxfoundation.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com, Cristian.Birsan@microchip.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses Message-ID: <20210623164148.GC499969@rowland.harvard.edu> References: <20210609121027.70951-1-claudiu.beznea@microchip.com> <20210609230735.GA1861855@rowland.harvard.edu> <0621eaba-db4d-a174-1b15-535e804b52ac@microchip.com> <20210623135915.GB491169@rowland.harvard.edu> <20210623141907.GC491169@rowland.harvard.edu> <8bff20a7-8eb8-276a-086e-f1729fbbdbe4@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bff20a7-8eb8-276a-086e-f1729fbbdbe4@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021 at 02:33:14PM +0000, Claudiu.Beznea@microchip.com wrote: > On 23.06.2021 17:19, Alan Stern wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Wed, Jun 23, 2021 at 02:09:16PM +0000, Claudiu.Beznea@microchip.com wrote: > >> On 23.06.2021 16:59, Alan Stern wrote: > >>> One thing you might consider changing: The name of the > >>> ohci_at91_port_suspend routine is misleading. It doesn't really > >>> handle suspending the port; instead it handles the clocks that drive > >>> the entire OHCI controller. Right? > >> > >> It does both as far as I can tell at the moment. > > > > But the name suggests that it only handles suspending a port. That's > > misleading. > > > > And the way it is used in the SetPortFeature(USB_PORT_FEAT_SUSPEND) > > case in ohci_at91_hub_control is just plain wrong. It won't merely > > suspend a single port; it will disable the entire OHCI controller. > > Agree with all the above! Are there any systems beside the SAMA7G5 and others you tested which might be affected by this patch? Do they all work pretty much the same way? (I want to make sure no others will be adversely affected by this change.) Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D795DC4743C for ; Wed, 23 Jun 2021 16:43:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A166B61026 for ; Wed, 23 Jun 2021 16:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A166B61026 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MEExUjwIdhW7UBBvYY+tN8bIAff8L4L3OukSx0rz+4Q=; b=oSrMoO5jFu/Th4 bBW6oIg7ITq+Ff27yCdxeb/A5fzIZTB70yS6T7vBn0sc5p99lFubCiSJl/EgMdNh9cDzs6YzM9x0B 6ju0xas1Exb3jp1oUAIeq4kna5Ip+yETVogJqIoptO9nULTo6r8DTaJg9pMkqYREsSx8vKegqz6RW +2gdkR0BMXudTaXU3RUjHJooiE8GUsjcjpCIVyYkjV0JTI0ydpFht9+iKhBSKyh1SXl2AzW2ZqUEY G82XJl2Fs3cajAs5km9IJmw6Z5W+R9Cllx5xKaukcglCHPfLll3NDVon7O63AV+paX+hB9Pa7a9+K Gc6VGvQlAXYjL7F314qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw5wo-00BIZA-4k; Wed, 23 Jun 2021 16:41:54 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by bombadil.infradead.org with smtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lw5wk-00BIYW-F3 for linux-arm-kernel@lists.infradead.org; Wed, 23 Jun 2021 16:41:51 +0000 Received: (qmail 500580 invoked by uid 1000); 23 Jun 2021 12:41:48 -0400 Date: Wed, 23 Jun 2021 12:41:48 -0400 From: Alan Stern To: Claudiu.Beznea@microchip.com Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses Message-ID: <20210623164148.GC499969@rowland.harvard.edu> References: <20210609121027.70951-1-claudiu.beznea@microchip.com> <20210609230735.GA1861855@rowland.harvard.edu> <0621eaba-db4d-a174-1b15-535e804b52ac@microchip.com> <20210623135915.GB491169@rowland.harvard.edu> <20210623141907.GC491169@rowland.harvard.edu> <8bff20a7-8eb8-276a-086e-f1729fbbdbe4@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8bff20a7-8eb8-276a-086e-f1729fbbdbe4@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_094150_693891_616B0078 X-CRM114-Status: GOOD ( 14.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-arm-kernel@lists.infradead.org, Cristian.Birsan@microchip.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 23, 2021 at 02:33:14PM +0000, Claudiu.Beznea@microchip.com wrote: > On 23.06.2021 17:19, Alan Stern wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > On Wed, Jun 23, 2021 at 02:09:16PM +0000, Claudiu.Beznea@microchip.com wrote: > >> On 23.06.2021 16:59, Alan Stern wrote: > >>> One thing you might consider changing: The name of the > >>> ohci_at91_port_suspend routine is misleading. It doesn't really > >>> handle suspending the port; instead it handles the clocks that drive > >>> the entire OHCI controller. Right? > >> > >> It does both as far as I can tell at the moment. > > > > But the name suggests that it only handles suspending a port. That's > > misleading. > > > > And the way it is used in the SetPortFeature(USB_PORT_FEAT_SUSPEND) > > case in ohci_at91_hub_control is just plain wrong. It won't merely > > suspend a single port; it will disable the entire OHCI controller. > > Agree with all the above! Are there any systems beside the SAMA7G5 and others you tested which might be affected by this patch? Do they all work pretty much the same way? (I want to make sure no others will be adversely affected by this change.) Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel