All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Add AM64x SoC support to PRU remoteproc driver
@ 2021-06-23 17:32 ` Suman Anna
  0 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2021-06-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel, Suman Anna

Hi All,

The following series updates the PRU remoteproc driver to support the
PRU, RTU and Tx_PRU cores present within the ICSSG IP on AM64x SoCs.
Patches are on top of latest rproc-next branch based on v5.13-rc1,
commit 30da589dba53 ("dt-bindings: remoteproc: qcom: pas: Fix indentation
warnings").

There are some minor differences around the PRU cores like different
Broadside RAM (BSRAM) sizes, but otherwise behave functionally the same
as the PRU cores on previous SoCs.

regards,
Suman

Suman Anna (2):
  dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
  remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs

 .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
 drivers/remoteproc/pru_rproc.c                               | 3 +++
 2 files changed, 8 insertions(+)

-- 
2.30.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 0/2] Add AM64x SoC support to PRU remoteproc driver
@ 2021-06-23 17:32 ` Suman Anna
  0 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2021-06-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: devicetree, Grzegorz Jaszczyk, Vignesh Raghavendra, Lokesh Vutla,
	Jan Kiszka, linux-remoteproc, Kishon Vijay Abraham I, linux-omap,
	linux-arm-kernel

Hi All,

The following series updates the PRU remoteproc driver to support the
PRU, RTU and Tx_PRU cores present within the ICSSG IP on AM64x SoCs.
Patches are on top of latest rproc-next branch based on v5.13-rc1,
commit 30da589dba53 ("dt-bindings: remoteproc: qcom: pas: Fix indentation
warnings").

There are some minor differences around the PRU cores like different
Broadside RAM (BSRAM) sizes, but otherwise behave functionally the same
as the PRU cores on previous SoCs.

regards,
Suman

Suman Anna (2):
  dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
  remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs

 .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
 drivers/remoteproc/pru_rproc.c                               | 3 +++
 2 files changed, 8 insertions(+)

-- 
2.30.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
  2021-06-23 17:32 ` Suman Anna
@ 2021-06-23 17:32   ` Suman Anna
  -1 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2021-06-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel, Suman Anna

The K3 AM64x SoCs have an ICSSG IP that is similar to the IP revisions
used on K3 AM65x SR2.0 and J721E SoCs. The ICSSG IP on K3 AM64x SoCs
have the same set of two PRU cores, two RTU cores and two auxiliary PRU
cores called Transmit PRUs (Tx_PRUs). There are some minor differences
surrounding the PRU cores like different Broadside RAM (BSRAM) sizes
w.r.t AM65x SR1.0 SoCs.

Update the PRU remoteproc bindings for these PRU cores on AM64x SoCs.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
index 63071eef1632..4f8435d49a62 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
@@ -44,6 +44,9 @@ properties:
       - ti,j721e-pru    # for PRUs in K3 J721E SoC family
       - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
       - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
+      - ti,am642-pru    # for PRUs in K3 AM64x SoC family
+      - ti,am642-rtu    # for RTUs in K3 AM64x SoC family
+      - ti,am642-tx-pru # for Tx_PRUs in K3 AM64x SoC family
 
   reg:
     items:
@@ -68,6 +71,7 @@ if:
       enum:
         - ti,am654-rtu
         - ti,j721e-rtu
+        - ti,am642-rtu
 then:
   properties:
     $nodename:
@@ -79,6 +83,7 @@ else:
         enum:
           - ti,am654-tx-pru
           - ti,j721e-tx-pru
+          - ti,am642-tx-pru
   then:
     properties:
       $nodename:
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
@ 2021-06-23 17:32   ` Suman Anna
  0 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2021-06-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: devicetree, Grzegorz Jaszczyk, Vignesh Raghavendra, Lokesh Vutla,
	Jan Kiszka, linux-remoteproc, Kishon Vijay Abraham I, linux-omap,
	linux-arm-kernel

The K3 AM64x SoCs have an ICSSG IP that is similar to the IP revisions
used on K3 AM65x SR2.0 and J721E SoCs. The ICSSG IP on K3 AM64x SoCs
have the same set of two PRU cores, two RTU cores and two auxiliary PRU
cores called Transmit PRUs (Tx_PRUs). There are some minor differences
surrounding the PRU cores like different Broadside RAM (BSRAM) sizes
w.r.t AM65x SR1.0 SoCs.

Update the PRU remoteproc bindings for these PRU cores on AM64x SoCs.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
index 63071eef1632..4f8435d49a62 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
@@ -44,6 +44,9 @@ properties:
       - ti,j721e-pru    # for PRUs in K3 J721E SoC family
       - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
       - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
+      - ti,am642-pru    # for PRUs in K3 AM64x SoC family
+      - ti,am642-rtu    # for RTUs in K3 AM64x SoC family
+      - ti,am642-tx-pru # for Tx_PRUs in K3 AM64x SoC family
 
   reg:
     items:
@@ -68,6 +71,7 @@ if:
       enum:
         - ti,am654-rtu
         - ti,j721e-rtu
+        - ti,am642-rtu
 then:
   properties:
     $nodename:
@@ -79,6 +83,7 @@ else:
         enum:
           - ti,am654-tx-pru
           - ti,j721e-tx-pru
+          - ti,am642-tx-pru
   then:
     properties:
       $nodename:
-- 
2.30.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs
  2021-06-23 17:32 ` Suman Anna
@ 2021-06-23 17:32   ` Suman Anna
  -1 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2021-06-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel, Suman Anna

The K3 AM64x family of SoCs have a ICSSG IP that is similar to the
version on AM65x SR2.0 SoCs with some minor differences. The AM64x
SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor
subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called
RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).

Enhance the existing PRU remoteproc driver to support all these PRU,
RTU and Tx_PRU cores by using specific compatibles. The cores have the
same memory copying limitations as on AM65x, so reuses the custom memcpy
function within the driver's ELF loader implementation. The initial
names for the firmware images for each PRU core are retrieved from
DT nodes, and can be adjusted through sysfs if required.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/remoteproc/pru_rproc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index e5778e476245..0ecf2675f5eb 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
 	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
 	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
 	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
+	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
+	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
+	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
 	{},
 };
 MODULE_DEVICE_TABLE(of, pru_rproc_match);
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs
@ 2021-06-23 17:32   ` Suman Anna
  0 siblings, 0 replies; 12+ messages in thread
From: Suman Anna @ 2021-06-23 17:32 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: devicetree, Grzegorz Jaszczyk, Vignesh Raghavendra, Lokesh Vutla,
	Jan Kiszka, linux-remoteproc, Kishon Vijay Abraham I, linux-omap,
	linux-arm-kernel

The K3 AM64x family of SoCs have a ICSSG IP that is similar to the
version on AM65x SR2.0 SoCs with some minor differences. The AM64x
SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor
subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called
RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).

Enhance the existing PRU remoteproc driver to support all these PRU,
RTU and Tx_PRU cores by using specific compatibles. The cores have the
same memory copying limitations as on AM65x, so reuses the custom memcpy
function within the driver's ELF loader implementation. The initial
names for the firmware images for each PRU core are retrieved from
DT nodes, and can be adjusted through sysfs if required.

Signed-off-by: Suman Anna <s-anna@ti.com>
---
 drivers/remoteproc/pru_rproc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index e5778e476245..0ecf2675f5eb 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
 	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
 	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
 	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
+	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
+	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
+	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
 	{},
 };
 MODULE_DEVICE_TABLE(of, pru_rproc_match);
-- 
2.30.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
  2021-06-23 17:32   ` Suman Anna
@ 2021-06-23 18:21     ` Grygorii Strashko
  -1 siblings, 0 replies; 12+ messages in thread
From: Grygorii Strashko @ 2021-06-23 18:21 UTC (permalink / raw)
  To: Suman Anna, Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel



On 23/06/2021 20:32, Suman Anna wrote:
> The K3 AM64x SoCs have an ICSSG IP that is similar to the IP revisions
> used on K3 AM65x SR2.0 and J721E SoCs. The ICSSG IP on K3 AM64x SoCs
> have the same set of two PRU cores, two RTU cores and two auxiliary PRU
> cores called Transmit PRUs (Tx_PRUs). There are some minor differences
> surrounding the PRU cores like different Broadside RAM (BSRAM) sizes
> w.r.t AM65x SR1.0 SoCs.
> 
> Update the PRU remoteproc bindings for these PRU cores on AM64x SoCs.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>   .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> index 63071eef1632..4f8435d49a62 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> @@ -44,6 +44,9 @@ properties:
>         - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>         - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>         - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
> +      - ti,am642-pru    # for PRUs in K3 AM64x SoC family
> +      - ti,am642-rtu    # for RTUs in K3 AM64x SoC family
> +      - ti,am642-tx-pru # for Tx_PRUs in K3 AM64x SoC family
>   
>     reg:
>       items:
> @@ -68,6 +71,7 @@ if:
>         enum:
>           - ti,am654-rtu
>           - ti,j721e-rtu
> +        - ti,am642-rtu
>   then:
>     properties:
>       $nodename:
> @@ -79,6 +83,7 @@ else:
>           enum:
>             - ti,am654-tx-pru
>             - ti,j721e-tx-pru
> +          - ti,am642-tx-pru
>     then:
>       properties:
>         $nodename:
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs
@ 2021-06-23 18:21     ` Grygorii Strashko
  0 siblings, 0 replies; 12+ messages in thread
From: Grygorii Strashko @ 2021-06-23 18:21 UTC (permalink / raw)
  To: Suman Anna, Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel



On 23/06/2021 20:32, Suman Anna wrote:
> The K3 AM64x SoCs have an ICSSG IP that is similar to the IP revisions
> used on K3 AM65x SR2.0 and J721E SoCs. The ICSSG IP on K3 AM64x SoCs
> have the same set of two PRU cores, two RTU cores and two auxiliary PRU
> cores called Transmit PRUs (Tx_PRUs). There are some minor differences
> surrounding the PRU cores like different Broadside RAM (BSRAM) sizes
> w.r.t AM65x SR1.0 SoCs.
> 
> Update the PRU remoteproc bindings for these PRU cores on AM64x SoCs.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>   .../devicetree/bindings/remoteproc/ti,pru-rproc.yaml         | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> index 63071eef1632..4f8435d49a62 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> @@ -44,6 +44,9 @@ properties:
>         - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>         - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>         - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
> +      - ti,am642-pru    # for PRUs in K3 AM64x SoC family
> +      - ti,am642-rtu    # for RTUs in K3 AM64x SoC family
> +      - ti,am642-tx-pru # for Tx_PRUs in K3 AM64x SoC family
>   
>     reg:
>       items:
> @@ -68,6 +71,7 @@ if:
>         enum:
>           - ti,am654-rtu
>           - ti,j721e-rtu
> +        - ti,am642-rtu
>   then:
>     properties:
>       $nodename:
> @@ -79,6 +83,7 @@ else:
>           enum:
>             - ti,am654-tx-pru
>             - ti,j721e-tx-pru
> +          - ti,am642-tx-pru
>     then:
>       properties:
>         $nodename:
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs
  2021-06-23 17:32   ` Suman Anna
@ 2021-06-23 18:21     ` Grygorii Strashko
  -1 siblings, 0 replies; 12+ messages in thread
From: Grygorii Strashko @ 2021-06-23 18:21 UTC (permalink / raw)
  To: Suman Anna, Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel



On 23/06/2021 20:32, Suman Anna wrote:
> The K3 AM64x family of SoCs have a ICSSG IP that is similar to the
> version on AM65x SR2.0 SoCs with some minor differences. The AM64x
> SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor
> subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called
> RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).
> 
> Enhance the existing PRU remoteproc driver to support all these PRU,
> RTU and Tx_PRU cores by using specific compatibles. The cores have the
> same memory copying limitations as on AM65x, so reuses the custom memcpy
> function within the driver's ELF loader implementation. The initial
> names for the firmware images for each PRU core are retrieved from
> DT nodes, and can be adjusted through sysfs if required.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>   drivers/remoteproc/pru_rproc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..0ecf2675f5eb 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
>   	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
>   	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
>   	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
> +	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
> +	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
> +	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, pru_rproc_match);
> 


Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs
@ 2021-06-23 18:21     ` Grygorii Strashko
  0 siblings, 0 replies; 12+ messages in thread
From: Grygorii Strashko @ 2021-06-23 18:21 UTC (permalink / raw)
  To: Suman Anna, Bjorn Andersson, Mathieu Poirier, Rob Herring
  Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
	Grzegorz Jaszczyk, Jan Kiszka, linux-remoteproc, devicetree,
	linux-omap, linux-arm-kernel



On 23/06/2021 20:32, Suman Anna wrote:
> The K3 AM64x family of SoCs have a ICSSG IP that is similar to the
> version on AM65x SR2.0 SoCs with some minor differences. The AM64x
> SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor
> subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called
> RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).
> 
> Enhance the existing PRU remoteproc driver to support all these PRU,
> RTU and Tx_PRU cores by using specific compatibles. The cores have the
> same memory copying limitations as on AM65x, so reuses the custom memcpy
> function within the driver's ELF loader implementation. The initial
> names for the firmware images for each PRU core are retrieved from
> DT nodes, and can be adjusted through sysfs if required.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>   drivers/remoteproc/pru_rproc.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..0ecf2675f5eb 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
>   	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
>   	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
>   	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
> +	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
> +	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
> +	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, pru_rproc_match);
> 


Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs
  2021-06-23 17:32   ` Suman Anna
@ 2021-06-24 19:41     ` Mathieu Poirier
  -1 siblings, 0 replies; 12+ messages in thread
From: Mathieu Poirier @ 2021-06-24 19:41 UTC (permalink / raw)
  To: Suman Anna
  Cc: Bjorn Andersson, Rob Herring, Kishon Vijay Abraham I,
	Lokesh Vutla, Vignesh Raghavendra, Grzegorz Jaszczyk, Jan Kiszka,
	linux-remoteproc, devicetree, linux-omap, linux-arm-kernel

On Wed, Jun 23, 2021 at 12:32:42PM -0500, Suman Anna wrote:
> The K3 AM64x family of SoCs have a ICSSG IP that is similar to the
> version on AM65x SR2.0 SoCs with some minor differences. The AM64x
> SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor
> subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called
> RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).
> 
> Enhance the existing PRU remoteproc driver to support all these PRU,
> RTU and Tx_PRU cores by using specific compatibles. The cores have the
> same memory copying limitations as on AM65x, so reuses the custom memcpy
> function within the driver's ELF loader implementation. The initial
> names for the firmware images for each PRU core are retrieved from
> DT nodes, and can be adjusted through sysfs if required.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  drivers/remoteproc/pru_rproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..0ecf2675f5eb 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
>  	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
>  	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
>  	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
> +	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
> +	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
> +	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
>  	{},

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  };
>  MODULE_DEVICE_TABLE(of, pru_rproc_match);
> -- 
> 2.30.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on K3 AM64x SoCs
@ 2021-06-24 19:41     ` Mathieu Poirier
  0 siblings, 0 replies; 12+ messages in thread
From: Mathieu Poirier @ 2021-06-24 19:41 UTC (permalink / raw)
  To: Suman Anna
  Cc: Bjorn Andersson, Rob Herring, Kishon Vijay Abraham I,
	Lokesh Vutla, Vignesh Raghavendra, Grzegorz Jaszczyk, Jan Kiszka,
	linux-remoteproc, devicetree, linux-omap, linux-arm-kernel

On Wed, Jun 23, 2021 at 12:32:42PM -0500, Suman Anna wrote:
> The K3 AM64x family of SoCs have a ICSSG IP that is similar to the
> version on AM65x SR2.0 SoCs with some minor differences. The AM64x
> SoCs contain two instances of this newer ICSSG IP. Each ICSSG processor
> subsystem contains 2 primary PRU cores, 2 auxiliary PRU cores called
> RTUs, and 2 new auxiliary cores called Transmit PRUs (Tx_PRUs).
> 
> Enhance the existing PRU remoteproc driver to support all these PRU,
> RTU and Tx_PRU cores by using specific compatibles. The cores have the
> same memory copying limitations as on AM65x, so reuses the custom memcpy
> function within the driver's ELF loader implementation. The initial
> names for the firmware images for each PRU core are retrieved from
> DT nodes, and can be adjusted through sysfs if required.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  drivers/remoteproc/pru_rproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..0ecf2675f5eb 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -894,6 +894,9 @@ static const struct of_device_id pru_rproc_match[] = {
>  	{ .compatible = "ti,j721e-pru",		.data = &k3_pru_data },
>  	{ .compatible = "ti,j721e-rtu",		.data = &k3_rtu_data },
>  	{ .compatible = "ti,j721e-tx-pru",	.data = &k3_tx_pru_data },
> +	{ .compatible = "ti,am642-pru",		.data = &k3_pru_data },
> +	{ .compatible = "ti,am642-rtu",		.data = &k3_rtu_data },
> +	{ .compatible = "ti,am642-tx-pru",	.data = &k3_tx_pru_data },
>  	{},

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  };
>  MODULE_DEVICE_TABLE(of, pru_rproc_match);
> -- 
> 2.30.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-06-24 19:42 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 17:32 [PATCH 0/2] Add AM64x SoC support to PRU remoteproc driver Suman Anna
2021-06-23 17:32 ` Suman Anna
2021-06-23 17:32 ` [PATCH 1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM64x SoCs Suman Anna
2021-06-23 17:32   ` Suman Anna
2021-06-23 18:21   ` Grygorii Strashko
2021-06-23 18:21     ` Grygorii Strashko
2021-06-23 17:32 ` [PATCH 2/2] remoteproc: pru: Add support for various PRU cores on " Suman Anna
2021-06-23 17:32   ` Suman Anna
2021-06-23 18:21   ` Grygorii Strashko
2021-06-23 18:21     ` Grygorii Strashko
2021-06-24 19:41   ` Mathieu Poirier
2021-06-24 19:41     ` Mathieu Poirier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.