All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: min.li.xe@renesas.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] ptp: idt82p33: implement double dco time correction
Date: Wed, 23 Jun 2021 20:43:43 -0700	[thread overview]
Message-ID: <20210624034343.GB6853@hoboy.vegasvil.org> (raw)
In-Reply-To: <1624459585-31233-2-git-send-email-min.li.xe@renesas.com>

On Wed, Jun 23, 2021 at 10:46:25AM -0400, min.li.xe@renesas.com wrote:
> +static int idt82p33_start_ddco(struct idt82p33_channel *channel, s32 delta_ns)
> +{
> +	s32 current_ppm = channel->current_freq;
> +	u32 duration_ms = MSEC_PER_SEC;

What happens if user space makes a new adjustment before this
completes?

After all, some PTP profiles update the clock several times per
second.

Thanks,
Richard

  reply	other threads:[~2021-06-24  3:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 14:46 [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime min.li.xe
2021-06-23 14:46 ` [PATCH net 2/2] ptp: idt82p33: implement double dco time correction min.li.xe
2021-06-24  3:43   ` Richard Cochran [this message]
2021-06-24 14:40     ` Min Li
2021-06-24 16:15       ` Richard Cochran
2021-06-24  3:40 ` [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime Richard Cochran
2021-06-24 14:38   ` Min Li
2021-06-24 16:14     ` Richard Cochran
2021-06-24 16:20     ` Richard Cochran
2021-06-25 14:24       ` Min Li
2021-06-25 16:20         ` Richard Cochran
2021-07-12 14:00           ` Min Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624034343.GB6853@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min.li.xe@renesas.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.