All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Ciara Power <ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH] test: remove hack for private header inclusion
Date: Thu, 24 Jun 2021 13:53:19 +0200	[thread overview]
Message-ID: <20210624115319.15809-1-david.marchand@redhat.com> (raw)

This hack was needed with the make build system.
With meson, any private header from a library is visible as long as a
dependency to this library is expressed.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test/test_eal_fs.c         | 3 +--
 app/test/test_memzone.c        | 3 ++-
 app/test/test_telemetry_json.c | 3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/test/test_eal_fs.c b/app/test/test_eal_fs.c
index bb93b82a43..39ac6961b3 100644
--- a/app/test/test_eal_fs.c
+++ b/app/test/test_eal_fs.c
@@ -8,8 +8,7 @@
 #include <string.h>
 #include <errno.h>
 
-/* eal_filesystem.h is not a public header file, so use relative path */
-#include "../../lib/eal/common/eal_filesystem.h"
+#include "eal_filesystem.h"
 
 static int
 test_parse_sysfs_value(void)
diff --git a/app/test/test_memzone.c b/app/test/test_memzone.c
index 03a9d1d3bb..27b8b52fcd 100644
--- a/app/test/test_memzone.c
+++ b/app/test/test_memzone.c
@@ -18,7 +18,8 @@
 #include <rte_string_fns.h>
 #include <rte_errno.h>
 #include <rte_malloc.h>
-#include "../../lib/eal/common/malloc_elem.h"
+
+#include "malloc_elem.h"
 
 #include "test.h"
 
diff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c
index 3171ab12ec..790181d316 100644
--- a/app/test/test_telemetry_json.c
+++ b/app/test/test_telemetry_json.c
@@ -4,7 +4,8 @@
 
 #include <string.h>
 
-#include "../../lib/telemetry/telemetry_json.h"
+#include "telemetry_json.h"
+
 #include "test.h"
 
 static int
-- 
2.23.0


             reply	other threads:[~2021-06-24 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 11:53 David Marchand [this message]
2021-06-24 12:09 ` [dpdk-dev] [PATCH] test: remove hack for private header inclusion Bruce Richardson
2021-06-24 16:07 ` Tyler Retzlaff
2021-07-06 14:41 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210624115319.15809-1-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.