From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B58FC49EA6 for ; Thu, 24 Jun 2021 16:04:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC48E611CE for ; Thu, 24 Jun 2021 16:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbhFXQGR (ORCPT ); Thu, 24 Jun 2021 12:06:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:53246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhFXQGP (ORCPT ); Thu, 24 Jun 2021 12:06:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9D5AA613DC; Thu, 24 Jun 2021 16:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624550636; bh=OF3P2uWCEhmEQpfRSdvmdH/4HqACwBVNZCAwCafDzlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3TDSkSeTon+d3w4H7FbVep/Nq32xnhVFPvrFKxuzshVbihsOX0EpKWfq1hrFmTe3 s2lN6iPU+MKEsg2//QSXcTAliPnHvZ3aBdK5/FUWcU6nMo/zIs0UJp4MXpROReM6aY 3gzLONm5211Ks3/W+x2RAMruTKi6u8wSvrkmEWxkVc4XnFU7w+p3IuDy4D8SyKq0uv bzHOg2FUWDD5gidsBjT3qeFH7AzcWM20uciSxh1dMHB/oJ6Ud46TktvMmwOLtfU6E/ I/8e3MTHBC6rcrzj4yA6Gy2E1DdMraIm2dhsBBZyOBM1Wt8+xMbh8wf+CUWmDqL3bD 5m00oiEGs1tcA== Date: Thu, 24 Jun 2021 17:03:31 +0100 From: Mark Brown To: Mark Rutland Cc: madvenka@linux.microsoft.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v5 1/2] arm64: Introduce stack trace reliability checks in the unwinder Message-ID: <20210624160331.GD3912@sirena.org.uk> References: <20210526214917.20099-1-madvenka@linux.microsoft.com> <20210526214917.20099-2-madvenka@linux.microsoft.com> <20210624144021.GA17937@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KdquIMZPjGJQvRdI" Content-Disposition: inline In-Reply-To: <20210624144021.GA17937@C02TD0UTHF1T.local> X-Cookie: World War III? No thanks! User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KdquIMZPjGJQvRdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 24, 2021 at 03:40:21PM +0100, Mark Rutland wrote: > regular unwinds (e.g. so that we can have a backtrace idicate when a > step is not reliable, like x86 does with '?'), and to do that we need to > be a little more accurate. There was the idea that was discussed a bit when I was more actively working on this of just refactoring our unwinder infrastructure to be a lot more like the x86 and (IIRC) S/390 in form. Part of the thing there was that it'd mean that even where we're not able to actually share code we'd have more of a common baseline for how things work and what works. It'd make review, especially cross architecture review, of what's going on a bit easier too - see some of the concerns Josh had about the differences here for example. It'd be a relatively big bit of refactoring though. --KdquIMZPjGJQvRdI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDUrNIACgkQJNaLcl1U h9CUggf/f8lTrrP9PgND3uC0n0Z4T+ayRlT9PjEADfX5Ugv2SQjkosWx3UXmW1fM HodE1+pwLDWJ/rFJrx8KEj/DORPps/PZCyD9Z3iUsRFwnX9M0Zn3TtwU+xKgJmxf okZ3YcKz84h/Wwv4F4/jsuhygAepVY0mYTAQHGB4zSDKDasVe2IFbq/xkr2uSpcC +PDIbXNa8Q0Sq2ltLg/dArsHaheHM24HJTWk4tBJlinujj0+uGREYczmdC94ES/a KIbz/Y8oj35d0LULoWArOB2MpXB/fJWHH6RqE/sk+Zw0ObjbLMLwuGxqhFdOBJB8 LNmjXpF4upK4P8F1y3/8eFnTYt8lCQ== =UEC4 -----END PGP SIGNATURE----- --KdquIMZPjGJQvRdI-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67622C49EA5 for ; Thu, 24 Jun 2021 16:05:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 354E460C3E for ; Thu, 24 Jun 2021 16:05:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 354E460C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1QXyrIenNTk3/ja0Zrliiv1EY5Kxlk1FjpoPKbFaaXU=; b=m8zny5/HUo/aIt04MS2uBa1otI hdhR+P4YlLkKHFrt5UDfUmHx9QGKhes6ayCtqaUq/yLgw6tBmlZ57VlKaug3QVr7182jZQQa3NHK/ T+wu5kdpQcXu0ndWwyA3Lu4JNonUjSJDte0iS1X8i/FoUqBkDd/0Lj1G96DnikmLvaLmbyUwoaY5u WYKhcmHZx9d393U7xxbZ6Ok5E7hpZh3riZ91YC5ubfMs8kSG5goV2qI5BHjMMQgxwnWaOEEFJaOj3 zKuNIxJhg1agB2Vnoqv5ZLGJFiOsbsXzv8uwnWYYD0bZXxQfmZA+fybBDnpop+OB0dhxQg4LZxDDZ 35luX1VA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwRpg-00FOTq-GB; Thu, 24 Jun 2021 16:04:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwRpc-00FOT7-H9 for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 16:03:58 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9D5AA613DC; Thu, 24 Jun 2021 16:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624550636; bh=OF3P2uWCEhmEQpfRSdvmdH/4HqACwBVNZCAwCafDzlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f3TDSkSeTon+d3w4H7FbVep/Nq32xnhVFPvrFKxuzshVbihsOX0EpKWfq1hrFmTe3 s2lN6iPU+MKEsg2//QSXcTAliPnHvZ3aBdK5/FUWcU6nMo/zIs0UJp4MXpROReM6aY 3gzLONm5211Ks3/W+x2RAMruTKi6u8wSvrkmEWxkVc4XnFU7w+p3IuDy4D8SyKq0uv bzHOg2FUWDD5gidsBjT3qeFH7AzcWM20uciSxh1dMHB/oJ6Ud46TktvMmwOLtfU6E/ I/8e3MTHBC6rcrzj4yA6Gy2E1DdMraIm2dhsBBZyOBM1Wt8+xMbh8wf+CUWmDqL3bD 5m00oiEGs1tcA== Date: Thu, 24 Jun 2021 17:03:31 +0100 From: Mark Brown To: Mark Rutland Cc: madvenka@linux.microsoft.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v5 1/2] arm64: Introduce stack trace reliability checks in the unwinder Message-ID: <20210624160331.GD3912@sirena.org.uk> References: <20210526214917.20099-1-madvenka@linux.microsoft.com> <20210526214917.20099-2-madvenka@linux.microsoft.com> <20210624144021.GA17937@C02TD0UTHF1T.local> MIME-Version: 1.0 In-Reply-To: <20210624144021.GA17937@C02TD0UTHF1T.local> X-Cookie: World War III? No thanks! User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_090356_627255_ADDF9067 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6068978413610992228==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6068978413610992228== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KdquIMZPjGJQvRdI" Content-Disposition: inline --KdquIMZPjGJQvRdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 24, 2021 at 03:40:21PM +0100, Mark Rutland wrote: > regular unwinds (e.g. so that we can have a backtrace idicate when a > step is not reliable, like x86 does with '?'), and to do that we need to > be a little more accurate. There was the idea that was discussed a bit when I was more actively working on this of just refactoring our unwinder infrastructure to be a lot more like the x86 and (IIRC) S/390 in form. Part of the thing there was that it'd mean that even where we're not able to actually share code we'd have more of a common baseline for how things work and what works. It'd make review, especially cross architecture review, of what's going on a bit easier too - see some of the concerns Josh had about the differences here for example. It'd be a relatively big bit of refactoring though. --KdquIMZPjGJQvRdI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDUrNIACgkQJNaLcl1U h9CUggf/f8lTrrP9PgND3uC0n0Z4T+ayRlT9PjEADfX5Ugv2SQjkosWx3UXmW1fM HodE1+pwLDWJ/rFJrx8KEj/DORPps/PZCyD9Z3iUsRFwnX9M0Zn3TtwU+xKgJmxf okZ3YcKz84h/Wwv4F4/jsuhygAepVY0mYTAQHGB4zSDKDasVe2IFbq/xkr2uSpcC +PDIbXNa8Q0Sq2ltLg/dArsHaheHM24HJTWk4tBJlinujj0+uGREYczmdC94ES/a KIbz/Y8oj35d0LULoWArOB2MpXB/fJWHH6RqE/sk+Zw0ObjbLMLwuGxqhFdOBJB8 LNmjXpF4upK4P8F1y3/8eFnTYt8lCQ== =UEC4 -----END PGP SIGNATURE----- --KdquIMZPjGJQvRdI-- --===============6068978413610992228== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6068978413610992228==--