From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52531C2B9F4 for ; Fri, 25 Jun 2021 12:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 391196162A for ; Fri, 25 Jun 2021 12:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbhFYMQX (ORCPT ); Fri, 25 Jun 2021 08:16:23 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36135 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbhFYMQU (ORCPT ); Fri, 25 Jun 2021 08:16:20 -0400 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 8348F40004; Fri, 25 Jun 2021 12:13:57 +0000 (UTC) From: Maxime Chevallier To: Russell King , Shawn Guo , Rob Herring , Andrew Lunn , thomas.petazzoni@bootlin.com, herve.codina@bootlin.com, devicetree@vger.kernel.org Cc: Maxime Chevallier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms Date: Fri, 25 Jun 2021 14:13:53 +0200 Message-Id: <20210625121353.3698240-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The AR803x PHY used on this modules seems to require the reset line to be asserted for around 10ms in order to avoid rare cases where the PHY gets stuck in an incoherent state that prevents it to function correctly. The previous value of 2ms was found to be problematic on some setups, causing intermittent issues where the PHY would be unresponsive every once in a while on some sytems, with a low occurrence (it typically took around 30 consecutive reboots to encounter the issue). Bumping the delay to the 10ms makes the issue dissapear, with more than 2500 consecutive reboots performed without the issue showing-up. Fixes: 208d7baf8085 ("ARM: imx: initial SolidRun HummingBoard support") Signed-off-by: Maxime Chevallier Tested-by: Hervé Codina --- This V2 was quickly resent, since the commit-log was incorrect. v2 : Reworded the commit-log to remove an incorrect mention of the datasheet. Add a comment to the DT to explicitly explain the issue. arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi index 0ad8ccde0cf8..f86efd0ccc40 100644 --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi @@ -54,7 +54,13 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_microsom_enet_ar8035>; phy-mode = "rgmii-id"; - phy-reset-duration = <2>; + + /* + * The PHY seems to require a long-enough reset duration to avoid + * some rare issues where the PHY gets stuck in an inconsistent and + * non-functional state at boot-up. 10ms proved to be fine . + */ + phy-reset-duration = <10>; phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; status = "okay"; -- 2.25.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D36C2B9F4 for ; Fri, 25 Jun 2021 12:15:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACC546162A for ; Fri, 25 Jun 2021 12:15:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACC546162A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cNt/8bKFOYC/xuteKRhWOB01H0ATYHiND2NDnbaTpdY=; b=vxKIXn/Eb5pqo1 XSD8cvm7bW/VSh2orlOAasY9lISAaLoKSZWMPf/61EGwd8dt8Pz8HCrB4a/5MZ0edCUrF5LmSOJI5 9i6QMMg1hPM0Z+6LV8O9nPAa6ILt8cEx4dGDn4QSzEfHBJ6pZZhhIzduwPk7Clh+yrtL7s8AWEBV3 gzXM/Nr7j0TRkn5zgDSdF84bs7xmAaDxWGH+Gmdtms6HaoMvFV16dqB5v0PxdtgCdj7lyhNVe6BRu 7qqGzSJETi9tBjKiHzhpOjqD6HsZ7Te8MhqcSPbA2fqyrDon/Inj4Ry3Cg1fWm23HhLaH4yy37zPZ jFILDMXUPBIgVIpJrK9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwkik-001Pbm-Js; Fri, 25 Jun 2021 12:14:06 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwkig-001PbA-MZ for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 12:14:04 +0000 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 8348F40004; Fri, 25 Jun 2021 12:13:57 +0000 (UTC) From: Maxime Chevallier To: Russell King , Shawn Guo , Rob Herring , Andrew Lunn , thomas.petazzoni@bootlin.com, herve.codina@bootlin.com, devicetree@vger.kernel.org Cc: Maxime Chevallier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms Date: Fri, 25 Jun 2021 14:13:53 +0200 Message-Id: <20210625121353.3698240-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_051402_917064_B537DC87 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIEFSODAzeCBQSFkgdXNlZCBvbiB0aGlzIG1vZHVsZXMgc2VlbXMgdG8gcmVxdWlyZSB0aGUg cmVzZXQgbGluZSB0bwpiZSBhc3NlcnRlZCBmb3IgYXJvdW5kIDEwbXMgaW4gb3JkZXIgdG8gYXZv aWQgcmFyZSBjYXNlcyB3aGVyZSB0aGUgUEhZCmdldHMgc3R1Y2sgaW4gYW4gaW5jb2hlcmVudCBz dGF0ZSB0aGF0IHByZXZlbnRzIGl0IHRvIGZ1bmN0aW9uCmNvcnJlY3RseS4KClRoZSBwcmV2aW91 cyB2YWx1ZSBvZiAybXMgd2FzIGZvdW5kIHRvIGJlIHByb2JsZW1hdGljIG9uIHNvbWUgc2V0dXBz LApjYXVzaW5nIGludGVybWl0dGVudCBpc3N1ZXMgd2hlcmUgdGhlIFBIWSB3b3VsZCBiZSB1bnJl c3BvbnNpdmUKZXZlcnkgb25jZSBpbiBhIHdoaWxlIG9uIHNvbWUgc3l0ZW1zLCB3aXRoIGEgbG93 IG9jY3VycmVuY2UgKGl0IHR5cGljYWxseQp0b29rIGFyb3VuZCAzMCBjb25zZWN1dGl2ZSByZWJv b3RzIHRvIGVuY291bnRlciB0aGUgaXNzdWUpLgoKQnVtcGluZyB0aGUgZGVsYXkgdG8gdGhlIDEw bXMgbWFrZXMgdGhlIGlzc3VlIGRpc3NhcGVhciwgd2l0aCBtb3JlIHRoYW4KMjUwMCBjb25zZWN1 dGl2ZSByZWJvb3RzIHBlcmZvcm1lZCB3aXRob3V0IHRoZSBpc3N1ZSBzaG93aW5nLXVwLgoKRml4 ZXM6IDIwOGQ3YmFmODA4NSAoIkFSTTogaW14OiBpbml0aWFsIFNvbGlkUnVuIEh1bW1pbmdCb2Fy ZCBzdXBwb3J0IikKU2lnbmVkLW9mZi1ieTogTWF4aW1lIENoZXZhbGxpZXIgPG1heGltZS5jaGV2 YWxsaWVyQGJvb3RsaW4uY29tPgpUZXN0ZWQtYnk6IEhlcnbDqSBDb2RpbmEgPGhlcnZlLmNvZGlu YUBib290bGluLmNvbT4KLS0tClRoaXMgVjIgd2FzIHF1aWNrbHkgcmVzZW50LCBzaW5jZSB0aGUg Y29tbWl0LWxvZyB3YXMgaW5jb3JyZWN0LgoKdjIgOiBSZXdvcmRlZCB0aGUgY29tbWl0LWxvZyB0 byByZW1vdmUgYW4gaW5jb3JyZWN0IG1lbnRpb24gb2YgdGhlCmRhdGFzaGVldC4gQWRkIGEgY29t bWVudCB0byB0aGUgRFQgdG8gZXhwbGljaXRseSBleHBsYWluIHRoZSBpc3N1ZS4KCiBhcmNoL2Fy bS9ib290L2R0cy9pbXg2cWRsLXNyLXNvbS5kdHNpIHwgOCArKysrKysrLQogMSBmaWxlIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJt L2Jvb3QvZHRzL2lteDZxZGwtc3Itc29tLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9pbXg2cWRs LXNyLXNvbS5kdHNpCmluZGV4IDBhZDhjY2RlMGNmOC4uZjg2ZWZkMGNjYzQwIDEwMDY0NAotLS0g YS9hcmNoL2FybS9ib290L2R0cy9pbXg2cWRsLXNyLXNvbS5kdHNpCisrKyBiL2FyY2gvYXJtL2Jv b3QvZHRzL2lteDZxZGwtc3Itc29tLmR0c2kKQEAgLTU0LDcgKzU0LDEzIEBAICZmZWMgewogCXBp bmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7CiAJcGluY3RybC0wID0gPCZwaW5jdHJsX21pY3Jvc29t X2VuZXRfYXI4MDM1PjsKIAlwaHktbW9kZSA9ICJyZ21paS1pZCI7Ci0JcGh5LXJlc2V0LWR1cmF0 aW9uID0gPDI+OworCisJLyoKKwkgKiBUaGUgUEhZIHNlZW1zIHRvIHJlcXVpcmUgYSBsb25nLWVu b3VnaCByZXNldCBkdXJhdGlvbiB0byBhdm9pZAorCSAqIHNvbWUgcmFyZSBpc3N1ZXMgd2hlcmUg dGhlIFBIWSBnZXRzIHN0dWNrIGluIGFuIGluY29uc2lzdGVudCBhbmQKKwkgKiBub24tZnVuY3Rp b25hbCBzdGF0ZSBhdCBib290LXVwLiAxMG1zIHByb3ZlZCB0byBiZSBmaW5lIC4KKwkgKi8KKwlw aHktcmVzZXQtZHVyYXRpb24gPSA8MTA+OwogCXBoeS1yZXNldC1ncGlvcyA9IDwmZ3BpbzQgMTUg R1BJT19BQ1RJVkVfTE9XPjsKIAlzdGF0dXMgPSAib2theSI7CiAKLS0gCjIuMjUuNAoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK