From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72261C2B9F4 for ; Fri, 25 Jun 2021 12:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E57E61458 for ; Fri, 25 Jun 2021 12:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbhFYMb5 (ORCPT ); Fri, 25 Jun 2021 08:31:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231273AbhFYMbo (ORCPT ); Fri, 25 Jun 2021 08:31:44 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF8BC061574; Fri, 25 Jun 2021 05:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sz0HFy97Sa2PQlVcns192PnKYImMp6PXF6QClznrDck=; b=b+RwXfLs/rhAp4aY2Yvho2UYh luH0JJMHXYuV8C+3Cc1/n3catAqX99bs1kmRHn32KOUwPttIV1B+kBTCkaZJjmrPD9+oQKB4EQJSQ zEpk1iEptToEkIHAf7+e2iH2G9QCFabjjBe9x7bmxgdkzn2rRbpVmH34ByaxZEH+B9+cQ4DNr07t+ KbPThT0j70AIka2yJ6PIBdzdKv3WZNSGbq5X/f5H4XxJb3l7Qk5y/hVxcRahKxAucx9FDoXHzEPnj IlHWtghAB9Wd+DLa3PJjdYLdoRR/4rI68V/HJ/gn07YoUOmDd2oL5XcFOMmJYRBuAwuqUtTZeU8I9 edjy7OVqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45348) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwkxR-0000hV-Pn; Fri, 25 Jun 2021 13:29:17 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lwkxR-0006fu-A3; Fri, 25 Jun 2021 13:29:17 +0100 Date: Fri, 25 Jun 2021 13:29:17 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: Shawn Guo , Rob Herring , Andrew Lunn , thomas.petazzoni@bootlin.com, herve.codina@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms Message-ID: <20210625122917.GW22278@shell.armlinux.org.uk> References: <20210625121353.3698240-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210625121353.3698240-1-maxime.chevallier@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 25, 2021 at 02:13:53PM +0200, Maxime Chevallier wrote: > The AR803x PHY used on this modules seems to require the reset line to > be asserted for around 10ms in order to avoid rare cases where the PHY > gets stuck in an incoherent state that prevents it to function > correctly. > > The previous value of 2ms was found to be problematic on some setups, > causing intermittent issues where the PHY would be unresponsive > every once in a while on some sytems, with a low occurrence (it typically > took around 30 consecutive reboots to encounter the issue). > > Bumping the delay to the 10ms makes the issue dissapear, with more than > 2500 consecutive reboots performed without the issue showing-up. > > Fixes: 208d7baf8085 ("ARM: imx: initial SolidRun HummingBoard support") > Signed-off-by: Maxime Chevallier > Tested-by: Hervé Codina Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97F8BC2B9F4 for ; Fri, 25 Jun 2021 12:31:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66063616ED for ; Fri, 25 Jun 2021 12:31:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66063616ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ec1yK7Q+Q+nTblE1WUHvF0naQvomqP2dJudPJ579jP0=; b=s7joS0URnvWAqB jIv/thxf/5TOwF345gVvkjidFOykDF1l1Inq0qh142kZE4bbmyjLCNrEq1g53ra6rW7ilHRKXfmBe 74Nh7QxVoA55eiNNk5zcN9vRL+iEPba5A4JfX0N/7NO/WuFn/j+h2U4/CYmNu4o6F2EqZQyd7oHNq pfqaI5mt/6g/a91sTwFnn7xuTXM68Df/7eU1MKWyLe9M3R0flXbgz2zmGMDtNPWpNRxTLiJir9u7Q 54Ahpy46TQuC9PNRoMmtpjRDREikENAFtaOX2guCvzLdh96FQ6lvRNcUb/KZBW+maXyacpHk04qgO JDlcQlR++jwR7IEi9KFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwkxr-001RV3-EI; Fri, 25 Jun 2021 12:29:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwkxX-001RNg-2A for linux-arm-kernel@lists.infradead.org; Fri, 25 Jun 2021 12:29:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sz0HFy97Sa2PQlVcns192PnKYImMp6PXF6QClznrDck=; b=b+RwXfLs/rhAp4aY2Yvho2UYh luH0JJMHXYuV8C+3Cc1/n3catAqX99bs1kmRHn32KOUwPttIV1B+kBTCkaZJjmrPD9+oQKB4EQJSQ zEpk1iEptToEkIHAf7+e2iH2G9QCFabjjBe9x7bmxgdkzn2rRbpVmH34ByaxZEH+B9+cQ4DNr07t+ KbPThT0j70AIka2yJ6PIBdzdKv3WZNSGbq5X/f5H4XxJb3l7Qk5y/hVxcRahKxAucx9FDoXHzEPnj IlHWtghAB9Wd+DLa3PJjdYLdoRR/4rI68V/HJ/gn07YoUOmDd2oL5XcFOMmJYRBuAwuqUtTZeU8I9 edjy7OVqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45348) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwkxR-0000hV-Pn; Fri, 25 Jun 2021 13:29:17 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lwkxR-0006fu-A3; Fri, 25 Jun 2021 13:29:17 +0100 Date: Fri, 25 Jun 2021 13:29:17 +0100 From: "Russell King (Oracle)" To: Maxime Chevallier Cc: Shawn Guo , Rob Herring , Andrew Lunn , thomas.petazzoni@bootlin.com, herve.codina@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: dts: imx6qdl-sr-som: Increase the PHY reset duration to 10ms Message-ID: <20210625122917.GW22278@shell.armlinux.org.uk> References: <20210625121353.3698240-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210625121353.3698240-1-maxime.chevallier@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210625_052923_173828_824C6847 X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 25, 2021 at 02:13:53PM +0200, Maxime Chevallier wrote: > The AR803x PHY used on this modules seems to require the reset line to > be asserted for around 10ms in order to avoid rare cases where the PHY > gets stuck in an incoherent state that prevents it to function > correctly. > = > The previous value of 2ms was found to be problematic on some setups, > causing intermittent issues where the PHY would be unresponsive > every once in a while on some sytems, with a low occurrence (it typically > took around 30 consecutive reboots to encounter the issue). > = > Bumping the delay to the 10ms makes the issue dissapear, with more than > 2500 consecutive reboots performed without the issue showing-up. > = > Fixes: 208d7baf8085 ("ARM: imx: initial SolidRun HummingBoard support") > Signed-off-by: Maxime Chevallier > Tested-by: Herv=E9 Codina Reviewed-by: Russell King (Oracle) Thanks! -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel