From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779B2C2B9F4 for ; Fri, 25 Jun 2021 18:49:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA6D76195D for ; Fri, 25 Jun 2021 18:49:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA6D76195D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwqtg-0008AF-TE for qemu-devel@archiver.kernel.org; Fri, 25 Jun 2021 14:49:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwqrz-0007HF-AD; Fri, 25 Jun 2021 14:48:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:57754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwqrx-0005I3-5U; Fri, 25 Jun 2021 14:48:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DCDC6195B; Fri, 25 Jun 2021 18:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624646878; bh=1GAl91k8Nz7S9PSzdpiH94qMrBLWb3A3bueTaOpDgQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NZrMOMrEMtPqmTinY8ls8gN/qE1Z5aNb64r+WuS7u9JQb9GZ+yJhP7xgmn5iQsNXR +vTprjlc8Dd17mHrtTCrDS8GjvKGKy1fVUIQAVYR9Wbvpdoa35vySHHWkzekHnjG/B 86sopTezUvp4Ob3s3UZTmSwIIeTTdLGo6eBtw04zwPg3JFPRtD5iUsscpgKWAMpjvM V+U/hH/hDMDQFPbLCuFRpCLqOxYXrWvNnRicUE++TrXSZ26waPewxT7N5+3jKRbu5n 2FdfHPk2CMaEGkvGRgTEy+QZJcdQx3ISGbO8PfxdvZ2bpOTtkrX1IT9G0fhwSIygUl 2gS5zDDYFwawg== Date: Fri, 25 Jun 2021 11:47:55 -0700 From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH v2 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs Message-ID: <20210625184755.GB2818622@dhcp-10-100-145-180.wdc.com> References: <20210617190657.110823-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617190657.110823-1-its@irrelevant.dk> Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-Spam_score_int: -74 X-Spam_score: -7.5 X-Spam_bar: ------- X-Spam_report: (-7.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.362, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 17, 2021 at 09:06:46PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > This series reimplements flush, dsm, copy, zone reset and format nvm to > allow cancellation. I posted an RFC back in March ("hw/block/nvme: > convert ad-hoc aio tracking to aiocb") and I've applied some feedback > from Stefan and reimplemented the remaining commands. > > The basic idea is to define custom AIOCBs for these commands. The custom > AIOCB takes care of issuing all the "nested" AIOs one by one instead of > blindly sending them off simultaneously without tracking the returned > aiocbs. Klaus, THis series looks good to me. Reviewed-by: Keith Busch