From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3BFC49EA5 for ; Sat, 26 Jun 2021 06:55:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C57FB6193B for ; Sat, 26 Jun 2021 06:55:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C57FB6193B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lx2Dc-00032t-Ql for qemu-devel@archiver.kernel.org; Sat, 26 Jun 2021 02:55:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lx1vu-0002PP-Hs for qemu-devel@nongnu.org; Sat, 26 Jun 2021 02:36:50 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:38632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lx1vr-0000R1-NV for qemu-devel@nongnu.org; Sat, 26 Jun 2021 02:36:50 -0400 Received: by mail-pj1-x102c.google.com with SMTP id t19-20020a17090ae513b029016f66a73701so9274481pjy.3 for ; Fri, 25 Jun 2021 23:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ziCUNw7iMfXxhXUy1AbaM+Ca/hJ3SGJZ/ldvQFuxiE8=; b=iT/rfKxEWy20qwBWIruZIHWnqbywN46mDcWVm2g3VgGNrDNSkUen/jpbVdRVa9qnpj kYXsdHXn9k8NaHG01sZibxXWHbT6sws7rFnXim8L4cw6Nq/kfb0bbzm9WBzt58BMEw5/ D4plVp+lhsMc6//+Y4DmMLrLGYGA+OkZ6XEnrob1KvQWgojPDkf+juVPYlFXha8xg/xQ vteZfVRFiz7kk5ZonYXLIxkBfLV3BFCrcz34yTHD3moGwbmynndnIt9ijI8bn4xbydiY tovtKpvY0R1O5RcL4e2aGH3Mg93dP7BDjnRYkOWuO1JJTIagLJriXqt0Qgn7N7Wn0QZZ Da+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ziCUNw7iMfXxhXUy1AbaM+Ca/hJ3SGJZ/ldvQFuxiE8=; b=tWWSyLH8VGVZ14mFXhAxu3aRgmpnW7X9liFWM5tDUUqK+28ldtRkLgCwc3JxgLwfb2 fcdLYCQgztr1FytMNwduPmpJKcVG/1qy5gddeaJxLX21cjeUyRbI3fLtKaXJ6lA+EBvH PacNvRfVjiTU76NE9z8a7zWurOCCMec+NhRfGLLmxvSebyVFfXRELSmilEKELZGNWeIB /siRr95lTImBP5NU5hB5RaGCsbiiCCOAHg5LURc1B/sXJ9M5i89NuhVLxjqCUwS1k2SO Q3EE4kJfB03Gfmg6rymc0qLN6AJ2lgemrjN85bRyIechflHbseilfJQDcq9Dco2SvAmK l3UQ== X-Gm-Message-State: AOAM531K1z8+qxb1uy/JqE0pjY7ewXR/Y6WO2q+9Fs83ygSP6dVnmSZE D6pWmi/Kha9iIPs+9hwDeYRMJvLBAdCy7A== X-Google-Smtp-Source: ABdhPJxoivzzPqmeGA1u1eObLf2hELVJV6YXCdKJ32vfix1a/vwj7Nxi8GFjFCTT+t4ah84o4SvUIA== X-Received: by 2002:a17:90a:c8b:: with SMTP id v11mr24609762pja.114.1624689406426; Fri, 25 Jun 2021 23:36:46 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id v9sm7724201pgq.54.2021.06.25.23.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 23:36:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 23/29] target/arm: Improve REVSH Date: Fri, 25 Jun 2021 23:36:25 -0700 Message-Id: <20210626063631.2411938-24-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210626063631.2411938-1-richard.henderson@linaro.org> References: <20210626063631.2411938-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The new bswap flags can implement the semantics exactly. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 669b0be578..a0c6cfa902 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -354,9 +354,7 @@ void gen_rev16(TCGv_i32 dest, TCGv_i32 var) /* Byteswap low halfword and sign extend. */ static void gen_revsh(TCGv_i32 dest, TCGv_i32 var) { - tcg_gen_ext16u_i32(var, var); - tcg_gen_bswap16_i32(var, var, TCG_BSWAP_IZ | TCG_BSWAP_OZ); - tcg_gen_ext16s_i32(dest, var); + tcg_gen_bswap16_i32(var, var, TCG_BSWAP_OS); } /* Dual 16-bit add. Result placed in t0 and t1 is marked as dead. -- 2.25.1