* [PATCH] mac80211: Reject zero MAC address in sta_info_insert_check()
@ 2021-06-26 10:38 YueHaibing
2021-06-26 10:48 ` YueHaibing
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2021-06-26 10:38 UTC (permalink / raw)
To: johannes, davem, kuba, periyasa
Cc: linux-wireless, netdev, linux-kernel, YueHaibing
As commit 52dba8d7d5ab ("mac80211: reject zero MAC address in add station")
said, we don't consider all-zeroes to be a valid MAC address in most places,
so also reject it here.
Reported-by: syzbot+ef4ca92d9d6f5ba2f880@syzkaller.appspotmail.com
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/mac80211/sta_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index f2fb69da9b6e..3a6887fc9160 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -547,7 +547,7 @@ static int sta_info_insert_check(struct sta_info *sta)
return -ENETDOWN;
if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) ||
- is_multicast_ether_addr(sta->sta.addr)))
+ is_valid_ether_addr(sta->sta.addr)))
return -EINVAL;
/* The RCU read lock is required by rhashtable due to
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: Reject zero MAC address in sta_info_insert_check()
2021-06-26 10:38 [PATCH] mac80211: Reject zero MAC address in sta_info_insert_check() YueHaibing
@ 2021-06-26 10:48 ` YueHaibing
0 siblings, 0 replies; 2+ messages in thread
From: YueHaibing @ 2021-06-26 10:48 UTC (permalink / raw)
To: johannes, davem, kuba, periyasa; +Cc: linux-wireless, netdev, linux-kernel
Pls drop this.
On 2021/6/26 18:38, YueHaibing wrote:
> As commit 52dba8d7d5ab ("mac80211: reject zero MAC address in add station")
> said, we don't consider all-zeroes to be a valid MAC address in most places,
> so also reject it here.
>
> Reported-by: syzbot+ef4ca92d9d6f5ba2f880@syzkaller.appspotmail.com
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> net/mac80211/sta_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index f2fb69da9b6e..3a6887fc9160 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -547,7 +547,7 @@ static int sta_info_insert_check(struct sta_info *sta)
> return -ENETDOWN;
>
> if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) ||
> - is_multicast_ether_addr(sta->sta.addr)))
> + is_valid_ether_addr(sta->sta.addr)))
> return -EINVAL;
>
> /* The RCU read lock is required by rhashtable due to
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-26 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-26 10:38 [PATCH] mac80211: Reject zero MAC address in sta_info_insert_check() YueHaibing
2021-06-26 10:48 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.