From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1068C2B9F4 for ; Mon, 28 Jun 2021 07:20:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58B6661926 for ; Mon, 28 Jun 2021 07:20:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58B6661926 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E9AF82D1C; Mon, 28 Jun 2021 09:20:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="RSH+emVA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42C9B82D80; Mon, 28 Jun 2021 09:20:56 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5AAC982D1C for ; Mon, 28 Jun 2021 09:20:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id B405361464; Mon, 28 Jun 2021 07:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624864851; bh=VRzo2c7yjZu8WOtu2npi6SqQsPxGgrJdJjB5FaBZRlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RSH+emVAYE8ANhnURL1RY0fri7h0hY+vJ0Y6EliJ1xvUPQJaZczKKYQYzFGlE/OP2 V0Mu6jfF+Ywz+M2lgHbQclupQee+1YeWqYYrOVYiIZYRmu1UfbyoFz7I//xWSgNzZq Q3nLV9uE9VZEZ1IJMTRPpYzuWHck3B+qYUjg2r8fwD71YKusCGfZ8cIyxvUWE7F64T ljh8ofNEmMyh4XYb0NaG5qAfinOiNRh1NFB8N/0fJOwKUffbLO4x7giVVvlsi4KpHH yWLfPYFXZ9SSg6CSahEgRAa2Dp+P57WOEbN8IOaG3dKpgqv5tPBdcRDKzQVWAME5qE tsHQ5M1ntN9sA== Received: by pali.im (Postfix) id 096A970A; Mon, 28 Jun 2021 09:20:48 +0200 (CEST) Date: Mon, 28 Jun 2021 09:20:48 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Chris Packham Cc: Marek Behun , "u-boot@lists.denx.de" , Chris Packham , Stefan Roese , Baruch Siach , motib Subject: Re: [PATCH u-boot-marvell] PLEASE TEST ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision Message-ID: <20210628072048.dgi7jqrknvsw5mdk@pali> References: <20210208191225.14645-1-marek.behun@nic.cz> <20210208201534.717a610a@nic.cz> <20210208212409.52a584a3@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210208212409.52a584a3@nic.cz> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Monday 08 February 2021 21:24:09 Marek Behun wrote: > On Mon, 8 Feb 2021 20:14:26 +0000 > Chris Packham wrote: > > > On 9/02/21 8:15 am, Marek Behun wrote: > > > This patch is needed on some Turris Omnia boards with Samsung DDR chips, > > > otherwise DDR training fails in ~60% of cases. > > > > > > Marvell send us this patch for testing, I have updated it a little. > > > > > > Please test this on other A38x boards. > > > > > > If it doesn't break anything on other boards, we can apply it and send > > > it to mv-ddr-marvell upstream. > > They gave us the same patch. I was hoping their SoC team would get it > > into mv-ddr-marvell (or even their vendor USP) but obviously they're > > still sitting on it. I know it improved matters for some of our boards > > but it didn't totally fix them we still had yield problems when we > > ramped up production. > > There is a bug in the version they sent us: > > in file ddr3_training_ip_engine.c there is a line added: > if ((bit_bit_mask[sybphy_id] & (1 << bit_id)) == 1) > > try chaning it to > if (bit_bit_mask[sybphy_id] & (1 << bit_id)) > > This is fixed in the version I sent to mailing list Hello Chris! Have you tried above modification if it fixes your issue?