From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9ABC2B9F4 for ; Mon, 28 Jun 2021 12:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6911B61993 for ; Mon, 28 Jun 2021 12:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233034AbhF1Mgw (ORCPT ); Mon, 28 Jun 2021 08:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233022AbhF1Mgo (ORCPT ); Mon, 28 Jun 2021 08:36:44 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47702C061760 for ; Mon, 28 Jun 2021 05:34:17 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id p8so4966679wrr.1 for ; Mon, 28 Jun 2021 05:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g4Piownw0Km7jYaWnqnZYrht6sXkD+M9EE5R9haJeqU=; b=RpmUcAWPAA24cki8FV8sIiR/T9iEYHriC0yCwfOOTb4uqcPcCoDIl5um61M0Q3JNhd HLRkEqXN2yGFQunfUq1oa3qpnJK4tA757J1lFxhMtcrYkTYFQ78IouFy8QcTrkoarB1i m5LRW4Lse26c2JMoWyM41aE6S4UknpZ0ergRk+TbCkxVBPppNAjf8B+FLYj7YdA/jhWc j59ruiM34M3XMVVDTLJ3Y46Fwh1xS5SvblR5JFnfoSUspQxn3dS7du34oa2vKwdAXyLQ gOxFT0cQnap+TR5FDfLeVOi0G6tEQf88cYFZTES+gIgRw9FyNgUM6PSUae1XYBBudQXb Fe4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g4Piownw0Km7jYaWnqnZYrht6sXkD+M9EE5R9haJeqU=; b=Mf2oN5kzHm5kcwytu4WzSuGkQ8ayYZghhiQuheS45r6bEKA1W1eCRAq6yDdbmUesUa W+AMbrGnk8WZ44SnzTsdMGB80RNnQJ/sGsvMx0np4zGIE9uujnSYFtQ/3mRhQStZTop0 oIvxJNQbt7cTM80T8CJoUCgBXDk2XHh1iy8lAJ40n3gmhFEC4YOFqKiR8yFcjStikJ+O IS59pnLrdPLx4a++0WG6ltXlvFv1jKibuW2clachQizi/VMgIfyq78MEgh68zjCI6rZ3 LvypDLq3njjhKo/dZb4wVldQbt/5NcPDF16iiBzDAcynlkmTWnwT7qwSFzF1xWMfnbmX nI5A== X-Gm-Message-State: AOAM531mAy4o7mOlD9p5BCubDWd/dc3wXLEjNC4klJGhH00qEwBD1Qk4 PH8ni1XXRWlagYzqtsqv1JhSlg== X-Google-Smtp-Source: ABdhPJynXZUsQ+KCCA2PMCmxfxH2qhUAPGDL5BW7LSSONysZPkBA8RYkV5kdJNx/yJHplx94ajGkIw== X-Received: by 2002:adf:fac4:: with SMTP id a4mr27567032wrs.189.1624883655814; Mon, 28 Jun 2021 05:34:15 -0700 (PDT) Received: from localhost.localdomain ([2001:861:44c0:66c0:e503:e76:4043:c4f7]) by smtp.gmail.com with ESMTPSA id p7sm2357334wrr.68.2021.06.28.05.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:34:15 -0700 (PDT) From: Neil Armstrong To: jgg@ziepe.ca, leon@kernel.org, m.szyprowski@samsung.com, robin.murphy@arm.com, ulf.hansson@linaro.org Cc: torvalds@linux-foundation.org, khilman@baylibre.com, jbrunet@baylibre.com, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: [PATCH RFC 0/2] scatterlist: add I/O variant of sg_pcopy & sg_copy and use them Date: Mon, 28 Jun 2021 14:34:09 +0200 Message-Id: <20210628123411.119778-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=976; h=from:subject; bh=iVEMvBLaRZgih5yGs1nmMY9KLw8WXAeUJcp1bYFUiBY=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBg2cGWtsGJ0XA8KWFoXtdBdbBZY/Eo9DjS/KkXuTzv 5/+iniKJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCYNnBlgAKCRB33NvayMhJ0XPhEA CcU6sOzBX3jxArz37tuZhTke4Yg6dNMPnsx19qObWnWEpWCFEdEzrPxjZH8d2shIfumiocFQt1tlQf NrsBokdpyV2jvNOgHBTsDGYfqBlxKE4tMytf5ooHTErzX9XraDT1cXZKBKAEcYiti/49Hgsd7NQQ3N NGEY0fI8LIpEFotO67MZ7zO9zjqqDnBqQYBpmCAW207JExawMCmAeWUfuV7lJhXqut5nX57hV3Ia6i IKu0l5t319rVU+tLJI7zcVEAZDP63rBK/GCAy4AdY/a2KzZHvjKYFh2MXwoFIx74Xdgzn+mp+pZHQ5 Gy1CZOHdaA7Nd9apmUfVxGq49AkH4GglixwfZC/U1n59sOfZvt3SvEi7LYBDDiORE9+mHr8Eo0DiW4 pGSEU7giItN3JyECFLqjnJt+wQJXZlQYn+nvJtaWz+O00wIA7vKQPl8PbNZGvQEIDdwJyRUdqXjvca +SHOa5/6FnOYt74n+VwOeiXbMXnFCW3mpbR8jdOyRd+oz+VQIE3J82S296md6xTQEe0oQ98nnQ2PUC SsxUoFHiBZyHwoAVVdgtAe+KtcJLSgvOkGmfK4ylJpCH6wxWeZmuecrNTghwCp8Q/x3fZ2Wyf8ogMG IM9QL/KQH/1DL1WHS0A8gqMFvLbjg1m3Xj1DnhnkZvfDbY4d8/Pn5cLa7LpQ== X-Developer-Key: i=narmstrong@baylibre.com; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A local variant of sg_copy_buffer has been introduced in the meson-gx mmc driver [1] after a mempcy optimization, fixing the iomem buffer manipulation and the reported system crash [2]. But, the fix is suboptimal in terms of performace/ugliness [3] and a proper I/O variant of sg_copy_buffer should be added and used instead. [1] https://lore.kernel.org/r/20210609150230.9291-1-narmstrong@baylibre.com [2] https://lore.kernel.org/r/acb244ad-0759-5a96-c659-5c23003d3dcd@samsung.com [3] https://lore.kernel.org/r/CAPDyKFrLSMpPJOgd5e4B1x3Vwfg4q23zgy4ESc8EmFL2MnyK7g@mail.gmail.com Neil Armstrong (2): scatterlist: add I/O variant of sg_pcopy & sg_copy mmc: meson-gx: use sg_copy_to/from_io instead of local version drivers/mmc/host/meson-gx-mmc.c | 53 +++----------- include/linux/scatterlist.h | 14 ++++ lib/scatterlist.c | 119 ++++++++++++++++++++++++++++++++ 3 files changed, 143 insertions(+), 43 deletions(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E285DC2B9F4 for ; Mon, 28 Jun 2021 12:36:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADDCE61993 for ; Mon, 28 Jun 2021 12:36:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADDCE61993 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ehCALHM5vJtyuF+mWdv3QxpEBmT64e1wV2OJn/4hxCM=; b=RrEQCtX8cLiyf4 wijgxHIf+s7+n0FT2uBUXadyr1nnPETgLO/wem9zpAmCcijDEKwO2GNaBHcwtwPWu9iK7nKrnx4iI uZf/RLVrdJnCHFqqM3Cq4HMzfcqPn15m8NvZ32MWac2IHlGuFGf0r/VFwf7hMtwsMdZGhpwOUg3/n 2l787ekf8JDPTkwc2PiemAzWp0urgWaOvKFeEqEDphrcjUb3khGeG0uI/f3yTL30KKMVGocVVxNYV Cnmdo26NQLo2H59kl6ZlwTrulGtRlDsFplgBkpjnYeUo5T/1dRiPcA3mKqDpp+Jq++T8/gTnZtSt2 4HGVDHxKeEVBqmIy0fRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxqT3-007z20-Cm; Mon, 28 Jun 2021 12:34:25 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxqSw-007yyp-FE for linux-arm-kernel@lists.infradead.org; Mon, 28 Jun 2021 12:34:20 +0000 Received: by mail-wr1-x430.google.com with SMTP id j1so21040099wrn.9 for ; Mon, 28 Jun 2021 05:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g4Piownw0Km7jYaWnqnZYrht6sXkD+M9EE5R9haJeqU=; b=RpmUcAWPAA24cki8FV8sIiR/T9iEYHriC0yCwfOOTb4uqcPcCoDIl5um61M0Q3JNhd HLRkEqXN2yGFQunfUq1oa3qpnJK4tA757J1lFxhMtcrYkTYFQ78IouFy8QcTrkoarB1i m5LRW4Lse26c2JMoWyM41aE6S4UknpZ0ergRk+TbCkxVBPppNAjf8B+FLYj7YdA/jhWc j59ruiM34M3XMVVDTLJ3Y46Fwh1xS5SvblR5JFnfoSUspQxn3dS7du34oa2vKwdAXyLQ gOxFT0cQnap+TR5FDfLeVOi0G6tEQf88cYFZTES+gIgRw9FyNgUM6PSUae1XYBBudQXb Fe4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g4Piownw0Km7jYaWnqnZYrht6sXkD+M9EE5R9haJeqU=; b=b0w3j0otHI8xvReJLCzHxOztOtJAQMgqlP7XzQlEdpoxbr+vdyYeriAgRWsWuMbyCo x/lQ7cxJyP3KxzAyvMEqHWD5cI3x9CEownlRTVFG/40tNbZ9vFohL6Sg26VkEr7E3I0S nhHRXuAwK5GU18Wlwg3/1nSlCb76x0GzHOEsyJjEQrFNqs5CfqE+7qgoRwVouJgvKtcC gbXjlRk7VxZ0OTHPXN/Aj403aa3TMZjZ4rJ+wuSc+L/2y8XDYFiZ9dl3pYzTEBgICkk0 HTppRCEUNG+vPzgMzjv9TWkddgEtBSlXJp8jX9lO/yhHWLgW6aFMcH9v/HCpGes4MDy5 X/0w== X-Gm-Message-State: AOAM530vP0djfbqgbw1m4PQNMrUzC8etEddq9Ak4Nm0O2MlUbLmdfybz eMTkgoALhXgr5dhRHeuVfnfTlA== X-Google-Smtp-Source: ABdhPJynXZUsQ+KCCA2PMCmxfxH2qhUAPGDL5BW7LSSONysZPkBA8RYkV5kdJNx/yJHplx94ajGkIw== X-Received: by 2002:adf:fac4:: with SMTP id a4mr27567032wrs.189.1624883655814; Mon, 28 Jun 2021 05:34:15 -0700 (PDT) Received: from localhost.localdomain ([2001:861:44c0:66c0:e503:e76:4043:c4f7]) by smtp.gmail.com with ESMTPSA id p7sm2357334wrr.68.2021.06.28.05.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:34:15 -0700 (PDT) From: Neil Armstrong To: jgg@ziepe.ca, leon@kernel.org, m.szyprowski@samsung.com, robin.murphy@arm.com, ulf.hansson@linaro.org Cc: torvalds@linux-foundation.org, khilman@baylibre.com, jbrunet@baylibre.com, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: [PATCH RFC 0/2] scatterlist: add I/O variant of sg_pcopy & sg_copy and use them Date: Mon, 28 Jun 2021 14:34:09 +0200 Message-Id: <20210628123411.119778-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=976; h=from:subject; bh=iVEMvBLaRZgih5yGs1nmMY9KLw8WXAeUJcp1bYFUiBY=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBg2cGWtsGJ0XA8KWFoXtdBdbBZY/Eo9DjS/KkXuTzv 5/+iniKJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCYNnBlgAKCRB33NvayMhJ0XPhEA CcU6sOzBX3jxArz37tuZhTke4Yg6dNMPnsx19qObWnWEpWCFEdEzrPxjZH8d2shIfumiocFQt1tlQf NrsBokdpyV2jvNOgHBTsDGYfqBlxKE4tMytf5ooHTErzX9XraDT1cXZKBKAEcYiti/49Hgsd7NQQ3N NGEY0fI8LIpEFotO67MZ7zO9zjqqDnBqQYBpmCAW207JExawMCmAeWUfuV7lJhXqut5nX57hV3Ia6i IKu0l5t319rVU+tLJI7zcVEAZDP63rBK/GCAy4AdY/a2KzZHvjKYFh2MXwoFIx74Xdgzn+mp+pZHQ5 Gy1CZOHdaA7Nd9apmUfVxGq49AkH4GglixwfZC/U1n59sOfZvt3SvEi7LYBDDiORE9+mHr8Eo0DiW4 pGSEU7giItN3JyECFLqjnJt+wQJXZlQYn+nvJtaWz+O00wIA7vKQPl8PbNZGvQEIDdwJyRUdqXjvca +SHOa5/6FnOYt74n+VwOeiXbMXnFCW3mpbR8jdOyRd+oz+VQIE3J82S296md6xTQEe0oQ98nnQ2PUC SsxUoFHiBZyHwoAVVdgtAe+KtcJLSgvOkGmfK4ylJpCH6wxWeZmuecrNTghwCp8Q/x3fZ2Wyf8ogMG IM9QL/KQH/1DL1WHS0A8gqMFvLbjg1m3Xj1DnhnkZvfDbY4d8/Pn5cLa7LpQ== X-Developer-Key: i=narmstrong@baylibre.com; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_053418_633166_857D0891 X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org A local variant of sg_copy_buffer has been introduced in the meson-gx mmc driver [1] after a mempcy optimization, fixing the iomem buffer manipulation and the reported system crash [2]. But, the fix is suboptimal in terms of performace/ugliness [3] and a proper I/O variant of sg_copy_buffer should be added and used instead. [1] https://lore.kernel.org/r/20210609150230.9291-1-narmstrong@baylibre.com [2] https://lore.kernel.org/r/acb244ad-0759-5a96-c659-5c23003d3dcd@samsung.com [3] https://lore.kernel.org/r/CAPDyKFrLSMpPJOgd5e4B1x3Vwfg4q23zgy4ESc8EmFL2MnyK7g@mail.gmail.com Neil Armstrong (2): scatterlist: add I/O variant of sg_pcopy & sg_copy mmc: meson-gx: use sg_copy_to/from_io instead of local version drivers/mmc/host/meson-gx-mmc.c | 53 +++----------- include/linux/scatterlist.h | 14 ++++ lib/scatterlist.c | 119 ++++++++++++++++++++++++++++++++ 3 files changed, 143 insertions(+), 43 deletions(-) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFD6C2B9F4 for ; Mon, 28 Jun 2021 12:34:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B0C961C71 for ; Mon, 28 Jun 2021 12:34:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B0C961C71 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Y3wIuuB79785Y75Z2ssjRj+F7yXXnksIBF/fdiJjCoI=; b=kvQYAGWyTX361P 4C570Gp6k2ge787rtXvqKEE6tgLXXSJnCWsojncNQ4ioIMiSrDx66cDgvfiUIWC+H4gyFdUTLmm7x xR9sUB3ivURZTVsxzgsXcRFYs5QMl4t0WbkPn60VFej5ZxgbU7d5vMfnBlBAfmnl0ly6TcUmvy2HH HAiug4iL3LRGlk5pdIlQn5Tgi02PRDVKivIs78CrDoXINCQycOnz5Z+v3Gk7/ytGKWhCBq56Jfivf rH3DVCwpaijAZ5ReMk20mQ9m0PhKgTJxiDe1vimtZDfZN09B+SRtuZRw3kpLc1N49sUcF7LT2cKG9 Hju5CIVPXdjicTDOIvgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxqTE-007z6k-TZ; Mon, 28 Jun 2021 12:34:36 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxqSw-007yyo-G1 for linux-amlogic@lists.infradead.org; Mon, 28 Jun 2021 12:34:22 +0000 Received: by mail-wr1-x435.google.com with SMTP id a13so21052923wrf.10 for ; Mon, 28 Jun 2021 05:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g4Piownw0Km7jYaWnqnZYrht6sXkD+M9EE5R9haJeqU=; b=RpmUcAWPAA24cki8FV8sIiR/T9iEYHriC0yCwfOOTb4uqcPcCoDIl5um61M0Q3JNhd HLRkEqXN2yGFQunfUq1oa3qpnJK4tA757J1lFxhMtcrYkTYFQ78IouFy8QcTrkoarB1i m5LRW4Lse26c2JMoWyM41aE6S4UknpZ0ergRk+TbCkxVBPppNAjf8B+FLYj7YdA/jhWc j59ruiM34M3XMVVDTLJ3Y46Fwh1xS5SvblR5JFnfoSUspQxn3dS7du34oa2vKwdAXyLQ gOxFT0cQnap+TR5FDfLeVOi0G6tEQf88cYFZTES+gIgRw9FyNgUM6PSUae1XYBBudQXb Fe4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g4Piownw0Km7jYaWnqnZYrht6sXkD+M9EE5R9haJeqU=; b=EAZNEudsgoaS9gkHJCMDGzRpNjAwI4raGHUtSs8HofLBXRMG2OUh3SLz/XKP2fkPY4 ahlUxtmOBOFZM2SxN7pL/364pVmAR3MRbTXUK/zkvaNuA03H1XL2wPqclsNItM47ZUAw N5YX85uYFjCmZ1WUzqa8PRh63Tj0ph5kdRnERovdiDJCBK2ldp6deEafn3vJIKTfiD/s 1n93wiepX9P3h64z9KjgNmj8nuunfWYheUKTeOzl/mgyqmfgP1GbLHUo6mVdUYUw80QM N4nL7r1k+JQmgyq/rEULQ2Q5qcmbUtW0bqkWkNMtLramJtSfGK8MzOqLXIHha7brqcpP siIg== X-Gm-Message-State: AOAM532QHFHzBhNhARX0eX77Y1pjRT4w4KtpqCaI/hDkQsJolwEVuODs WwHvVaBdeTUBYNh3H+ETTPqsZw== X-Google-Smtp-Source: ABdhPJynXZUsQ+KCCA2PMCmxfxH2qhUAPGDL5BW7LSSONysZPkBA8RYkV5kdJNx/yJHplx94ajGkIw== X-Received: by 2002:adf:fac4:: with SMTP id a4mr27567032wrs.189.1624883655814; Mon, 28 Jun 2021 05:34:15 -0700 (PDT) Received: from localhost.localdomain ([2001:861:44c0:66c0:e503:e76:4043:c4f7]) by smtp.gmail.com with ESMTPSA id p7sm2357334wrr.68.2021.06.28.05.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:34:15 -0700 (PDT) From: Neil Armstrong To: jgg@ziepe.ca, leon@kernel.org, m.szyprowski@samsung.com, robin.murphy@arm.com, ulf.hansson@linaro.org Cc: torvalds@linux-foundation.org, khilman@baylibre.com, jbrunet@baylibre.com, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: [PATCH RFC 0/2] scatterlist: add I/O variant of sg_pcopy & sg_copy and use them Date: Mon, 28 Jun 2021 14:34:09 +0200 Message-Id: <20210628123411.119778-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=976; h=from:subject; bh=iVEMvBLaRZgih5yGs1nmMY9KLw8WXAeUJcp1bYFUiBY=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBg2cGWtsGJ0XA8KWFoXtdBdbBZY/Eo9DjS/KkXuTzv 5/+iniKJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCYNnBlgAKCRB33NvayMhJ0XPhEA CcU6sOzBX3jxArz37tuZhTke4Yg6dNMPnsx19qObWnWEpWCFEdEzrPxjZH8d2shIfumiocFQt1tlQf NrsBokdpyV2jvNOgHBTsDGYfqBlxKE4tMytf5ooHTErzX9XraDT1cXZKBKAEcYiti/49Hgsd7NQQ3N NGEY0fI8LIpEFotO67MZ7zO9zjqqDnBqQYBpmCAW207JExawMCmAeWUfuV7lJhXqut5nX57hV3Ia6i IKu0l5t319rVU+tLJI7zcVEAZDP63rBK/GCAy4AdY/a2KzZHvjKYFh2MXwoFIx74Xdgzn+mp+pZHQ5 Gy1CZOHdaA7Nd9apmUfVxGq49AkH4GglixwfZC/U1n59sOfZvt3SvEi7LYBDDiORE9+mHr8Eo0DiW4 pGSEU7giItN3JyECFLqjnJt+wQJXZlQYn+nvJtaWz+O00wIA7vKQPl8PbNZGvQEIDdwJyRUdqXjvca +SHOa5/6FnOYt74n+VwOeiXbMXnFCW3mpbR8jdOyRd+oz+VQIE3J82S296md6xTQEe0oQ98nnQ2PUC SsxUoFHiBZyHwoAVVdgtAe+KtcJLSgvOkGmfK4ylJpCH6wxWeZmuecrNTghwCp8Q/x3fZ2Wyf8ogMG IM9QL/KQH/1DL1WHS0A8gqMFvLbjg1m3Xj1DnhnkZvfDbY4d8/Pn5cLa7LpQ== X-Developer-Key: i=narmstrong@baylibre.com; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_053418_632876_CC4F0895 X-CRM114-Status: UNSURE ( 8.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org A local variant of sg_copy_buffer has been introduced in the meson-gx mmc driver [1] after a mempcy optimization, fixing the iomem buffer manipulation and the reported system crash [2]. But, the fix is suboptimal in terms of performace/ugliness [3] and a proper I/O variant of sg_copy_buffer should be added and used instead. [1] https://lore.kernel.org/r/20210609150230.9291-1-narmstrong@baylibre.com [2] https://lore.kernel.org/r/acb244ad-0759-5a96-c659-5c23003d3dcd@samsung.com [3] https://lore.kernel.org/r/CAPDyKFrLSMpPJOgd5e4B1x3Vwfg4q23zgy4ESc8EmFL2MnyK7g@mail.gmail.com Neil Armstrong (2): scatterlist: add I/O variant of sg_pcopy & sg_copy mmc: meson-gx: use sg_copy_to/from_io instead of local version drivers/mmc/host/meson-gx-mmc.c | 53 +++----------- include/linux/scatterlist.h | 14 ++++ lib/scatterlist.c | 119 ++++++++++++++++++++++++++++++++ 3 files changed, 143 insertions(+), 43 deletions(-) -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic