From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF08C2B9F4 for ; Mon, 28 Jun 2021 13:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D21D761C75 for ; Mon, 28 Jun 2021 13:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232439AbhF1NxI (ORCPT ); Mon, 28 Jun 2021 09:53:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232313AbhF1Nwo (ORCPT ); Mon, 28 Jun 2021 09:52:44 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85896C061760; Mon, 28 Jun 2021 06:50:14 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id 65so9985058qko.5; Mon, 28 Jun 2021 06:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jgGEFkMArwto/hguJ5jTwXsSU4L7A/FJ08JPCBZFdjo=; b=QplwyV5rzaOnfqkvF1RDY68wW2yI1YFYhMRcU7pWOqgNs/N/bZvgTUibr8EterCWA4 Ekg4bqUy8nZitFIyD419HvXNIRp46zq4M5rpXAU1sTVnIHOB/jZcNETK1LaVya0ndlz/ 2jURLQCARDMBzkUm73devoFH3rv3GVs0S9EuwybXuNTlIkt9SjGd5YnIcQ8p1zQ5C4WA tHGfcXJdoX8RM98TqBtqr4tQAM+TmEZ1uZHacFdNgH27MCoKwYMmfQ6XmMcXb6OULz9i 3v5uvBtUZPWB6F0S9ahtFlX2goc73mwKRU5f6BJSq6pyCNLIN/hOL5tlTDzI+fma8VN+ x5Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jgGEFkMArwto/hguJ5jTwXsSU4L7A/FJ08JPCBZFdjo=; b=te+7dZ2Oe1NaC50X1ojoarY4fP7S0U2KwAH3q5AVzZEAT83B85s2rqCxJYKiLo6rQR HwZlV/cYvDtpaO3AdiWprn3+1gOLwBFS3QA/iLBKlLizmH63srKror/4WMArd/YyNYox rOEHolKV+P43Pimg+YmjJTuJtsh8v7gMtR3Ru6a7BpW0HErfpr7fwl9sDfsh3CRxTpGY uEqq6xQDifJIisEx3XzLEbmPi/rKaBYBtrJ/wbEY2YW6/tcfBejDu4KZMIHDGrodq8DR odrOulEsPnHLIZy2DbZxJFIXqkRx42fB+y80BQaXgM5NhWKI91Dt++YNNyUBfxbxiUSX ijbw== X-Gm-Message-State: AOAM532SDzDzBQsZ0SRGWRpmlbFvU4lDvjjqx2Nn5ituExgAe0y1KMR8 wuRs93+Vs9kyk2rGYuxZ29QxadUxLgo= X-Google-Smtp-Source: ABdhPJzmqYPGHZdApMOX5+0nI7tsbDj4KOUWei4oAqv0gB0IybDgSBjUSm8hGAP3XRTJk4pw3udWYg== X-Received: by 2002:a37:b8b:: with SMTP id 133mr8863456qkl.44.1624888213665; Mon, 28 Jun 2021 06:50:13 -0700 (PDT) Received: from tannerlove.nyc.corp.google.com ([2620:0:1003:1000:8502:d4aa:337:d4d]) by smtp.gmail.com with ESMTPSA id f19sm10760518qkg.70.2021.06.28.06.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 06:50:13 -0700 (PDT) From: Tanner Love To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, "David S . Miller" , Eric Dumazet , Mahesh Bandewar , "Darrick J . Wong" , Arnd Bergmann , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , John Ogness , Ingo Molnar , Jakub Kicinski , Andrii Nakryiko , Antoine Tenart , Alexander Lobakin , Wei Wang , Taehee Yoo , Yunsheng Lin , Willem de Bruijn , Tanner Love Subject: [PATCH net-next v3 2/2] net: update netdev_rx_csum_fault() print dump only once Date: Mon, 28 Jun 2021 09:50:07 -0400 Message-Id: <20210628135007.1358909-3-tannerlove.kernel@gmail.com> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog In-Reply-To: <20210628135007.1358909-1-tannerlove.kernel@gmail.com> References: <20210628135007.1358909-1-tannerlove.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tanner Love Printing this stack dump multiple times does not provide additional useful information, and consumes time in the data path. Printing once is sufficient. Changes v2: Format indentation properly Signed-off-by: Tanner Love Acked-by: Eric Dumazet Acked-by: Mahesh Bandewar --- net/core/dev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 991d09b67bd9..d609366da95c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -148,6 +148,7 @@ #include #include #include +#include #include "net-sysfs.h" @@ -3487,13 +3488,16 @@ EXPORT_SYMBOL(__skb_gso_segment); /* Take action when hardware reception checksum errors are detected. */ #ifdef CONFIG_BUG +static void do_netdev_rx_csum_fault(struct net_device *dev, struct sk_buff *skb) +{ + pr_err("%s: hw csum failure\n", dev ? dev->name : ""); + skb_dump(KERN_ERR, skb, true); + dump_stack(); +} + void netdev_rx_csum_fault(struct net_device *dev, struct sk_buff *skb) { - if (net_ratelimit()) { - pr_err("%s: hw csum failure\n", dev ? dev->name : ""); - skb_dump(KERN_ERR, skb, true); - dump_stack(); - } + DO_ONCE_LITE(do_netdev_rx_csum_fault, dev, skb); } EXPORT_SYMBOL(netdev_rx_csum_fault); #endif -- 2.32.0.93.g670b81a890-goog