From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C2EC2B9F4 for ; Mon, 28 Jun 2021 14:38:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C96B061D5F for ; Mon, 28 Jun 2021 14:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233616AbhF1OlR (ORCPT ); Mon, 28 Jun 2021 10:41:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234431AbhF1Ocr (ORCPT ); Mon, 28 Jun 2021 10:32:47 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 982F2C0611C6; Mon, 28 Jun 2021 07:23:32 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id h17so26148799edw.11; Mon, 28 Jun 2021 07:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rfKuoJAtusVapu2kMNkcCOghL39W8RTkgqPaXUuzpo8=; b=ZDRo78BaHPXxHFuzCVbfLd4RGcEPVTnhlS9BBkW9pXPF0D1YWb3CfCZroYT4gN+9yx DHJPJ6Vk6gsB2GDCvGqaNltY9IdKnbRbFiW2ZCeevawG11FbaaPem3QT6umspNl74ZGF sp+XIF68u49BhCc/fAOJhPWGAVapss6+9HA1+XYgSNMRQIX9hcNYY/HrUfycufng+SDs /iWH7Mw6UYidGttFQHvdpsBDniMNgibVXGdQoDHFnU1sm51c/EtzJ9EvGXZ59DSl9+Gp Q+3q+kR3R2Sye0HfyIgXV5O7Jb43WJwdYWw/M8Ulb47lVWdSpuFeCdHPQpdQRbU6qYGi o+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rfKuoJAtusVapu2kMNkcCOghL39W8RTkgqPaXUuzpo8=; b=YZN3auLm1D5fusVay4gpd96yVLxEgSK1TbLPHsWzlChwGC7a2XtZcNudhRLj7v+T7B kk88yY/sXMZzd1q7yoVIycWbIn3u9ps2sNT7Trdf2c+r44p5sdY+Uk9CsQ6YLxrRh0Xn rpuBcefzM4u+eIBw2MrE/c3vL7uD128BnEYUN8pd0xKcUOq5n32iN5BnKqiBRh0YZGu7 24JV4K27T7lATy54BNM1XmBs7xrwmdvd1+DiNpEhe6vxe1E6y1TssbtPPb0Hz20vV9tY tZJHXhqk0FeKihKARdOeE1safrrg5hB/SDiSGexGz6RIFtS00ciICN+Hn9Tr2SnHyAek nZXQ== X-Gm-Message-State: AOAM532AcSj4NScclQgULL2T36n/ckmmBLLJemxKoFHOwAWL+BY6u3RI lHnmH7z3NKC6KpaSiv+VVhnXaeuM0zk= X-Google-Smtp-Source: ABdhPJwfobLX0Nexj7XfdQlU1nOg96cEbyQjKFS9BY0XcmMGP7zeiIu2sXZM7wjh3rbbdIaU05pSlA== X-Received: by 2002:a05:6402:154:: with SMTP id s20mr33653045edu.103.1624890211191; Mon, 28 Jun 2021 07:23:31 -0700 (PDT) Received: from skbuf ([188.26.224.68]) by smtp.gmail.com with ESMTPSA id cd4sm6983770ejb.104.2021.06.28.07.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 07:23:30 -0700 (PDT) Date: Mon, 28 Jun 2021 17:23:29 +0300 From: Vladimir Oltean To: Lukasz Majewski Cc: Andrew Lunn , "David S . Miller" , Jakub Kicinski , Madalin Bucur , Nicolas Ferre , Joakim Zhang , Florian Fainelli , netdev@vger.kernel.org, Arnd Bergmann , Mark Einon , NXP Linux Team , linux-kernel@vger.kernel.org Subject: Re: [RFC 2/3] net: Provide switchdev driver for NXP's More Than IP L2 switch Message-ID: <20210628142329.2y7gmykoy7uh44gd@skbuf> References: <20210624125304.36636a44@ktm> <20210624163542.5b6d87ee@ktm> <20210625115935.132922ff@ktm> <20210628140526.7417fbf2@ktm> <20210628124835.zbuija3hwsnh2zmd@skbuf> <20210628161314.37223141@ktm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628161314.37223141@ktm> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 04:13:14PM +0200, Lukasz Majewski wrote: > > > > So before considering merging your changes, i would like to see a > > > > usable binding. > > > > > > > > I also don't remember seeing support for STP. Without that, your > > > > network has broadcast storm problems when there are loops. So i > > > > would like to see the code needed to put ports into blocking, > > > > listening, learning, and forwarding states. > > > > > > > > Andrew > > > > I cannot stress enough how important it is for us to see STP support > > and consequently the ndo_start_xmit procedure for switch ports. > > Ok. > > > Let me see if I understand correctly. When the switch is enabled, eth0 > > sends packets towards both physical switch ports, and eth1 sends > > packets towards none, but eth0 handles the link state of switch port > > 0, and eth1 handles the link state of switch port 1? > > Exactly, this is how FEC driver is utilized for this switch. This is a much bigger problem than anything which has to do with code organization. Linux does not have any sort of support for unmanaged switches. Please try to find out if your switch is supposed to be able to be managed (run control protocols on the CPU). If not, well, I don't know what to suggest.