From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D070EC2B9F4 for ; Mon, 28 Jun 2021 14:43:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E70E61C76 for ; Mon, 28 Jun 2021 14:43:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E70E61C76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D27AD82DCF; Mon, 28 Jun 2021 16:43:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GX9e/qWU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4CD4882DDE; Mon, 28 Jun 2021 16:43:44 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9FE8282DAF for ; Mon, 28 Jun 2021 16:43:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id 19so17327110qky.13 for ; Mon, 28 Jun 2021 07:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BIR8Q/M605/x948MLSL7dnhW8BbOS3QFf8HNs5T9MZA=; b=GX9e/qWUjrKrfShQQJ5IfznTD9eUGCKsbbJbsUk9AfxPXgIowxNIHBbDFMkVzCZ0PE JkFCAKAUPPkdwlzY2KubBOOOOQAU5VxOcoZQy43qqh4b7Xx9RMb7l59+uAXIuoXyMfV4 GKGMQ+fJSMngFXFYsZw9wEC0wfV3014ir2IjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BIR8Q/M605/x948MLSL7dnhW8BbOS3QFf8HNs5T9MZA=; b=F7NNHP424K2+0LOFbj6uvTcbK3dpwrLChF8Wzm0sFTPvz9IMLoPircZkPthIxP8q8j 9aFjSZEinEda1ZhJ/bOng+PfGXdAHUg6rv+3eq8Wscltkf5GnziaTWQsDW3a6m5wfJMy dQAAHPNoUIfBHCR5YUMRZ4YhFHiLtnueWOSrhNvn4DOh4F0vCsHkPPO27gG64E9oC6dU /Wodg/YhBtMe2dh++B8MIvSs+iAKU25r3FcSyWgoi5cVZdbILaDZjmB1U5R76GRZBcqx VN9Ox7e89fgbhe44zXVrnFG0LHddvjjWcMUaP7VFjAOy/urA0DwCsIOd8+YwnyPbXmwU Neuw== X-Gm-Message-State: AOAM533y+HDhfaaxHlwTsIJSREvWOtFqkkMBp35gxcDBa9DXehCYV5to ig3+Y1OlULPHYviANuXQL5jlcw== X-Google-Smtp-Source: ABdhPJzJg4FJFVoHtOEfBPdjFDhJz0sr39WZL8QLzPbZ+0aPmhjRgI/OX+x6r3xdZF4exll4mlGYPQ== X-Received: by 2002:a37:ac03:: with SMTP id e3mr11235883qkm.62.1624891419540; Mon, 28 Jun 2021 07:43:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2808-537e-3f88-1d98.res6.spectrum.com. [2603:6081:7b01:cbda:2808:537e:3f88:1d98]) by smtp.gmail.com with ESMTPSA id g1sm3272833qkm.58.2021.06.28.07.43.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jun 2021 07:43:38 -0700 (PDT) Date: Mon, 28 Jun 2021 10:43:36 -0400 From: Tom Rini To: Simon Glass Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Marek Vasut , Ivaylo Dimitrov , Lokesh Vutla , Merlijn Wajer , U-Boot Mailing List , Pavel Machek Subject: Re: [PATCH 1/2] DM_USB: allow building without OF_CONTROL Message-ID: <20210628144336.GI9516@bill-the-cat> References: <19957b67-732a-f53d-4453-d37ce28a92a9@denx.de> <20210625123847.GM9516@bill-the-cat> <20210625130752.uuh4imvgrab6dylq@pali> <20210625161605.2kabnsfeoxgecapp@pali> <20210625165850.nvp64zovs27b62tz@pali> <20210628133927.GZ9516@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VjdAulSyFLm6MpFE" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --VjdAulSyFLm6MpFE Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 28, 2021 at 08:20:31AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 28 Jun 2021 at 07:39, Tom Rini wrote: > > > > On Sun, Jun 27, 2021 at 01:06:12PM -0600, Simon Glass wrote: > > > Hi Pali, > > > > > > On Fri, 25 Jun 2021 at 10:58, Pali Roh=E1r wrote: > > > > > > > > On Friday 25 June 2021 10:43:11 Simon Glass wrote: > > > > > Hi Pali, > > > > > > > > > > On Fri, 25 Jun 2021 at 10:16, Pali Roh=E1r wrot= e: > > > > > > > > > > > > On Friday 25 June 2021 10:04:14 Simon Glass wrote: > > > > > > > But I do wonder about the > > > > > > > 100KB growth you saw with DT/DM. That seems absolutely enormo= us to me! > > > > > > > Can you please point me to the git tree for this? I'd like to > > > > > > > investigate. > > > > > > > > > > > > Patches in this series were written by Ivo. I do not know exact= details > > > > > > and numbers. But the fact is that it was required to enable thu= mb-2 mode > > > > > > (which has hw bugs on this cpu, see earlier emails; reason why = it was > > > > > > disabled). If you want to investigate it, you can try compare u= -boot > > > > > > from master/next and u-boot with applying these patches + disab= le > > > > > > thumb-2 mode. Note that we have already enabled LTO. > > > > > > > > > > > > > > > > That's probably a little beyond my level of enthusiasm. But if yo= u are > > > > > able to push a tree with before/after commits, I will take a look. > > > > > > > > Hello Simon! I have already pushed these patches to github due to CI > > > > testing. So you can easily access them via git fetch/checkout. > > > > > > > > Before (this is already in u-boot git): > > > > $ git checkout a298d4fbcdba1b38e48ea2af0fc5386cab2070da > > > > > > > > After1: > > > > $ git fetch https://github.com/u-boot/u-boot.git refs/pull/83/head > > > > $ git checkout 1f038c8b45ef0018e52a2a4587eb73170769ac2f > > > > > > > > After2: > > > > =3D use After1 with: > > > > + disable CONFIG_SYS_THUMB_BUILD > > > > + enable CONFIG_OF_LIBFDT_OVERLAY > > > > + enable CONFIG_CMD_FDT > > > > > > > > defconfig file is nokia_rx51_defconfig > > > > > > OK thanks, I see it. I pushed a tree to u-boot-dm/nokia_rx51 with a > > > few changes. The growth is about 19KB (without enabling Thumb). Some > > > more fine-grained control of what get enabled with LIBFDT could be > > > added to reduce that, perhaps by 5KB. > > > > So, was the entirety of the reduction you saw from dropping out > > EFI_LOADER? Just most of it? Disabling that came up in another part of > > this thread. And if we just need to disable EFI_LOADER, > > OF_LIBFDT_OVERLAY and CMD_FDT (and maybe tweak the mask value) in order > > to not need to do any other changes, yes, that's the right approach. It >=20 > For me, it dropped the size by about 90KB, although I'm including > text, rodata and data in that number: >=20 > default > arm: (for 1/1 boards) all +129370.0 bss +1136.0 data +7399.0 > rodata +10989.0 text +109846.0 >=20 > without ebbr > arm: (for 1/1 boards) all +38460.0 bss +1040.0 data +2375.0 > rodata +5333.0 text +29712.0 OK, so does this mean that with the right options disabled, and without thumb for now, rx51 can just use a DT? Pali? Ivaylo? --=20 Tom --VjdAulSyFLm6MpFE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDZ4BAACgkQFHw5/5Y0 tyyCCwv+PV6Os/kaBG3KrkKIczC8T7lBjN44Mpj3MVtO9EAg9Rxw+voI9MH3l0Q2 mqVh8Xq+9mP376DdyjZNYo2mI4Y9e8u/rtNPIMp4wXalNC/ybZC0OrXDTSeYhRZE LA7NWIj653rz1sfQ3c5yDKin+5lIU89c8c2R1Y23PPeSXDfKizeYGYzfrRyo6LIY raGIHCTBskppZddVDr6tnys99L5cMK4dQDaa/Z36mExqzTfvevnM58LumeSYlLZn zAzUpxRcQsrflWax9ZyMKP1ZCkdurEdIb4M97kt5gNesiVDIjpjLX3IuIOKuSzCt Lotd+gXXX/Uq1/lElsgEXESpR7mzD7Rt8Bk+PnVEu118HHVLwQsTKZVn4x/VOEyP nKpUAY62noQKOWElDsEhB6mnKB8qpSqU8kSnP9US0yoqpdtBf8xcaEnahwdO7sO3 VZ7X+v1IMk6fCrsl96zIrGfQIeiNTSYVSoTO2/wuT3AedOxhh/lA9S0KeaiWINdZ AE2O8biz =Ewsh -----END PGP SIGNATURE----- --VjdAulSyFLm6MpFE--