All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/page_alloc: do bulk array bounds check after checking populated elements
Date: Mon, 28 Jun 2021 10:48:05 -0400	[thread overview]
Message-ID: <20210628144805.GA3687@codemonkey.org.uk> (raw)
In-Reply-To: <20210628115322.GA3840@techsingularity.net>

On Mon, Jun 28, 2021 at 12:53:23PM +0100, Mel Gorman wrote:

 > > This made it into 5.13 final, and completely breaks NFSD for me (Serving tcp v3 mounts).
 > > Existing mounts on clients hang, as do new mounts from new clients.
 > > Rebooting the server back to rc7 everything recovers.  Bisect lands on
 > > this commit.
 > 
 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
 > index ef2265f86b91..04220581579c 100644
 > --- a/mm/page_alloc.c
 > +++ b/mm/page_alloc.c
 > @@ -5058,7 +5058,7 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid,
 >  
 >  	/* Already populated array? */
 >  	if (unlikely(page_array && nr_pages - nr_populated == 0))
 > -		return 0;
 > +		return nr_populated;

Yep, this works.

	Dave


  reply	other threads:[~2021-06-28 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 12:51 [PATCH] mm/page_alloc: do bulk array bounds check after checking populated elements Mel Gorman
2021-06-28  4:27 ` Dave Jones
2021-06-28  4:59   ` Dave Jones
2021-06-28 11:53   ` Mel Gorman
2021-06-28 14:48     ` Dave Jones [this message]
2021-06-28 15:03       ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628144805.GA3687@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=brouer@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.