From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Haakon Bugge <haakon.bugge@oracle.com>,
Anand Khoje <anand.a.khoje@oracle.com>,
OFED mailing list <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Subject: Re: [PATCH v6 for-next 0/2] IB/core: Obtaining subnet_prefix from cache in
Date: Mon, 28 Jun 2021 14:02:58 -0300 [thread overview]
Message-ID: <20210628170258.GD4604@ziepe.ca> (raw)
In-Reply-To: <YNhiC45Si+XHP87i@unreal>
On Sun, Jun 27, 2021 at 02:33:31PM +0300, Leon Romanovsky wrote:
> On Sun, Jun 27, 2021 at 10:40:43AM +0000, Haakon Bugge wrote:
> >
> >
> > > On 27 Jun 2021, at 12:31, Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > On Sun, Jun 27, 2021 at 12:17:51PM +0530, Anand Khoje wrote:
> > >> This v6 patch series is used to read the port_attribute subnet_prefix
> > >> from a valid cache entry instead of having to call
> > >> device->ops.query_gid() for Infiniband link-layer devices in
> > >> __ib_query_port().
> > >>
> > >> In the event of a cache update, the value for subnet_prefix gets read
> > >> using device->ops.query_gid() in config_non_roce_gid_cache().
> > >>
> > >> Anand Khoje (2):
> > >> IB/core: Updating cache for subnet_prefix in
> > >> config_non_roce_gid_cache()
> > >> IB/core: Read subnet_prefix in ib_query_port via cache.
> > >
> > > This series breaks mlx4/mlx5. You forgot to call to lock_init or
> > > something like that.
> >
> > Thanks for catching!
> >
> > Sure, in ib_register_device(), setup_device() (which ends up calling __ib_query_port()) is called before ib_cache_setup_one(). Can these two calls have their order swapped?
>
> I don't think so, if I didn't miss anything, we are relying in gid_table_setup_one()
> on some properties from setup_device().
Just reorder things enough so that the cache_lock is setup earlier, it
has no business being in cache_setup_one anyhow.
Jason
prev parent reply other threads:[~2021-06-28 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 6:47 [PATCH v6 for-next 0/2] IB/core: Obtaining subnet_prefix from cache in Anand Khoje
2021-06-27 6:47 ` [PATCH v6 for-next 1/2] IB/core: Updating cache for subnet_prefix in config_non_roce_gid_cache() Anand Khoje
2021-06-27 6:47 ` [PATCH v6 for-next 2/2] IB/core: Read subnet_prefix in ib_query_port via cache Anand Khoje
2021-06-27 10:31 ` [PATCH v6 for-next 0/2] IB/core: Obtaining subnet_prefix from cache in Leon Romanovsky
2021-06-27 10:40 ` Haakon Bugge
2021-06-27 11:33 ` Leon Romanovsky
2021-06-28 17:02 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628170258.GD4604@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=anand.a.khoje@oracle.com \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.