All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Cancemi <kurt@x64architecture.com>
To: netdev@vger.kernel.org
Cc: Kurt Cancemi <kurt@x64architecture.com>
Subject: [PATCH 0/1] Possible Issue Setting the Delay Flags in the Marvell Net PHY Driver
Date: Mon, 28 Jun 2021 15:28:25 -0400	[thread overview]
Message-ID: <20210628192826.1855132-1-kurt@x64architecture.com> (raw)

Hi,

I believe there is an issue setting the RX and TX delay flags in the Marvell
net PHY driver. This patch fixes the issue for me but I am not convinced that
this is the right way to fix the issue or that this patch will not cause side
effects for other models. Feedback and comments are greatly appreciated.

Backstory:

I have been troubleshooting getting ethernet to work on a board based off of
the NXP T2080RDB (with DPAA ethernet). It has a Marvell 88E1510 PHY chip.
When attempting to use ping to verify that the ethernet was working I was
only getting RX and TX errors. Upon further debugging I discovered that the
RX and TX delay flags were not being set.

I believe there is an issue because of the following:

* The DPAA memac driver correctly reports that the device tree ethernet
  "phy-connection-type" is set to "rgmii-id" and the of_get_phy_mode()
  function correctly returns 0x8 "PHY_INTERFACE_MODE_RGMII_ID"

* A similar fix for this same issue was incorporated into U-Boot back in 2018:
  https://github.com/u-boot/u-boot/commit/431be621c6cbc72efd1d45fa36686a682cbb470a

* The ethernet works with the attached patch.

Kurt

Kurt Cancemi (1):
  net: phy: marvell: Fixed handing of delays with plain RGMII interface

 drivers/net/phy/marvell.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.32.0


             reply	other threads:[~2021-06-28 19:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 19:28 Kurt Cancemi [this message]
2021-06-28 19:28 ` [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface Kurt Cancemi
2021-06-28 22:49   ` Marek Behún
2021-06-28 23:01     ` Marcin Wojtas
2021-06-29  0:05       ` Kurt Cancemi
2021-06-29  0:21         ` Marek Behún
     [not found]     ` <CADujJWWoWRyW3S+f3F_Zhq9H90QZ1W4eu=5dyad3DeMLHFp2TA@mail.gmail.com>
2021-06-29  0:23       ` Marek Behún
2021-06-29  1:12         ` Kurt Cancemi
2021-06-29 10:52           ` Marek Behún
2021-06-29 15:08             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628192826.1855132-1-kurt@x64architecture.com \
    --to=kurt@x64architecture.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.