From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F46C11F66 for ; Tue, 29 Jun 2021 06:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BECC61D92 for ; Tue, 29 Jun 2021 06:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232099AbhF2GMA (ORCPT ); Tue, 29 Jun 2021 02:12:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232040AbhF2GL7 (ORCPT ); Tue, 29 Jun 2021 02:11:59 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0790FC061766 for ; Mon, 28 Jun 2021 23:09:32 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id d12so17529001pgd.9 for ; Mon, 28 Jun 2021 23:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yv7EEUQoiKqhop6AB04pLVKMYLWu1sR4zDrGtQgBw+g=; b=aoLs43qrv+77ukkA/Df5zJJwPwO210bGQSahFnhXMqpDL05rKg9TB8NzI1q81snkYP HUsP/n3DeX/hoNBS4hY4b3Ce6gUpSfPbCdjg2+pldPGtVGazXWzY6wN4H0ZFMisLB2/e p4J+LHIJG2MjJZJCFRKSRwFyKHG3qk0Q0U/fXcO8KhZWbt44D1Q/IieeqnTL+ohkTkyi VvCUdWqFDPYAQvRCCYjSWQZ30twGT6lxaSg+yzdxZRRs8pZFM0lNnBJg+m7S4UdxxL8F NqCoAKnIBNFvNME/lnHXvj/TpM3JPoyULNJ8aRora0S9VQPCggXKwUXE4ZyXfThBohzp AUNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yv7EEUQoiKqhop6AB04pLVKMYLWu1sR4zDrGtQgBw+g=; b=oHYMRkd1n1vI7dfLH4r5L2xw/fLtH5+KtYCW1itskPJEKuERbcYDO9W08PvvsUJtij snKUS+GrS8KonG6y9pSQvNp+rf4A92mwlA7GSZJedMXiTVYBdwl1NRNROg3dQ34N+NUq 7sSE5nvIxYXE0/QE8/hF6oV8WTf8xPyU6MBqESkYX4vGVV/laobBGAS2ho8sS/eoWofX xYFUY741fnkxt/z5cup+jx5IG20AUm/PR7jIGyYU7wVSnG37MnokaoPVel0hhX1aQCJq CgE5X8qO2527KXbIP9SBFPAzIeymSfKNvVlqG8B5ntO5cL0/LoKt0GN/8pw7S00sez0d 5EXQ== X-Gm-Message-State: AOAM531e0T9h0LoaH/Rw3WhialwhoeA7KMvOczgqb/JWkjUKi1x9XoL+ Mi4CrOYoWri5DJer3Y4dE5GmEA== X-Google-Smtp-Source: ABdhPJzsx5q2/A7x8D0k31KuFdMYdLJxqIBjhNKJPqPdRLhItpNrKvUm4MwgWGiy8caPvSMtXQ5Olg== X-Received: by 2002:aa7:9252:0:b029:2ae:bde3:621f with SMTP id 18-20020aa792520000b02902aebde3621fmr28464344pfp.18.1624946971463; Mon, 28 Jun 2021 23:09:31 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([103.207.71.35]) by smtp.gmail.com with ESMTPSA id 69sm16753945pfz.110.2021.06.28.23.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 23:09:30 -0700 (PDT) Date: Tue, 29 Jun 2021 14:09:24 +0800 From: Leo Yan To: Mathieu Poirier Cc: James Clark , acme@kernel.org, coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, John Garry , Will Deacon , Mike Leach , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/2] perf cs-etm: Split --dump-raw-trace by AUX records Message-ID: <20210629060924.GD163942@leoy-ThinkPad-X240s> References: <20210624164303.28632-1-james.clark@arm.com> <20210624164303.28632-3-james.clark@arm.com> <20210628012744.GA158794@leoy-ThinkPad-X240s> <20210628120802.GC200044@leoy-ThinkPad-X240s> <20210628200132.GB1200359@p14s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628200132.GB1200359@p14s> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, On Mon, Jun 28, 2021 at 02:01:32PM -0600, Mathieu Poirier wrote: [...] > > > Hi Leo, > > > > > > I think this is not true in piped mode because there is no auxtrace index. > > > In that mode, events are processed only in file order and cs_etm__process_auxtrace_event() > > > is called for each buffer. > > > > > > You can reproduce this with something like this: > > > > > > ./perf record -o - ls > stdio.data > > > cat stdio.data | ./perf report -i - > > > > You are right! I tried these two commands with cs_etm event, just as > > you said, in this case, the AUX trace data is not queued; so the flow > > for "if (!etm->data_queued)" should be kept. If so, I am very fine > > for current change. Thanks for sharing the knowledge. > > > > > There are some other Coresight features that don't work as expected in this mode, like > > > sorting timestamps between CPUs. The aux split patchset won't work either because random > > > access isn't possible. And the TRBE patch that I'm working on now won't work, because it > > > also requires the random access to lookup the flags on the AUX record to configure the > > > decoder for unformatted trace. > > > > There is a lot of things happening in this area. Based on the above should I > still plan to review this set or should I wait for another revision? I think you could continue to review this patch set for AUX data splitting. Since we have concern for the AUX data splitting with snapshot mode, James and me both have verified the AUX data splitting (this patch set) with snapshot mode, and the testing result shows this patch set is reliable. Regard another patch set for fixing snapshot mode [1], I will send a new version (drop patch 1/3 and refine for patch 3/3), so you could hold on for that patch set. Thanks, Leo [1] https://lore.kernel.org/patchwork/cover/1437696/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA865C11F66 for ; Tue, 29 Jun 2021 06:12:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A757061DA0 for ; Tue, 29 Jun 2021 06:12:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A757061DA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DvOug9fUTgwjckP4y60wnoQ6y/QQubq5BXk1QGloaZU=; b=XytfLX7TaYNRo7 g36Uylpei//iKvxIBIxucRkaz16dJaE3zkODc9XwMP1jE1gE0IfWvu7CtnRevI6o0T6GKi1+mqKdc bQE5WVVg+5a3roGVZp3dLRf9vXOHl4inJJHfeJqhpM9kb8ty5OK/WUTUzIAT8pdNFDi21cnCX0yJL H4hxo8+NfMD4CD8Yt9970N37CzLF3JicKmbwDTB9ZXnGL0Mo1OjdYhNR8Z6f2m91nC00tLdC4uA0Q FhvtVhQ3EeimcMpPbnwv2oXGe29ztF5hhvQ3XbO7Ibfy+OVmQtOqq1iHeGNFAfClHNyV01JT4ct6/ Z/L1oDGGbuzgZZIHownw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ly6wC-009rx9-Dc; Tue, 29 Jun 2021 06:09:36 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ly6w9-009rwo-4g for linux-arm-kernel@lists.infradead.org; Tue, 29 Jun 2021 06:09:34 +0000 Received: by mail-pg1-x52a.google.com with SMTP id a2so17518768pgi.6 for ; Mon, 28 Jun 2021 23:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yv7EEUQoiKqhop6AB04pLVKMYLWu1sR4zDrGtQgBw+g=; b=aoLs43qrv+77ukkA/Df5zJJwPwO210bGQSahFnhXMqpDL05rKg9TB8NzI1q81snkYP HUsP/n3DeX/hoNBS4hY4b3Ce6gUpSfPbCdjg2+pldPGtVGazXWzY6wN4H0ZFMisLB2/e p4J+LHIJG2MjJZJCFRKSRwFyKHG3qk0Q0U/fXcO8KhZWbt44D1Q/IieeqnTL+ohkTkyi VvCUdWqFDPYAQvRCCYjSWQZ30twGT6lxaSg+yzdxZRRs8pZFM0lNnBJg+m7S4UdxxL8F NqCoAKnIBNFvNME/lnHXvj/TpM3JPoyULNJ8aRora0S9VQPCggXKwUXE4ZyXfThBohzp AUNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yv7EEUQoiKqhop6AB04pLVKMYLWu1sR4zDrGtQgBw+g=; b=TEGqNetBtW+U3qeugI6J282PZM1T6G77vN35xbwBpcq5gAh/Das6HMVGsLpCsEBnQC BNAwCwZm97uDeqtz7GpLducgX/K+WuRg2OU3JK0DDZzvJh4en0SLX5B+JKzIpZaD5mre iI6CHstHLQtWSkhvOM/0suQElESn8102zi68g2pHzZx84vqKlCoafc/8kLnlIXtQuZ8/ WpdxiD/zRWfndOJEko5e61kVXLWg3offeCfdrh0aCBT0eCsAEJK+KOHuo7cdDX2YvS+I CbgbLBQWcdzm981f1MH0HTWmwMLRc/+/RdXelZS7VP0Tv2HZaYYNYChIcAwKIHvepZkA Wfyg== X-Gm-Message-State: AOAM533BtDERPAmPJDMCPSUPl+hfzd0I/UbONk5V8uWkDO1uyrNlYE2g YY2wPapKBl6u9bPBBDiM8eILtQ== X-Google-Smtp-Source: ABdhPJzsx5q2/A7x8D0k31KuFdMYdLJxqIBjhNKJPqPdRLhItpNrKvUm4MwgWGiy8caPvSMtXQ5Olg== X-Received: by 2002:aa7:9252:0:b029:2ae:bde3:621f with SMTP id 18-20020aa792520000b02902aebde3621fmr28464344pfp.18.1624946971463; Mon, 28 Jun 2021 23:09:31 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([103.207.71.35]) by smtp.gmail.com with ESMTPSA id 69sm16753945pfz.110.2021.06.28.23.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 23:09:30 -0700 (PDT) Date: Tue, 29 Jun 2021 14:09:24 +0800 From: Leo Yan To: Mathieu Poirier Cc: James Clark , acme@kernel.org, coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, anshuman.khandual@arm.com, John Garry , Will Deacon , Mike Leach , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/2] perf cs-etm: Split --dump-raw-trace by AUX records Message-ID: <20210629060924.GD163942@leoy-ThinkPad-X240s> References: <20210624164303.28632-1-james.clark@arm.com> <20210624164303.28632-3-james.clark@arm.com> <20210628012744.GA158794@leoy-ThinkPad-X240s> <20210628120802.GC200044@leoy-ThinkPad-X240s> <20210628200132.GB1200359@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210628200132.GB1200359@p14s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210628_230933_261694_C4BE6188 X-CRM114-Status: GOOD ( 27.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Mon, Jun 28, 2021 at 02:01:32PM -0600, Mathieu Poirier wrote: [...] > > > Hi Leo, > > > > > > I think this is not true in piped mode because there is no auxtrace index. > > > In that mode, events are processed only in file order and cs_etm__process_auxtrace_event() > > > is called for each buffer. > > > > > > You can reproduce this with something like this: > > > > > > ./perf record -o - ls > stdio.data > > > cat stdio.data | ./perf report -i - > > > > You are right! I tried these two commands with cs_etm event, just as > > you said, in this case, the AUX trace data is not queued; so the flow > > for "if (!etm->data_queued)" should be kept. If so, I am very fine > > for current change. Thanks for sharing the knowledge. > > > > > There are some other Coresight features that don't work as expected in this mode, like > > > sorting timestamps between CPUs. The aux split patchset won't work either because random > > > access isn't possible. And the TRBE patch that I'm working on now won't work, because it > > > also requires the random access to lookup the flags on the AUX record to configure the > > > decoder for unformatted trace. > > > > There is a lot of things happening in this area. Based on the above should I > still plan to review this set or should I wait for another revision? I think you could continue to review this patch set for AUX data splitting. Since we have concern for the AUX data splitting with snapshot mode, James and me both have verified the AUX data splitting (this patch set) with snapshot mode, and the testing result shows this patch set is reliable. Regard another patch set for fixing snapshot mode [1], I will send a new version (drop patch 1/3 and refine for patch 3/3), so you could hold on for that patch set. Thanks, Leo [1] https://lore.kernel.org/patchwork/cover/1437696/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel