From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F696C11F68 for ; Wed, 30 Jun 2021 08:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46D3B61D07 for ; Wed, 30 Jun 2021 08:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233502AbhF3IaJ (ORCPT ); Wed, 30 Jun 2021 04:30:09 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:5945 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233089AbhF3IaH (ORCPT ); Wed, 30 Jun 2021 04:30:07 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GFDs91ybVz75pY for ; Wed, 30 Jun 2021 16:24:13 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 30 Jun 2021 16:27:34 +0800 Received: from huawei.com (10.175.104.170) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 30 Jun 2021 16:27:34 +0800 From: wuguanghao To: , CC: , , Subject: [PATCH v2 09/12] lib/ss/error.c: check return value malloc in ss_name() Date: Wed, 30 Jun 2021 16:27:21 +0800 Message-ID: <20210630082724.50838-10-wuguanghao3@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210630082724.50838-2-wuguanghao3@huawei.com> References: <20210630082724.50838-2-wuguanghao3@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.170] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Zhiqiang Liu In ss_name(), we should check return value of malloc(), otherwise, it may cause a segmentation fault problem. Signed-off-by: Zhiqiang Liu Signed-off-by: Wu Guanghao --- lib/ss/error.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ss/error.c b/lib/ss/error.c index 8d345a9f..656b71be 100644 --- a/lib/ss/error.c +++ b/lib/ss/error.c @@ -42,6 +42,8 @@ char *ss_name(int sci_idx) (strlen(infop->subsystem_name)+ strlen(infop->current_request)+ 4)); + if (ret_val == (char *)NULL) + return ((char *)NULL); cp = ret_val; cp1 = infop->subsystem_name; while (*cp1) -- 2.19.1