From: Lecopzer Chen <lecopzer.chen@mediatek.com>
To: <keescook@chromium.org>, <samitolvanen@google.com>,
<linux-kbuild@vger.kernel.org>
Cc: <clang-built-linux@googlegroups.com>,
<linux-kernel@vger.kernel.org>, <yj.chiang@mediatek.com>,
<masahiroy@kernel.org>, <michal.lkml@markovi.net>,
Lecopzer Chen <lecopzer.chen@mediatek.com>
Subject: [PATCH 0/2] Kbuild: lto: add make version checking
Date: Wed, 30 Jun 2021 20:14:34 +0800 [thread overview]
Message-ID: <20210630121436.19581-1-lecopzer.chen@mediatek.com> (raw)
LTO with MODVERSION will fail in generating correct CRC because
the makefile rule doesn't work for make with version 3.8X.
Refer to [1]:
> When building modules(CONFIG_...=m), I found some of module versions
> are incorrect and set to 0.
> This can be found in build log for first clean build which shows
> WARNING: EXPORT symbol "XXXX" [drivers/XXX/XXX.ko] version generation failed,
> symbol will not be versioned.
> But in second build(incremental build), the WARNING disappeared and the
> module version becomes valid CRC and make someone who want to change
> modules without updating kernel image can't insert their modules.
> The problematic code is
> + $(foreach n, $(filter-out FORCE,$^), \
> + $(if $(wildcard $(n).symversions), \
> + ; cat $(n).symversions >> $@.symversions))
The issue fixed when make version upgrading to 4.2.
Thus we need to check make version during selecting on LTO Kconfig.
The MAKE_VERSION_INT means MAKE_VERSION in canonical digits integer and
implemnted by imitating CLANG_VERSION.
[1] https://lore.kernel.org/lkml/20210616080252.32046-1-lecopzer.chen@mediatek.com/
Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
Lecopzer Chen (2):
Kbuild: lto: add make-version macros
Kbuild: lto: add make version checking
Makefile | 2 +-
arch/Kconfig | 1 +
init/Kconfig | 4 ++++
scripts/Kconfig.include | 3 +++
scripts/make-version.sh | 13 +++++++++++++
5 files changed, 22 insertions(+), 1 deletion(-)
create mode 100755 scripts/make-version.sh
--
2.18.0
next reply other threads:[~2021-06-30 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 12:14 Lecopzer Chen [this message]
2021-06-30 12:14 ` [PATCH 1/2] Kbuild: lto: add make-version macros Lecopzer Chen
2021-06-30 17:02 ` Nathan Chancellor
2021-07-01 8:52 ` Lecopzer Chen
2021-06-30 12:14 ` [PATCH 2/2] Kbuild: lto: add make version checking Lecopzer Chen
2021-06-30 17:08 ` Nathan Chancellor
2021-07-01 8:55 ` Lecopzer Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630121436.19581-1-lecopzer.chen@mediatek.com \
--to=lecopzer.chen@mediatek.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=samitolvanen@google.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.